From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Daley Subject: [PATCH 3/6] net/enic: set rte errno to positive value Date: Thu, 3 May 2018 12:37:10 -0700 Message-ID: <20180503193713.20622-3-johndale@cisco.com> References: <20180503193713.20622-1-johndale@cisco.com> Cc: dev@dpdk.org, johndale , Hyong Youb Kim To: ferruh.yigit@intel.com Return-path: Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) by dpdk.org (Postfix) with ESMTP id DC58E23C for ; Thu, 3 May 2018 21:45:23 +0200 (CEST) In-Reply-To: <20180503193713.20622-1-johndale@cisco.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: johndale Related to d9fff8a31, where rte_errno should always have positive errno values. Technically this is an ABI change since it fixes an error code introduced in 18.02, but is minor and inconsequential. Fixes: 1e81dbb5321b ("net/enic: add Tx prepare handler") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley Reviewed-by: Aaron Conole --- drivers/net/enic/enic_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_rxtx.c b/drivers/net/enic/enic_rxtx.c index aa3393700..8853a2044 100644 --- a/drivers/net/enic/enic_rxtx.c +++ b/drivers/net/enic/enic_rxtx.c @@ -510,7 +510,7 @@ uint16_t enic_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, m = tx_pkts[i]; ol_flags = m->ol_flags; if (ol_flags & wq->tx_offload_notsup_mask) { - rte_errno = -ENOTSUP; + rte_errno = ENOTSUP; return i; } #ifdef RTE_LIBRTE_ETHDEV_DEBUG -- 2.16.2