From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEKeq-0000vc-PG for qemu-devel@nongnu.org; Thu, 03 May 2018 16:16:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEKep-0000PR-S0 for qemu-devel@nongnu.org; Thu, 03 May 2018 16:16:52 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35234 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fEKep-0000P6-MN for qemu-devel@nongnu.org; Thu, 03 May 2018 16:16:51 -0400 Date: Thu, 3 May 2018 23:16:50 +0300 From: "Michael S. Tsirkin" Message-ID: <20180503231610-mutt-send-email-mst@kernel.org> References: <1525376963-79623-1-git-send-email-mst@redhat.com> <1525376963-79623-42-git-send-email-mst@redhat.com> <84109984-6157-7fe3-ae35-2487f0c65b22@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84109984-6157-7fe3-ae35-2487f0c65b22@redhat.com> Subject: Re: [Qemu-devel] [PATCH 41/67] tcg-pool.inc.c: replace command line flags with preprocessor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, berrange@redhat.com, kwolf@redhat.com, peter.maydell@linaro.org On Thu, May 03, 2018 at 03:12:16PM -0500, Eric Blake wrote: > On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote: > > Each target is currently built with a different set of include > > directories, this is what makes it possible to pull in a separate copy > > of cpu.h depending on the target. > > > > Replace with per-target ifdefs which are easier to understand. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > include/tcg-pool.inc.c | 1 + > > 1 file changed, 1 insertion(+) > > create mode 100644 include/tcg-pool.inc.c > > > > diff --git a/include/tcg-pool.inc.c b/include/tcg-pool.inc.c > > new file mode 100644 > > index 0000000..d04a981 > > --- /dev/null > > +++ b/include/tcg-pool.inc.c > > @@ -0,0 +1 @@ > > +#include_next "../tcg/tcg-pool.inc.c" > > Bad copy-and-paste in the commit message? Yes :( > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org