From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: ethernet: sun: niu set correct packet size in skb
Date: Fri, 04 May 2018 12:56:26 -0400 (EDT)
Message-ID: <20180504.125626.1889054644844307730.davem@davemloft.net>
References: <60bfe424f5c1427633fc67443d9c538c@taglang.io>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org
To: rob@taglang.io
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:35564 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751262AbeEDQ41 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 4 May 2018 12:56:27 -0400
In-Reply-To: <60bfe424f5c1427633fc67443d9c538c@taglang.io>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Rob Taglang <rob@taglang.io>
Date: Thu, 03 May 2018 17:13:06 -0400

> Currently, skb->len and skb->data_len are set to the page size, not
> the packet size. This causes the frame check sequence to not be
> located at the "end" of the packet resulting in ethernet frame check
> errors. The driver does work currently, but stricter kernel facing
> networking solutions like OpenVSwitch will drop these packets as
> invalid.
> 
> These changes set the packet size correctly so that these errors no
> longer occur. The length does not include the frame check sequence, so
> that subtraction was removed.
> 
> Tested on Oracle/SUN Multithreaded 10-Gigabit Ethernet Network
> Controller [108e:abcd] and validated in wireshark.
> 
> Signed-off-by: Rob Taglang <rob@taglang.io>
> ---
>  drivers/net/ethernet/sun/niu.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sun/niu.c
> b/drivers/net/ethernet/sun/niu.c
> index f081de4..88c1247 100644
> --- a/drivers/net/ethernet/sun/niu.c
> +++ b/drivers/net/ethernet/sun/niu.c
> @@ -3443,7 +3443,7 @@ static int niu_process_rx_pkt(struct napi_struct
> *napi, struct niu *np,

Still corrupted.  Your email client is chopping up long lines.

Please, send a test patch to yourself and make sure you can apply the
patch that arrives in that test email.

Thank you.