From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEP6n-0004ZO-6p for qemu-devel@nongnu.org; Thu, 03 May 2018 21:02:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEP6k-0007Z9-6o for qemu-devel@nongnu.org; Thu, 03 May 2018 21:02:01 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40270 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fEP6k-0007YL-2n for qemu-devel@nongnu.org; Thu, 03 May 2018 21:01:58 -0400 Date: Fri, 4 May 2018 04:01:49 +0300 From: "Michael S. Tsirkin" Message-ID: <20180504035934-mutt-send-email-mst@kernel.org> References: <1525376963-79623-1-git-send-email-mst@redhat.com> <1525376963-79623-27-git-send-email-mst@redhat.com> <1f476403-7ba8-a1f1-363c-b866dd6f4d4b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f476403-7ba8-a1f1-363c-b866dd6f4d4b@redhat.com> Subject: Re: [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, kwolf@redhat.com, peter.maydell@linaro.org, Eric Blake , Richard Henderson , Paolo Bonzini On Fri, May 04, 2018 at 02:35:49AM +0200, Thomas Huth wrote: > On 03.05.2018 21:51, Michael S. Tsirkin wrote: > > Each target is currently built with a different set of include > > directories, this is what makes it possible to pull in a separate copy > > of cpu.h depending on the target. > > > > Replace with per-target ifdefs which are easier to understand. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > include/cpu.h | 2 ++ > > 1 file changed, 2 insertions(+) > > create mode 100644 include/cpu.h > > > > diff --git a/include/cpu.h b/include/cpu.h > > new file mode 100644 > > index 0000000..b18f163 > > --- /dev/null > > +++ b/include/cpu.h > > @@ -0,0 +1,2 @@ > > +#include "target-dir.h" > > +#include TARGET_DIR(cpu.h) > > That's a *bad* idea. As far as I can see, this way, cpu.h is now > suddenly available to generic, non-target specific code. The headers in > target/* are "hidden" by purpose for all code that gets compiled via > common-obj-y and if you now make it available for everybody again, we'll > end up in ugly situation where common code might have been compiled with > target specific defines from target specific headers... Please don't do > that! > > Thomas Are you sure that is the case? TARGET_XXX defines really shouldn't be set for non-target specific code. -- MST