All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	Parav Pandit <pandit.parav@gmail.com>, Tejun Heo <tj@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v1] rdmacg: Convert to use match_string() helper
Date: Fri, 4 May 2018 06:56:49 +0800	[thread overview]
Message-ID: <201805040627.kz10kn1Y%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180503174952.21480-1-andriy.shevchenko@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 3261 bytes --]

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on cgroup/for-next]
[also build test ERROR on v4.17-rc3 next-20180503]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/rdmacg-Convert-to-use-match_string-helper/20180504-060313
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
config: x86_64-randconfig-x010-201817 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   kernel/cgroup/rdma.c: In function 'parse_resource':
>> kernel/cgroup/rdma.c:385:4: error: break statement not within loop or switch
       break;
       ^~~~~

vim +385 kernel/cgroup/rdma.c

39d3e758 Parav Pandit    2017-01-10  361  
39d3e758 Parav Pandit    2017-01-10  362  static int parse_resource(char *c, int *intval)
39d3e758 Parav Pandit    2017-01-10  363  {
39d3e758 Parav Pandit    2017-01-10  364  	substring_t argstr;
39d3e758 Parav Pandit    2017-01-10  365  	char *name, *value = c;
39d3e758 Parav Pandit    2017-01-10  366  	size_t len;
9022ddfd Andy Shevchenko 2018-05-03  367  	int ret, i;
39d3e758 Parav Pandit    2017-01-10  368  
39d3e758 Parav Pandit    2017-01-10  369  	name = strsep(&value, "=");
39d3e758 Parav Pandit    2017-01-10  370  	if (!name || !value)
39d3e758 Parav Pandit    2017-01-10  371  		return -EINVAL;
39d3e758 Parav Pandit    2017-01-10  372  
39d3e758 Parav Pandit    2017-01-10  373  	len = strlen(value);
39d3e758 Parav Pandit    2017-01-10  374  
9022ddfd Andy Shevchenko 2018-05-03  375  	i = match_string(rdmacg_resource_names, RDMACG_RESOURCE_MAX, name);
9022ddfd Andy Shevchenko 2018-05-03  376  	if (i < 0)
9022ddfd Andy Shevchenko 2018-05-03  377  		return i;
39d3e758 Parav Pandit    2017-01-10  378  
39d3e758 Parav Pandit    2017-01-10  379  	argstr.from = value;
39d3e758 Parav Pandit    2017-01-10  380  	argstr.to = value + len;
39d3e758 Parav Pandit    2017-01-10  381  
39d3e758 Parav Pandit    2017-01-10  382  	ret = match_int(&argstr, intval);
39d3e758 Parav Pandit    2017-01-10  383  	if (ret >= 0) {
39d3e758 Parav Pandit    2017-01-10  384  		if (*intval < 0)
39d3e758 Parav Pandit    2017-01-10 @385  			break;
39d3e758 Parav Pandit    2017-01-10  386  		return i;
39d3e758 Parav Pandit    2017-01-10  387  	}
39d3e758 Parav Pandit    2017-01-10  388  	if (strncmp(value, RDMACG_MAX_STR, len) == 0) {
39d3e758 Parav Pandit    2017-01-10  389  		*intval = S32_MAX;
39d3e758 Parav Pandit    2017-01-10  390  		return i;
39d3e758 Parav Pandit    2017-01-10  391  	}
39d3e758 Parav Pandit    2017-01-10  392  	return -EINVAL;
39d3e758 Parav Pandit    2017-01-10  393  }
39d3e758 Parav Pandit    2017-01-10  394  

:::::: The code at line 385 was first introduced by commit
:::::: 39d3e7584a686541a3295ff1624d341e669e1afc rdmacg: Added rdma cgroup controller

:::::: TO: Parav Pandit <pandit.parav@gmail.com>
:::::: CC: Tejun Heo <tj@kernel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26040 bytes --]

      reply	other threads:[~2018-05-03 22:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 17:49 [PATCH v1] rdmacg: Convert to use match_string() helper Andy Shevchenko
2018-05-03 22:56 ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201805040627.kz10kn1Y%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pandit.parav@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.