From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEX4g-0003yH-0z for qemu-devel@nongnu.org; Fri, 04 May 2018 05:32:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEX4e-0002q5-TU for qemu-devel@nongnu.org; Fri, 04 May 2018 05:32:22 -0400 Date: Fri, 4 May 2018 10:32:12 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180504093212.GF29999@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <1525376963-79623-1-git-send-email-mst@redhat.com> <1525376963-79623-2-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1525376963-79623-2-git-send-email-mst@redhat.com> Subject: Re: [Qemu-devel] [PATCH 01/67] block: use local path for local headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, eblake@redhat.com, kwolf@redhat.com, peter.maydell@linaro.org, Max Reitz , Paolo Bonzini , Jeff Cody , qemu-block@nongnu.org On Thu, May 03, 2018 at 10:50:20PM +0300, Michael S. Tsirkin wrote: > When pulling in headers that are in the same directory as C file (as > opposed to one in include/), we should use its relative path, without a > directory. Directory based path works more or less by accident. This commit message is wrong. Directory paths work by design, since we explicitly add -I$SRCDIR to the include path. If we want to drop -I$SRCDIR, lets be clear about that being the reason, rather than pretending this is an accident. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|