All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] lib: Remove retry message from TST_RETRY_FUNC
Date: Fri,  4 May 2018 14:53:49 +0200	[thread overview]
Message-ID: <20180504125349.22734-1-rpalethorpe@suse.com> (raw)

This message creates a lot of noise and uses extra resources on slower
machines. It also does not seem very useful.

Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
---

This may help debug test failures on ARM machines by reducing the amount of
noise.

 include/tst_common.h | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/include/tst_common.h b/include/tst_common.h
index d3d50eb19..27924766e 100644
--- a/include/tst_common.h
+++ b/include/tst_common.h
@@ -56,13 +56,10 @@
 		if (tst_ret_ == ERET)					\
 			break;						\
 		if (tst_delay_ < MAX_DELAY * 1000000) {			\
-			tst_res(TINFO,					\
-				#FUNC" returned %i, retrying"		\
-				" in %ius", tst_ret_, tst_delay_);	\
 			usleep(tst_delay_);				\
 			tst_delay_ *= 2;				\
 		} else {						\
-			tst_brk(TBROK, #FUNC" failed");			\
+			tst_brk(TBROK, #FUNC" timed out");		\
 		}							\
 	}								\
 	ERET;								\
-- 
2.16.3


             reply	other threads:[~2018-05-04 12:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 12:53 Richard Palethorpe [this message]
2018-05-08  3:31 ` [LTP] [PATCH] lib: Remove retry message from TST_RETRY_FUNC Li Wang
2018-05-09 12:33 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180504125349.22734-1-rpalethorpe@suse.com \
    --to=rpalethorpe@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.