From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751525AbeEDQoJ (ORCPT ); Fri, 4 May 2018 12:44:09 -0400 Received: from foss.arm.com ([217.140.101.70]:56646 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751459AbeEDQoI (ORCPT ); Fri, 4 May 2018 12:44:08 -0400 Date: Fri, 4 May 2018 17:44:01 +0100 From: Lorenzo Pieralisi To: Vladimir Zapolskiy Cc: Jan Kiszka , Bjorn Helgaas , Linux Kernel Mailing List , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jingoo Han , Joao Pinto Subject: Re: [PATCH v2 07/10] PCI: Convert of_pci_get_host_bridge_resources() users to devm variant Message-ID: <20180504164401.GA17043@e107981-ln.cambridge.arm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 03, 2018 at 10:18:24AM +0300, Vladimir Zapolskiy wrote: > Hi Jan, > > On 04/30/2018 08:48 AM, Jan Kiszka wrote: > > From: Jan Kiszka > > > > Straightforward for all of them, no more leaks afterwards. > > > > CC: Jingoo Han > > CC: Joao Pinto > > CC: Lorenzo Pieralisi > > Signed-off-by: Jan Kiszka > > Acked-by: Jingoo Han > > [snip] > > > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c > > index 6ab28f29ac6a..6eb36c924983 100644 > > --- a/drivers/pci/host/pcie-rcar.c > > +++ b/drivers/pci/host/pcie-rcar.c > > @@ -1067,12 +1067,11 @@ static int rcar_pcie_parse_request_of_pci_ranges(struct rcar_pcie *pci) > > { > > int err; > > struct device *dev = pci->dev; > > - struct device_node *np = dev->of_node; > > resource_size_t iobase; > > struct resource_entry *win, *tmp; > > > > - err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pci->resources, > > - &iobase); > > + err = devm_of_pci_get_host_bridge_resources(dev, 0, 0xff, > > + &pci->resources, &iobase); > > if (err) > > return err; > > > > this one snippet is obsoleted by https://patchwork.ozlabs.org/patch/904326/ > > If 08/10 remains a deprecation, then it is sufficient to exclude the R-Car change, > otherwise I hope maintainers can deal with the proper ordering. Isn't applying your patch: https://patchwork.ozlabs.org/patch/904326/ and dropping the rcar hunk from this patch enough ? Lorenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Fri, 4 May 2018 17:44:01 +0100 From: Lorenzo Pieralisi To: Vladimir Zapolskiy Subject: Re: [PATCH v2 07/10] PCI: Convert of_pci_get_host_bridge_resources() users to devm variant Message-ID: <20180504164401.GA17043@e107981-ln.cambridge.arm.com> References: MIME-Version: 1.0 In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joao Pinto , Jan Kiszka , linux-pci@vger.kernel.org, Linux Kernel Mailing List , Jingoo Han , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Thu, May 03, 2018 at 10:18:24AM +0300, Vladimir Zapolskiy wrote: > Hi Jan, > > On 04/30/2018 08:48 AM, Jan Kiszka wrote: > > From: Jan Kiszka > > > > Straightforward for all of them, no more leaks afterwards. > > > > CC: Jingoo Han > > CC: Joao Pinto > > CC: Lorenzo Pieralisi > > Signed-off-by: Jan Kiszka > > Acked-by: Jingoo Han > > [snip] > > > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c > > index 6ab28f29ac6a..6eb36c924983 100644 > > --- a/drivers/pci/host/pcie-rcar.c > > +++ b/drivers/pci/host/pcie-rcar.c > > @@ -1067,12 +1067,11 @@ static int rcar_pcie_parse_request_of_pci_ranges(struct rcar_pcie *pci) > > { > > int err; > > struct device *dev = pci->dev; > > - struct device_node *np = dev->of_node; > > resource_size_t iobase; > > struct resource_entry *win, *tmp; > > > > - err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pci->resources, > > - &iobase); > > + err = devm_of_pci_get_host_bridge_resources(dev, 0, 0xff, > > + &pci->resources, &iobase); > > if (err) > > return err; > > > > this one snippet is obsoleted by https://patchwork.ozlabs.org/patch/904326/ > > If 08/10 remains a deprecation, then it is sufficient to exclude the R-Car change, > otherwise I hope maintainers can deal with the proper ordering. Isn't applying your patch: https://patchwork.ozlabs.org/patch/904326/ and dropping the rcar hunk from this patch enough ? Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi) Date: Fri, 4 May 2018 17:44:01 +0100 Subject: [PATCH v2 07/10] PCI: Convert of_pci_get_host_bridge_resources() users to devm variant In-Reply-To: References: Message-ID: <20180504164401.GA17043@e107981-ln.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 03, 2018 at 10:18:24AM +0300, Vladimir Zapolskiy wrote: > Hi Jan, > > On 04/30/2018 08:48 AM, Jan Kiszka wrote: > > From: Jan Kiszka > > > > Straightforward for all of them, no more leaks afterwards. > > > > CC: Jingoo Han > > CC: Joao Pinto > > CC: Lorenzo Pieralisi > > Signed-off-by: Jan Kiszka > > Acked-by: Jingoo Han > > [snip] > > > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c > > index 6ab28f29ac6a..6eb36c924983 100644 > > --- a/drivers/pci/host/pcie-rcar.c > > +++ b/drivers/pci/host/pcie-rcar.c > > @@ -1067,12 +1067,11 @@ static int rcar_pcie_parse_request_of_pci_ranges(struct rcar_pcie *pci) > > { > > int err; > > struct device *dev = pci->dev; > > - struct device_node *np = dev->of_node; > > resource_size_t iobase; > > struct resource_entry *win, *tmp; > > > > - err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pci->resources, > > - &iobase); > > + err = devm_of_pci_get_host_bridge_resources(dev, 0, 0xff, > > + &pci->resources, &iobase); > > if (err) > > return err; > > > > this one snippet is obsoleted by https://patchwork.ozlabs.org/patch/904326/ > > If 08/10 remains a deprecation, then it is sufficient to exclude the R-Car change, > otherwise I hope maintainers can deal with the proper ordering. Isn't applying your patch: https://patchwork.ozlabs.org/patch/904326/ and dropping the rcar hunk from this patch enough ? Lorenzo