All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dma-buf: Remove unneeded stubs around sync_debug interfaces
@ 2018-05-04 18:00 ` Ezequiel Garcia
  0 siblings, 0 replies; 4+ messages in thread
From: Ezequiel Garcia @ 2018-05-04 18:00 UTC (permalink / raw)
  To: Sumit Semwal, Gustavo Padovan
  Cc: linux-media, dri-devel, kernel, Ezequiel Garcia

The sync_debug.h header is internal, and only used by
sw_sync.c. Therefore, SW_SYNC is always defined and there
is no need for the stubs. Remove them and make the code
simpler.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 drivers/dma-buf/sync_debug.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/dma-buf/sync_debug.h b/drivers/dma-buf/sync_debug.h
index d615a89f774c..05e33f937ad0 100644
--- a/drivers/dma-buf/sync_debug.h
+++ b/drivers/dma-buf/sync_debug.h
@@ -62,8 +62,6 @@ struct sync_pt {
 	struct rb_node node;
 };
 
-#ifdef CONFIG_SW_SYNC
-
 extern const struct file_operations sw_sync_debugfs_fops;
 
 void sync_timeline_debug_add(struct sync_timeline *obj);
@@ -72,12 +70,4 @@ void sync_file_debug_add(struct sync_file *fence);
 void sync_file_debug_remove(struct sync_file *fence);
 void sync_dump(void);
 
-#else
-# define sync_timeline_debug_add(obj)
-# define sync_timeline_debug_remove(obj)
-# define sync_file_debug_add(fence)
-# define sync_file_debug_remove(fence)
-# define sync_dump()
-#endif
-
 #endif /* _LINUX_SYNC_H */
-- 
2.16.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] dma-buf: Remove unneeded stubs around sync_debug interfaces
@ 2018-05-04 18:00 ` Ezequiel Garcia
  0 siblings, 0 replies; 4+ messages in thread
From: Ezequiel Garcia @ 2018-05-04 18:00 UTC (permalink / raw)
  To: Sumit Semwal, Gustavo Padovan
  Cc: kernel, Ezequiel Garcia, dri-devel, linux-media

The sync_debug.h header is internal, and only used by
sw_sync.c. Therefore, SW_SYNC is always defined and there
is no need for the stubs. Remove them and make the code
simpler.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 drivers/dma-buf/sync_debug.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/dma-buf/sync_debug.h b/drivers/dma-buf/sync_debug.h
index d615a89f774c..05e33f937ad0 100644
--- a/drivers/dma-buf/sync_debug.h
+++ b/drivers/dma-buf/sync_debug.h
@@ -62,8 +62,6 @@ struct sync_pt {
 	struct rb_node node;
 };
 
-#ifdef CONFIG_SW_SYNC
-
 extern const struct file_operations sw_sync_debugfs_fops;
 
 void sync_timeline_debug_add(struct sync_timeline *obj);
@@ -72,12 +70,4 @@ void sync_file_debug_add(struct sync_file *fence);
 void sync_file_debug_remove(struct sync_file *fence);
 void sync_dump(void);
 
-#else
-# define sync_timeline_debug_add(obj)
-# define sync_timeline_debug_remove(obj)
-# define sync_file_debug_add(fence)
-# define sync_file_debug_remove(fence)
-# define sync_dump()
-#endif
-
 #endif /* _LINUX_SYNC_H */
-- 
2.16.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] dma-buf: Remove unneeded stubs around sync_debug interfaces
  2018-05-04 18:00 ` Ezequiel Garcia
@ 2018-05-07 13:58   ` Daniel Vetter
  -1 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-05-07 13:58 UTC (permalink / raw)
  To: Ezequiel Garcia
  Cc: Sumit Semwal, Gustavo Padovan, kernel, dri-devel, linux-media

On Fri, May 04, 2018 at 03:00:37PM -0300, Ezequiel Garcia wrote:
> The sync_debug.h header is internal, and only used by
> sw_sync.c. Therefore, SW_SYNC is always defined and there
> is no need for the stubs. Remove them and make the code
> simpler.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>

Applied, thanks.
-Daniel
> ---
>  drivers/dma-buf/sync_debug.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/dma-buf/sync_debug.h b/drivers/dma-buf/sync_debug.h
> index d615a89f774c..05e33f937ad0 100644
> --- a/drivers/dma-buf/sync_debug.h
> +++ b/drivers/dma-buf/sync_debug.h
> @@ -62,8 +62,6 @@ struct sync_pt {
>  	struct rb_node node;
>  };
>  
> -#ifdef CONFIG_SW_SYNC
> -
>  extern const struct file_operations sw_sync_debugfs_fops;
>  
>  void sync_timeline_debug_add(struct sync_timeline *obj);
> @@ -72,12 +70,4 @@ void sync_file_debug_add(struct sync_file *fence);
>  void sync_file_debug_remove(struct sync_file *fence);
>  void sync_dump(void);
>  
> -#else
> -# define sync_timeline_debug_add(obj)
> -# define sync_timeline_debug_remove(obj)
> -# define sync_file_debug_add(fence)
> -# define sync_file_debug_remove(fence)
> -# define sync_dump()
> -#endif
> -
>  #endif /* _LINUX_SYNC_H */
> -- 
> 2.16.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] dma-buf: Remove unneeded stubs around sync_debug interfaces
@ 2018-05-07 13:58   ` Daniel Vetter
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-05-07 13:58 UTC (permalink / raw)
  To: Ezequiel Garcia; +Cc: kernel, dri-devel, linux-media

On Fri, May 04, 2018 at 03:00:37PM -0300, Ezequiel Garcia wrote:
> The sync_debug.h header is internal, and only used by
> sw_sync.c. Therefore, SW_SYNC is always defined and there
> is no need for the stubs. Remove them and make the code
> simpler.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>

Applied, thanks.
-Daniel
> ---
>  drivers/dma-buf/sync_debug.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/dma-buf/sync_debug.h b/drivers/dma-buf/sync_debug.h
> index d615a89f774c..05e33f937ad0 100644
> --- a/drivers/dma-buf/sync_debug.h
> +++ b/drivers/dma-buf/sync_debug.h
> @@ -62,8 +62,6 @@ struct sync_pt {
>  	struct rb_node node;
>  };
>  
> -#ifdef CONFIG_SW_SYNC
> -
>  extern const struct file_operations sw_sync_debugfs_fops;
>  
>  void sync_timeline_debug_add(struct sync_timeline *obj);
> @@ -72,12 +70,4 @@ void sync_file_debug_add(struct sync_file *fence);
>  void sync_file_debug_remove(struct sync_file *fence);
>  void sync_dump(void);
>  
> -#else
> -# define sync_timeline_debug_add(obj)
> -# define sync_timeline_debug_remove(obj)
> -# define sync_file_debug_add(fence)
> -# define sync_file_debug_remove(fence)
> -# define sync_dump()
> -#endif
> -
>  #endif /* _LINUX_SYNC_H */
> -- 
> 2.16.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-07 13:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-04 18:00 [PATCH] dma-buf: Remove unneeded stubs around sync_debug interfaces Ezequiel Garcia
2018-05-04 18:00 ` Ezequiel Garcia
2018-05-07 13:58 ` Daniel Vetter
2018-05-07 13:58   ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.