From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Eliminate the unused dev_priv->vbt.lvds_vbt
Date: Fri, 4 May 2018 13:14:23 -0700 [thread overview]
Message-ID: <20180504201423.GL17530@intel.com> (raw)
In-Reply-To: <20180504141349.5878-2-ville.syrjala@linux.intel.com>
On Fri, May 04, 2018 at 05:13:49PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> dev_priv->vbt.lvds_vbt is set but never actually used. Kill it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 1 -
> drivers/gpu/drm/i915/intel_bios.c | 3 ---
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index ffd0c8d33336..8302bd22ddcc 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1049,7 +1049,6 @@ struct intel_vbt_data {
> /* Feature bits */
> unsigned int int_tv_support:1;
> unsigned int lvds_dither:1;
> - unsigned int lvds_vbt:1;
> unsigned int int_crt_support:1;
> unsigned int lvds_use_ssc:1;
> unsigned int int_lvds_support:1;
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index f75541b11f11..db429eea2e99 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -267,8 +267,6 @@ parse_lfp_panel_data(struct drm_i915_private *dev_priv,
> if (!lvds_lfp_data_ptrs)
> return;
>
> - dev_priv->vbt.lvds_vbt = 1;
> -
> panel_dvo_timing = get_lvds_dvo_timing(lvds_lfp_data,
> lvds_lfp_data_ptrs,
> panel_type);
> @@ -1516,7 +1514,6 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
>
> /* LFP panel data */
> dev_priv->vbt.lvds_dither = 1;
> - dev_priv->vbt.lvds_vbt = 0;
>
> /* SDVO panel data */
> dev_priv->vbt.sdvo_lvds_vbt_mode = NULL;
> --
> 2.16.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-04 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 14:13 [PATCH 1/2] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present Ville Syrjala
2018-05-04 14:13 ` [PATCH 2/2] drm/i915: Eliminate the unused dev_priv->vbt.lvds_vbt Ville Syrjala
2018-05-04 20:14 ` Rodrigo Vivi [this message]
2018-05-04 14:33 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present Patchwork
2018-05-04 14:34 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-05-04 14:49 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-04 16:22 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-08 9:33 ` [PATCH 1/2] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504201423.GL17530@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.