From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v1 1/1] test: fix build with GCC 4.8.5
Date: Sat, 5 May 2018 08:47:31 +0530
Message-ID: <20180505031729.GA32315@jerin>
References: <1525469883-8342-1-git-send-email-erik.g.carrillo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0085.outbound.protection.outlook.com [104.47.36.85])
 by dpdk.org (Postfix) with ESMTP id B7E3223C
 for <dev@dpdk.org>; Sat,  5 May 2018 05:17:50 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1525469883-8342-1-git-send-email-erik.g.carrillo@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 4 May 2018 16:38:03 -0500
> From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org
> Subject: [PATCH v1 1/1] test: fix build with GCC 4.8.5
> X-Mailer: git-send-email 1.7.10
> 
> Build errors occur on CentOS 7 with GCC 4.8.5 20150623 in the
> event_timer_adapter_test autotest; the
> -Werror=missing-field-initializers option causes the compiler to emit
> messages like "error: missing initializer for field ‘priority’ of
> ‘struct <anonymous>’" in several places.
> 
> Add -Wno-missing-field-initializers to the test's CFLAGS to allow the
> current syntax if we are using GCC 5.0 or lower.
> 

Missing the 'Fixes' tag:

With above change:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
>  test/test/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/test/Makefile b/test/test/Makefile
> index 2630ab4..2011857 100644
> --- a/test/test/Makefile
> +++ b/test/test/Makefile
> @@ -211,6 +211,7 @@ CFLAGS_test_memcpy_perf.o += -fno-var-tracking-assignments
>  # designated initializers.
>  ifeq ($(shell test $(GCC_VERSION) -le 50 && echo 1), 1)
>  CFLAGS_test_eventdev_sw.o += -Wno-missing-field-initializers
> +CFLAGS_test_event_timer_adapter.o += -Wno-missing-field-initializers
>  endif
>  endif
>  endif
> -- 
> 2.6.4
>