Hi Nicholas, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v4.17-rc3 next-20180504] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-64-irq_work-avoid-interrupt-when-called-with-hardware-irqs-enabled/20180505-193051 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-kilauea_defconfig (attached as .config) compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=powerpc Note: the linux-review/Nicholas-Piggin/powerpc-64-irq_work-avoid-interrupt-when-called-with-hardware-irqs-enabled/20180505-193051 HEAD 6f7d1654cc9b2355ec6983991f1f293089e9c762 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): arch/powerpc/kernel/time.c: In function 'timer_broadcast_interrupt': >> arch/powerpc/kernel/time.c:646:2: error: implicit declaration of function 'tick_receive_broadcast'; did you mean 'tick_setup_hrtimer_broadcast'? [-Werror=implicit-function-declaration] tick_receive_broadcast(); ^~~~~~~~~~~~~~~~~~~~~~ tick_setup_hrtimer_broadcast cc1: all warnings being treated as errors vim +646 arch/powerpc/kernel/time.c 638 639 void timer_broadcast_interrupt(void) 640 { 641 u64 *next_tb = this_cpu_ptr(&decrementers_next_tb); 642 struct pt_regs *regs = get_irq_regs(); 643 644 trace_timer_interrupt_entry(regs); 645 *next_tb = ~(u64)0; > 646 tick_receive_broadcast(); 647 __this_cpu_inc(irq_stat.timer_irqs_event); 648 trace_timer_interrupt_exit(regs); 649 } 650 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation