All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/3] lib/tst_net.sh: Append 6 to the end of $TST_OPTS
Date: Mon, 7 May 2018 08:43:43 +0200	[thread overview]
Message-ID: <20180507064343.ahqhsbadjpho2xry@dell5510> (raw)
In-Reply-To: <1525663451-32016-1-git-send-email-yangx.jy@cn.fujitsu.com>

Hi,

> If the first character of optstring is set to a colon(tcp_fastopen_run.sh,
> nfs_lib.sh), getopts should be in silent mode rather than process it as
> an argument of 6.

> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
>  testcases/lib/tst_net.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/testcases/lib/tst_net.sh b/testcases/lib/tst_net.sh
> index 3a0fe01..32b4f09 100644
> --- a/testcases/lib/tst_net.sh
> +++ b/testcases/lib/tst_net.sh
> @@ -19,7 +19,7 @@
>  # Author: Alexey Kodanev <alexey.kodanev@oracle.com>


> -TST_OPTS="6$TST_OPTS"
> +TST_OPTS="${TST_OPTS}6"
>  TST_PARSE_ARGS_CALLER="$TST_PARSE_ARGS"
>  TST_PARSE_ARGS="tst_net_parse_args"
>  TST_USAGE_CALLER="$TST_USAGE"

Acked-by: Petr Vorel <pvorel@suse.cz>

Good catch. Although I propose to get rid of ':' at the beginning for users of new shell
API (as it's IMHO better to see errors).


Kind regards,
Petr

  parent reply	other threads:[~2018-05-07  6:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07  3:24 [LTP] [PATCH 1/3] lib/tst_net.sh: Append 6 to the end of $TST_OPTS Xiao Yang
2018-05-07  3:24 ` [LTP] [PATCH 2/3] net/tcp_fastopen_run.sh: Cleanup in TST_PARSE_ARGS functions for legacy API Xiao Yang
2018-05-07  6:44   ` Petr Vorel
2018-05-07  7:18     ` Xiao Yang
2018-05-23  7:48   ` Petr Vorel
2018-05-07  3:24 ` [LTP] [PATCH 3/3] net/nfs_lib.sh: Cleanup " Xiao Yang
2018-05-07  7:18   ` Petr Vorel
2018-05-07 19:35   ` Petr Vorel
2018-05-23  8:12   ` Petr Vorel
2018-05-07  6:43 ` Petr Vorel [this message]
2018-05-07  7:30   ` [LTP] [PATCH 1/3] lib/tst_net.sh: Append 6 to the end of $TST_OPTS Xiao Yang
2018-05-07  8:09     ` Petr Vorel
2018-05-07 10:31       ` Alexey Kodanev
2018-05-07 10:53         ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180507064343.ahqhsbadjpho2xry@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.