* [Buildroot] [PATCH] support/download/file: fix file:// protocol handling
@ 2018-05-07 8:50 Angelo Compagnucci
2018-05-07 11:24 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Angelo Compagnucci @ 2018-05-07 8:50 UTC (permalink / raw)
To: buildroot
This patch removes the file:// prefix from file url before passing it
to the cp command. It fixes also a missing / between url directory
and file part.
Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
support/download/file | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/support/download/file b/support/download/file
index fefd6d2..6dd37b0 100755
--- a/support/download/file
+++ b/support/download/file
@@ -40,4 +40,4 @@ _localfiles() {
eval ${LOCALFILES} "${@}"
}
-_localfiles ${verbose} "'${dir}${file}'" "'${output}'"
+_localfiles ${verbose} "'${dir##file://}/${file}'" "'${output}'"
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] support/download/file: fix file:// protocol handling
2018-05-07 8:50 [Buildroot] [PATCH] support/download/file: fix file:// protocol handling Angelo Compagnucci
@ 2018-05-07 11:24 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-05-07 11:24 UTC (permalink / raw)
To: buildroot
Hello Angelo,
On Mon, 7 May 2018 10:50:42 +0200, Angelo Compagnucci wrote:
> This patch removes the file:// prefix from file url before passing it
> to the cp command. It fixes also a missing / between url directory
> and file part.
>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
I think it would be good to add a specific example that was failing for
you: an example defconfig, and the relevant part of the build log. This
will help in the future if we wonder why this change was done.
Indeed, your commit log describes *what* is done (which is easily
guessed by looking at the code itself), but not *why* it is done.
I think it is especially important to explain that it is a regression
(and since when).
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-07 11:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07 8:50 [Buildroot] [PATCH] support/download/file: fix file:// protocol handling Angelo Compagnucci
2018-05-07 11:24 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.