From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer Date: Mon, 7 May 2018 15:53:41 +0200 Message-ID: <20180507135341.GI12521@phenom.ffwll.local> References: <20180504135212.26977-1-peda@axentia.se> <20180504135212.26977-27-peda@axentia.se> <4cdcd215-8caf-e045-a478-f438f128c9f2@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <4cdcd215-8caf-e045-a478-f438f128c9f2-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Andrzej Hajda Cc: Martyn Welch , David Airlie , Gustavo Padovan , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Sandy Huang , Laurent Pinchart , Benjamin Gaignard , Heiko =?iso-8859-1?Q?St=FCbner?= , Archit Taneja , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joonyoung Shim , Kyungmin Park , Krzysztof Kozlowski , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Kukjin Kim , Peter Senna Tschudin , CK Hu , Martin Donnelly , Daniel Vetter , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Maarten Lankhorst , Jyri Sarha , Inki List-Id: linux-arm-msm@vger.kernel.org T24gTW9uLCBNYXkgMDcsIDIwMTggYXQgMDI6NTk6NDVQTSArMDIwMCwgQW5kcnplaiBIYWpkYSB3 cm90ZToKPiBPbiAwNC4wNS4yMDE4IDE1OjUyLCBQZXRlciBSb3NpbiB3cm90ZToKPiA+IElmIHRo ZSBicmlkZ2Ugc3VwcGxpZXIgaXMgdW5ib3VuZCwgdGhpcyB3aWxsIGJyaW5nIHRoZSBicmlkZ2Ug Y29uc3VtZXIKPiA+IGRvd24gYWxvbmcgd2l0aCB0aGUgYnJpZGdlLiBUaHVzLCB0aGVyZSB3aWxs IG5vIGxvbmdlciBsaW5nZXIgYW55Cj4gPiBkYW5nbGluZyBwb2ludGVycyBmcm9tIHRoZSBicmlk Z2UgY29uc3VtZXIgKHRoZSBkcm1fZGV2aWNlKSB0byBzb21lCj4gPiBub24tZXhpc3RlbnQgYnJp ZGdlIHN1cHBsaWVyLgo+IAo+IEkgdW5kZXJzdGFuZCByYXRpb25hbGVzIGJlaGluZCB0aGlzIHBh dGNoLCBidXQgaXQgaXMgYW5vdGhlciBzdGVwIGludG8KPiBtYWtpbmcgZHJtX2RldiBvbmUgYmln IGRyaXZlciB3aXRoIHN1YmNvbXBvbmVudHMsIHdoZXJlIGRybSB3aWxsIHdvcmsKPiBvbmx5IGlm IGV2ZXJ5IHN1YmNvbXBvbmVudCBpcyB3b3JraW5nL2xvYWRlZC4gRG8gd2UgbmVlZCB0byBnbyB0 aGlzIHdheT8KPiBJbiBjYXNlIG9mIG1hbnkgcGxhdGZvcm1zIHN1Y2ggYXBwcm9hY2ggcmVzdWx0 cyBpbiBkaXNwbGF5IHR1cm5lZCBvbgo+IHZlcnkgbGF0ZSBvbiBib290IGZvciBleGFtcGxlIGR1 ZSB0byBsYXRlIGluaXRpYWxpemF0aW9uIG9mIHNvbWUKPiByZWd1bGF0b3IgZXhwb3NlZCBieSBz b21lIGkyYyBkZXZpY2UsIHdoaWNoIGlzIHVzZWQgYnkgaGRtaSBicmlkZ2UuIEFuZAo+IHRoaXMg aGRtaSBicmlkZ2UgaXMganVzdCB0byBwcm92aWRlIGFsdGVybmF0aXZlKHJhcmVseSB1c2VkKSBk aXNwbGF5Cj4gcGF0aCwgdGhlIG1haW4gZGlzcGxheSBwYXRoIHdvdWxkIHdvcmsgYW55d2F5Lgo+ IAo+IFNvIHRoZSBtYWluIHF1ZXN0aW9uIHRvIGRybSBtYWludGFpbmVycyBpcyBhYm91dCBldm9s dXRpb24gb2YgYnJpZGdlcywKPiBpZiBkcm1fYnJpZGdlcyBzaG91bGQgYmVjb21lIG1hbmRhdG9y eSBjb21wb25lbnRzIG9mIGRybSBkZXZpY2Ugb3IgdGhleQo+IGNvdWxkIGJlIGFkZGVkL3JlbW92 ZWQgZHluYW1pY2FsbHk/CgpUaGlzIGlzIGFscmVhZHkgdGhlIGNhc2UuIFlvdSBjdXJyZW50bHkg Y2Fubm90IGhvdHBsdWcgYSBkcm1fYnJpZGdlLApldmVyeXRoaW5nIG11c3QgYmUgcHJlc2VudC4g SSBkb24ndCB0aGluayBpdCBtYWtlcyBzZW5zZSB0byBjaGFuZ2UgdGhhdAp1bnRpbCB3ZSBoYXZl IHBoeXNpY2FsbHkgaG90cGx1Z2dhYmxlIGRybV9icmlkZ2VzIGluIHJlYWwgaGFyZHdhcmUuIEkK ZGVmaW5pdGVseSBkb24ndCB3YW50IHRvIHJlZmNvdW50IHN0dWZmIHRvIHdvcmsgYXJvdW5kIGRy aXZlciBsb2FkCmJvbmdoaXRzIG9uIERUIHBsYXRmb3JtcywgYmVjYXVzZSByZWZjb3VudGluZyBp cyB3YXkgdG9vIGhhcmQgdG8gZ2V0IHJpZ2h0CjotKQoKQWZhaWsgdGhlcmUncyBvdXQtb2YtdHJl ZSBwYXRjaGVzIHRvIHNvbHZlIDk5JSBvZiB0aGUgZHJpdmVyIGxvYWQgZnVuIG9uCkRUIHBsYXRm b3JtcywgYnV0IGJlY2F1c2UgaXQncyBub3QgYSAxMDAlIHNvbHV0aW9uIGl0J3MgYmxvY2tlZCBz aW5jZQpmb3JldmVyLgotRGFuaWVsCgo+IAo+IFJlZ2FyZHMKPiBBbmRyemVqCj4gCj4gCj4gPgo+ ID4gU2lnbmVkLW9mZi1ieTogUGV0ZXIgUm9zaW4gPHBlZGFAYXhlbnRpYS5zZT4KPiA+IC0tLQo+ ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYnJpZGdlLmMgfCAxOCArKysrKysrKysrKysrKysrKysK PiA+ICBpbmNsdWRlL2RybS9kcm1fYnJpZGdlLmggICAgIHwgIDIgKysKPiA+ICAyIGZpbGVzIGNo YW5nZWQsIDIwIGluc2VydGlvbnMoKykKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2RybV9icmlkZ2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYnJpZGdlLmMKPiA+IGluZGV4 IDc4ZDE4NmI2ODMxYi4uMDI1OWYwYTNmZjI3IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2RybV9icmlkZ2UuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9icmlkZ2UuYwo+ ID4gQEAgLTI2LDYgKzI2LDcgQEAKPiA+ICAjaW5jbHVkZSA8bGludXgvbXV0ZXguaD4KPiA+ICAK PiA+ICAjaW5jbHVkZSA8ZHJtL2RybV9icmlkZ2UuaD4KPiA+ICsjaW5jbHVkZSA8ZHJtL2RybV9k ZXZpY2UuaD4KPiA+ICAjaW5jbHVkZSA8ZHJtL2RybV9lbmNvZGVyLmg+Cj4gPiAgCj4gPiAgI2lu Y2x1ZGUgImRybV9jcnRjX2ludGVybmFsLmgiCj4gPiBAQCAtMTI3LDEyICsxMjgsMjUgQEAgaW50 IGRybV9icmlkZ2VfYXR0YWNoKHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2Rlciwgc3RydWN0IGRy bV9icmlkZ2UgKmJyaWRnZSwKPiA+ICAJaWYgKGJyaWRnZS0+ZGV2KQo+ID4gIAkJcmV0dXJuIC1F QlVTWTsKPiA+ICAKPiA+ICsJaWYgKGVuY29kZXItPmRldi0+ZGV2ICE9IGJyaWRnZS0+b2Rldikg ewo+ID4gKwkJYnJpZGdlLT5saW5rID0gZGV2aWNlX2xpbmtfYWRkKGVuY29kZXItPmRldi0+ZGV2 LAo+ID4gKwkJCQkJICAgICAgIGJyaWRnZS0+b2RldiwgMCk7Cj4gPiArCQlpZiAoIWJyaWRnZS0+ bGluaykgewo+ID4gKwkJCWRldl9lcnIoYnJpZGdlLT5vZGV2LCAiZmFpbGVkIHRvIGxpbmsgYnJp ZGdlIHRvICVzXG4iLAo+ID4gKwkJCQlkZXZfbmFtZShlbmNvZGVyLT5kZXYtPmRldikpOwo+ID4g KwkJCXJldHVybiAtRUlOVkFMOwo+ID4gKwkJfQo+ID4gKwl9Cj4gPiArCj4gPiAgCWJyaWRnZS0+ ZGV2ID0gZW5jb2Rlci0+ZGV2Owo+ID4gIAlicmlkZ2UtPmVuY29kZXIgPSBlbmNvZGVyOwo+ID4g IAo+ID4gIAlpZiAoYnJpZGdlLT5mdW5jcy0+YXR0YWNoKSB7Cj4gPiAgCQlyZXQgPSBicmlkZ2Ut PmZ1bmNzLT5hdHRhY2goYnJpZGdlKTsKPiA+ICAJCWlmIChyZXQgPCAwKSB7Cj4gPiArCQkJaWYg KGJyaWRnZS0+bGluaykKPiA+ICsJCQkJZGV2aWNlX2xpbmtfZGVsKGJyaWRnZS0+bGluayk7Cj4g PiArCQkJYnJpZGdlLT5saW5rID0gTlVMTDsKPiA+ICAJCQlicmlkZ2UtPmRldiA9IE5VTEw7Cj4g PiAgCQkJYnJpZGdlLT5lbmNvZGVyID0gTlVMTDsKPiA+ICAJCQlyZXR1cm4gcmV0Owo+ID4gQEAg LTE1OSw2ICsxNzMsMTAgQEAgdm9pZCBkcm1fYnJpZGdlX2RldGFjaChzdHJ1Y3QgZHJtX2JyaWRn ZSAqYnJpZGdlKQo+ID4gIAlpZiAoYnJpZGdlLT5mdW5jcy0+ZGV0YWNoKQo+ID4gIAkJYnJpZGdl LT5mdW5jcy0+ZGV0YWNoKGJyaWRnZSk7Cj4gPiAgCj4gPiArCWlmIChicmlkZ2UtPmxpbmspCj4g PiArCQlkZXZpY2VfbGlua19kZWwoYnJpZGdlLT5saW5rKTsKPiA+ICsJYnJpZGdlLT5saW5rID0g TlVMTDsKPiA+ICsKPiA+ICAJYnJpZGdlLT5kZXYgPSBOVUxMOwo+ID4gIH0KPiA+ICAKPiA+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fYnJpZGdlLmggYi9pbmNsdWRlL2RybS9kcm1fYnJp ZGdlLmgKPiA+IGluZGV4IGI2NTZlNTA1ZDExZS4uODA0MTg5YzYzYTRjIDEwMDY0NAo+ID4gLS0t IGEvaW5jbHVkZS9kcm0vZHJtX2JyaWRnZS5oCj4gPiArKysgYi9pbmNsdWRlL2RybS9kcm1fYnJp ZGdlLmgKPiA+IEBAIC0yNjEsNiArMjYxLDcgQEAgc3RydWN0IGRybV9icmlkZ2VfdGltaW5ncyB7 Cj4gPiAgICogQGxpc3Q6IHRvIGtlZXAgdHJhY2sgb2YgYWxsIGFkZGVkIGJyaWRnZXMKPiA+ICAg KiBAdGltaW5nczogdGhlIHRpbWluZyBzcGVjaWZpY2F0aW9uIGZvciB0aGUgYnJpZGdlLCBpZiBh bnkgKG1heQo+ID4gICAqIGJlIE5VTEwpCj4gPiArICogQGxpbms6IGRybSBjb25zdW1lciA8LT4g YnJpZGdlIHN1cHBsaWVyCj4gPiAgICogQGZ1bmNzOiBjb250cm9sIGZ1bmN0aW9ucwo+ID4gICAq IEBkcml2ZXJfcHJpdmF0ZTogcG9pbnRlciB0byB0aGUgYnJpZGdlIGRyaXZlcidzIGludGVybmFs IGNvbnRleHQKPiA+ICAgKi8KPiA+IEBAIC0yNzEsNiArMjcyLDcgQEAgc3RydWN0IGRybV9icmlk Z2Ugewo+ID4gIAlzdHJ1Y3QgZHJtX2JyaWRnZSAqbmV4dDsKPiA+ICAJc3RydWN0IGxpc3RfaGVh ZCBsaXN0Owo+ID4gIAljb25zdCBzdHJ1Y3QgZHJtX2JyaWRnZV90aW1pbmdzICp0aW1pbmdzOwo+ ID4gKwlzdHJ1Y3QgZGV2aWNlX2xpbmsgKmxpbms7Cj4gPiAgCj4gPiAgCWNvbnN0IHN0cnVjdCBk cm1fYnJpZGdlX2Z1bmNzICpmdW5jczsKPiA+ICAJdm9pZCAqZHJpdmVyX3ByaXZhdGU7Cj4gCj4g CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K aHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KRnJlZWRyZW5vIG1haWxpbmcgbGlzdApGcmVlZHJlbm9AbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZnJlZWRyZW5vCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752375AbeEGNxu (ORCPT ); Mon, 7 May 2018 09:53:50 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36044 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752098AbeEGNxp (ORCPT ); Mon, 7 May 2018 09:53:45 -0400 X-Google-Smtp-Source: AB8JxZqkMBJpMbFwiuy6zDzUUVFGpLp9UM4HiAE+aCjImauixGlhafxW9JKfatcV6UF2WexrCxc4Ow== Date: Mon, 7 May 2018 15:53:41 +0200 From: Daniel Vetter To: Andrzej Hajda Cc: Peter Rosin , linux-kernel@vger.kernel.org, Archit Taneja , Laurent Pinchart , David Airlie , Peter Senna Tschudin , Martin Donnelly , Martyn Welch , Gustavo Padovan , Maarten Lankhorst , Sean Paul , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , CK Hu , Philipp Zabel , Matthias Brugger , Rob Clark , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Benjamin Gaignard , Vincent Abriou , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Jyri Sarha , Daniel Vetter Subject: Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer Message-ID: <20180507135341.GI12521@phenom.ffwll.local> Mail-Followup-To: Andrzej Hajda , Peter Rosin , linux-kernel@vger.kernel.org, Archit Taneja , Laurent Pinchart , David Airlie , Peter Senna Tschudin , Martin Donnelly , Martyn Welch , Gustavo Padovan , Maarten Lankhorst , Sean Paul , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , CK Hu , Philipp Zabel , Matthias Brugger , Rob Clark , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Benjamin Gaignard , Vincent Abriou , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Jyri Sarha References: <20180504135212.26977-1-peda@axentia.se> <20180504135212.26977-27-peda@axentia.se> <4cdcd215-8caf-e045-a478-f438f128c9f2@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4cdcd215-8caf-e045-a478-f438f128c9f2@samsung.com> X-Operating-System: Linux phenom 4.15.0-3-amd64 User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 07, 2018 at 02:59:45PM +0200, Andrzej Hajda wrote: > On 04.05.2018 15:52, Peter Rosin wrote: > > If the bridge supplier is unbound, this will bring the bridge consumer > > down along with the bridge. Thus, there will no longer linger any > > dangling pointers from the bridge consumer (the drm_device) to some > > non-existent bridge supplier. > > I understand rationales behind this patch, but it is another step into > making drm_dev one big driver with subcomponents, where drm will work > only if every subcomponent is working/loaded. Do we need to go this way? > In case of many platforms such approach results in display turned on > very late on boot for example due to late initialization of some > regulator exposed by some i2c device, which is used by hdmi bridge. And > this hdmi bridge is just to provide alternative(rarely used) display > path, the main display path would work anyway. > > So the main question to drm maintainers is about evolution of bridges, > if drm_bridges should become mandatory components of drm device or they > could be added/removed dynamically? This is already the case. You currently cannot hotplug a drm_bridge, everything must be present. I don't think it makes sense to change that until we have physically hotpluggable drm_bridges in real hardware. I definitely don't want to refcount stuff to work around driver load bonghits on DT platforms, because refcounting is way too hard to get right :-) Afaik there's out-of-tree patches to solve 99% of the driver load fun on DT platforms, but because it's not a 100% solution it's blocked since forever. -Daniel > > Regards > Andrzej > > > > > > Signed-off-by: Peter Rosin > > --- > > drivers/gpu/drm/drm_bridge.c | 18 ++++++++++++++++++ > > include/drm/drm_bridge.h | 2 ++ > > 2 files changed, 20 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c > > index 78d186b6831b..0259f0a3ff27 100644 > > --- a/drivers/gpu/drm/drm_bridge.c > > +++ b/drivers/gpu/drm/drm_bridge.c > > @@ -26,6 +26,7 @@ > > #include > > > > #include > > +#include > > #include > > > > #include "drm_crtc_internal.h" > > @@ -127,12 +128,25 @@ int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge, > > if (bridge->dev) > > return -EBUSY; > > > > + if (encoder->dev->dev != bridge->odev) { > > + bridge->link = device_link_add(encoder->dev->dev, > > + bridge->odev, 0); > > + if (!bridge->link) { > > + dev_err(bridge->odev, "failed to link bridge to %s\n", > > + dev_name(encoder->dev->dev)); > > + return -EINVAL; > > + } > > + } > > + > > bridge->dev = encoder->dev; > > bridge->encoder = encoder; > > > > if (bridge->funcs->attach) { > > ret = bridge->funcs->attach(bridge); > > if (ret < 0) { > > + if (bridge->link) > > + device_link_del(bridge->link); > > + bridge->link = NULL; > > bridge->dev = NULL; > > bridge->encoder = NULL; > > return ret; > > @@ -159,6 +173,10 @@ void drm_bridge_detach(struct drm_bridge *bridge) > > if (bridge->funcs->detach) > > bridge->funcs->detach(bridge); > > > > + if (bridge->link) > > + device_link_del(bridge->link); > > + bridge->link = NULL; > > + > > bridge->dev = NULL; > > } > > > > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > > index b656e505d11e..804189c63a4c 100644 > > --- a/include/drm/drm_bridge.h > > +++ b/include/drm/drm_bridge.h > > @@ -261,6 +261,7 @@ struct drm_bridge_timings { > > * @list: to keep track of all added bridges > > * @timings: the timing specification for the bridge, if any (may > > * be NULL) > > + * @link: drm consumer <-> bridge supplier > > * @funcs: control functions > > * @driver_private: pointer to the bridge driver's internal context > > */ > > @@ -271,6 +272,7 @@ struct drm_bridge { > > struct drm_bridge *next; > > struct list_head list; > > const struct drm_bridge_timings *timings; > > + struct device_link *link; > > > > const struct drm_bridge_funcs *funcs; > > void *driver_private; > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Mon, 7 May 2018 15:53:41 +0200 Subject: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer In-Reply-To: <4cdcd215-8caf-e045-a478-f438f128c9f2@samsung.com> References: <20180504135212.26977-1-peda@axentia.se> <20180504135212.26977-27-peda@axentia.se> <4cdcd215-8caf-e045-a478-f438f128c9f2@samsung.com> Message-ID: <20180507135341.GI12521@phenom.ffwll.local> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, May 07, 2018 at 02:59:45PM +0200, Andrzej Hajda wrote: > On 04.05.2018 15:52, Peter Rosin wrote: > > If the bridge supplier is unbound, this will bring the bridge consumer > > down along with the bridge. Thus, there will no longer linger any > > dangling pointers from the bridge consumer (the drm_device) to some > > non-existent bridge supplier. > > I understand rationales behind this patch, but it is another step into > making drm_dev one big driver with subcomponents, where drm will work > only if every subcomponent is working/loaded. Do we need to go this way? > In case of many platforms such approach results in display turned on > very late on boot for example due to late initialization of some > regulator exposed by some i2c device, which is used by hdmi bridge. And > this hdmi bridge is just to provide alternative(rarely used) display > path, the main display path would work anyway. > > So the main question to drm maintainers is about evolution of bridges, > if drm_bridges should become mandatory components of drm device or they > could be added/removed dynamically? This is already the case. You currently cannot hotplug a drm_bridge, everything must be present. I don't think it makes sense to change that until we have physically hotpluggable drm_bridges in real hardware. I definitely don't want to refcount stuff to work around driver load bonghits on DT platforms, because refcounting is way too hard to get right :-) Afaik there's out-of-tree patches to solve 99% of the driver load fun on DT platforms, but because it's not a 100% solution it's blocked since forever. -Daniel > > Regards > Andrzej > > > > > > Signed-off-by: Peter Rosin > > --- > > drivers/gpu/drm/drm_bridge.c | 18 ++++++++++++++++++ > > include/drm/drm_bridge.h | 2 ++ > > 2 files changed, 20 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c > > index 78d186b6831b..0259f0a3ff27 100644 > > --- a/drivers/gpu/drm/drm_bridge.c > > +++ b/drivers/gpu/drm/drm_bridge.c > > @@ -26,6 +26,7 @@ > > #include > > > > #include > > +#include > > #include > > > > #include "drm_crtc_internal.h" > > @@ -127,12 +128,25 @@ int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge, > > if (bridge->dev) > > return -EBUSY; > > > > + if (encoder->dev->dev != bridge->odev) { > > + bridge->link = device_link_add(encoder->dev->dev, > > + bridge->odev, 0); > > + if (!bridge->link) { > > + dev_err(bridge->odev, "failed to link bridge to %s\n", > > + dev_name(encoder->dev->dev)); > > + return -EINVAL; > > + } > > + } > > + > > bridge->dev = encoder->dev; > > bridge->encoder = encoder; > > > > if (bridge->funcs->attach) { > > ret = bridge->funcs->attach(bridge); > > if (ret < 0) { > > + if (bridge->link) > > + device_link_del(bridge->link); > > + bridge->link = NULL; > > bridge->dev = NULL; > > bridge->encoder = NULL; > > return ret; > > @@ -159,6 +173,10 @@ void drm_bridge_detach(struct drm_bridge *bridge) > > if (bridge->funcs->detach) > > bridge->funcs->detach(bridge); > > > > + if (bridge->link) > > + device_link_del(bridge->link); > > + bridge->link = NULL; > > + > > bridge->dev = NULL; > > } > > > > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > > index b656e505d11e..804189c63a4c 100644 > > --- a/include/drm/drm_bridge.h > > +++ b/include/drm/drm_bridge.h > > @@ -261,6 +261,7 @@ struct drm_bridge_timings { > > * @list: to keep track of all added bridges > > * @timings: the timing specification for the bridge, if any (may > > * be NULL) > > + * @link: drm consumer <-> bridge supplier > > * @funcs: control functions > > * @driver_private: pointer to the bridge driver's internal context > > */ > > @@ -271,6 +272,7 @@ struct drm_bridge { > > struct drm_bridge *next; > > struct list_head list; > > const struct drm_bridge_timings *timings; > > + struct device_link *link; > > > > const struct drm_bridge_funcs *funcs; > > void *driver_private; > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch