From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Mon, 7 May 2018 16:52:46 +0200 Subject: [U-Boot] [PATCH v7 06/35] musb: sunxi: Add OTG device clkgate and reset for H3/H5 In-Reply-To: <17d101f8-fafe-0cb2-bcc4-33f13ceff7b1@denx.de> References: <20180507073351.30582-1-jagan@amarulasolutions.com> <20180507073351.30582-7-jagan@amarulasolutions.com> <17d101f8-fafe-0cb2-bcc4-33f13ceff7b1@denx.de> Message-ID: <20180507145246.y6zegcxnkywqg7l5@flea> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, May 07, 2018 at 01:47:43PM +0200, Marek Vasut wrote: > On 05/07/2018 09:33 AM, Jagan Teki wrote: > > Add OTG device clkgate and reset for H3/H5 through driver_data. > > > > Signed-off-by: Jagan Teki > > Why don't you implement a clock driver for this SoC instead ? Aren't you asking a bit too much? Since the first post of these patches, you've asked to rework in a significant manner the driver already, including doing a new PHY driver to use the device model, and making other substantial changes to it. Jagan complied to all your requests so far, but this one is going to create yet another ton of patches on top of an (already) 35 patches series. And this request comes out of nowhere at the 7th version. Creating a new clock driver will take a lot of effort, and this really surprise me given that we've had strictly no feedback from you on this considering all the previous SoCs bringups we've done so far. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: