From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values Date: Mon, 7 May 2018 10:53:14 -0500 Message-ID: <20180507155313.GA9696@rob-hp-laptop> References: <1525295174-15995-1-git-send-email-mgautam@codeaurora.org> <1525295174-15995-7-git-send-email-mgautam@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1525295174-15995-7-git-send-email-mgautam@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Manu Gautam Cc: Kishon Vijay Abraham I , sboyd@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, evgreen@chromium.org, Vivek Gautam , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Thu, May 03, 2018 at 02:36:13AM +0530, Manu Gautam wrote: > To improve eye diagram for PHYs on different boards of same SOC, > some parameters may need to be changed. Provide device tree > properties to override these from board specific device tree > files. While at it, replace "qcom,qusb2-v2-phy" with compatible > string for USB2 PHY on sdm845 which was earlier added for > sdm845 only. > > Signed-off-by: Manu Gautam > --- > .../devicetree/bindings/phy/qcom-qusb2-phy.txt | 23 +++++++++++++- > include/dt-bindings/phy/phy-qcom-qusb2.h | 37 ++++++++++++++++++++++ > 2 files changed, 59 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/phy/phy-qcom-qusb2.h > > diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > index 42c9742..03025d9 100644 > --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > @@ -6,7 +6,7 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. > Required properties: > - compatible: compatible list, contains > "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, > - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY. > + "qcom,sdm845-qusb2-phy" for 10nm PHY on sdm845. > > - reg: offset and length of the PHY register set. > - #phy-cells: must be 0. > @@ -27,6 +27,27 @@ Optional properties: > tuning parameter value for qusb2 phy. > > - qcom,tcsr-syscon: Phandle to TCSR syscon register region. > + - qcom,imp-res-offset-value: It is a 6 bit value that specifies offset to be > + added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY > + tuning parameter that may vary for different boards of same SOC. > + This property is applicable to only QUSB2 v2 PHY (sdm845). > + - qcom,hstx-trim-value: It is a 4 bit value that specifies tuning for HSTX > + output current. > + Possible range is - 15mA to 24mA (stepsize of 600 uA). > + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > + This property is applicable to only QUSB2 v2 PHY (sdm845). > + Default value is 22.2mA for sdm845. > + - qcom,preemphasis-level: It is a 2 bit value that specifies pre-emphasis level. > + Possible range is 0 to 15% (stepsize of 5%). > + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > + This property is applicable to only QUSB2 v2 PHY (sdm845). > + Default value is 10% for sdm845. > +- qcom,preemphasis-width: It is a 1 bit value that specifies how long the HSTX > + pre-emphasis (specified using qcom,preemphasis-level) must be in > + effect. Duration could be half-bit of full-bit. s/of/or/ But I'd just make this a boolean instead: qcom,preemphasis-half-bit > + See dt-bindings/phy/phy-qcom-qusb2.h for applicable values. > + This property is applicable to only QUSB2 v2 PHY (sdm845). > + Default value is full-bit width for sdm845. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v5,6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values From: Rob Herring Message-Id: <20180507155313.GA9696@rob-hp-laptop> Date: Mon, 7 May 2018 10:53:14 -0500 To: Manu Gautam Cc: Kishon Vijay Abraham I , sboyd@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, evgreen@chromium.org, Vivek Gautam , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gVGh1LCBNYXkgMDMsIDIwMTggYXQgMDI6MzY6MTNBTSArMDUzMCwgTWFudSBHYXV0YW0gd3Jv dGU6Cj4gVG8gaW1wcm92ZSBleWUgZGlhZ3JhbSBmb3IgUEhZcyBvbiBkaWZmZXJlbnQgYm9hcmRz IG9mIHNhbWUgU09DLAo+IHNvbWUgcGFyYW1ldGVycyBtYXkgbmVlZCB0byBiZSBjaGFuZ2VkLiBQ cm92aWRlIGRldmljZSB0cmVlCj4gcHJvcGVydGllcyB0byBvdmVycmlkZSB0aGVzZSBmcm9tIGJv YXJkIHNwZWNpZmljIGRldmljZSB0cmVlCj4gZmlsZXMuIFdoaWxlIGF0IGl0LCByZXBsYWNlICJx Y29tLHF1c2IyLXYyLXBoeSIgd2l0aCBjb21wYXRpYmxlCj4gc3RyaW5nIGZvciBVU0IyIFBIWSBv biBzZG04NDUgd2hpY2ggd2FzIGVhcmxpZXIgYWRkZWQgZm9yCj4gc2RtODQ1IG9ubHkuCj4gCj4g U2lnbmVkLW9mZi1ieTogTWFudSBHYXV0YW0gPG1nYXV0YW1AY29kZWF1cm9yYS5vcmc+Cj4gLS0t Cj4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BoeS9xY29tLXF1c2IyLXBoeS50eHQgICAgIHwg MjMgKysrKysrKysrKysrKy0KPiAgaW5jbHVkZS9kdC1iaW5kaW5ncy9waHkvcGh5LXFjb20tcXVz YjIuaCAgICAgICAgICAgfCAzNyArKysrKysrKysrKysrKysrKysrKysrCj4gIDIgZmlsZXMgY2hh bmdlZCwgNTkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ICBjcmVhdGUgbW9kZSAxMDA2 NDQgaW5jbHVkZS9kdC1iaW5kaW5ncy9waHkvcGh5LXFjb20tcXVzYjIuaAo+IAo+IGRpZmYgLS1n aXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L3Fjb20tcXVzYjItcGh5 LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waHkvcWNvbS1xdXNiMi1w aHkudHh0Cj4gaW5kZXggNDJjOTc0Mi4uMDMwMjVkOSAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L3Fjb20tcXVzYjItcGh5LnR4dAo+ICsrKyBiL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waHkvcWNvbS1xdXNiMi1waHkudHh0Cj4g QEAgLTYsNyArNiw3IEBAIFFVU0IyIGNvbnRyb2xsZXIgc3VwcG9ydHMgTFMvRlMvSFMgdXNiIGNv bm5lY3Rpdml0eSBvbiBRdWFsY29tbSBjaGlwc2V0cy4KPiAgUmVxdWlyZWQgcHJvcGVydGllczoK PiAgIC0gY29tcGF0aWJsZTogY29tcGF0aWJsZSBsaXN0LCBjb250YWlucwo+ICAJICAgICAgICJx Y29tLG1zbTg5OTYtcXVzYjItcGh5IiBmb3IgMTRubSBQSFkgb24gbXNtODk5NiwKPiAtCSAgICAg ICAicWNvbSxxdXNiMi12Mi1waHkiIGZvciBRVVNCMiBWMiBQSFkuCj4gKwkgICAgICAgInFjb20s c2RtODQ1LXF1c2IyLXBoeSIgZm9yIDEwbm0gUEhZIG9uIHNkbTg0NS4KPiAgCj4gICAtIHJlZzog b2Zmc2V0IGFuZCBsZW5ndGggb2YgdGhlIFBIWSByZWdpc3RlciBzZXQuCj4gICAtICNwaHktY2Vs bHM6IG11c3QgYmUgMC4KPiBAQCAtMjcsNiArMjcsMjcgQEAgT3B0aW9uYWwgcHJvcGVydGllczoK PiAgCQl0dW5pbmcgcGFyYW1ldGVyIHZhbHVlIGZvciBxdXNiMiBwaHkuCj4gIAo+ICAgLSBxY29t LHRjc3Itc3lzY29uOiBQaGFuZGxlIHRvIFRDU1Igc3lzY29uIHJlZ2lzdGVyIHJlZ2lvbi4KPiAr IC0gcWNvbSxpbXAtcmVzLW9mZnNldC12YWx1ZTogSXQgaXMgYSA2IGJpdCB2YWx1ZSB0aGF0IHNw ZWNpZmllcyBvZmZzZXQgdG8gYmUKPiArCQlhZGRlZCB0byBQSFkgcmVmZ2VuIFJFU0NPREUgdmlh IElNUF9DVFJMMSByZWdpc3Rlci4gSXQgaXMgYSBQSFkKPiArCQl0dW5pbmcgcGFyYW1ldGVyIHRo YXQgbWF5IHZhcnkgZm9yIGRpZmZlcmVudCBib2FyZHMgb2Ygc2FtZSBTT0MuCj4gKwkJVGhpcyBw cm9wZXJ0eSBpcyBhcHBsaWNhYmxlIHRvIG9ubHkgUVVTQjIgdjIgUEhZIChzZG04NDUpLgo+ICsg LSBxY29tLGhzdHgtdHJpbS12YWx1ZTogSXQgaXMgYSA0IGJpdCB2YWx1ZSB0aGF0IHNwZWNpZmll cyB0dW5pbmcgZm9yIEhTVFgKPiArCQlvdXRwdXQgY3VycmVudC4KPiArCQlQb3NzaWJsZSByYW5n ZSBpcyAtIDE1bUEgdG8gMjRtQSAoc3RlcHNpemUgb2YgNjAwIHVBKS4KPiArCQlTZWUgZHQtYmlu ZGluZ3MvcGh5L3BoeS1xY29tLXF1c2IyLmggZm9yIGFwcGxpY2FibGUgdmFsdWVzLgo+ICsJCVRo aXMgcHJvcGVydHkgaXMgYXBwbGljYWJsZSB0byBvbmx5IFFVU0IyIHYyIFBIWSAoc2RtODQ1KS4K PiArCQlEZWZhdWx0IHZhbHVlIGlzIDIyLjJtQSBmb3Igc2RtODQ1Lgo+ICsgLSBxY29tLHByZWVt cGhhc2lzLWxldmVsOiBJdCBpcyBhIDIgYml0IHZhbHVlIHRoYXQgc3BlY2lmaWVzIHByZS1lbXBo YXNpcyBsZXZlbC4KPiArCQlQb3NzaWJsZSByYW5nZSBpcyAwIHRvIDE1JSAoc3RlcHNpemUgb2Yg NSUpLgo+ICsJCVNlZSBkdC1iaW5kaW5ncy9waHkvcGh5LXFjb20tcXVzYjIuaCBmb3IgYXBwbGlj YWJsZSB2YWx1ZXMuCj4gKwkJVGhpcyBwcm9wZXJ0eSBpcyBhcHBsaWNhYmxlIHRvIG9ubHkgUVVT QjIgdjIgUEhZIChzZG04NDUpLgo+ICsJCURlZmF1bHQgdmFsdWUgaXMgMTAlIGZvciBzZG04NDUu Cj4gKy0gcWNvbSxwcmVlbXBoYXNpcy13aWR0aDogSXQgaXMgYSAxIGJpdCB2YWx1ZSB0aGF0IHNw ZWNpZmllcyBob3cgbG9uZyB0aGUgSFNUWAo+ICsJCXByZS1lbXBoYXNpcyAoc3BlY2lmaWVkIHVz aW5nIHFjb20scHJlZW1waGFzaXMtbGV2ZWwpIG11c3QgYmUgaW4KPiArCQllZmZlY3QuIER1cmF0 aW9uIGNvdWxkIGJlIGhhbGYtYml0IG9mIGZ1bGwtYml0LgoKcy9vZi9vci8KCkJ1dCBJJ2QganVz dCBtYWtlIHRoaXMgYSBib29sZWFuIGluc3RlYWQ6IHFjb20scHJlZW1waGFzaXMtaGFsZi1iaXQK Cj4gKwkJU2VlIGR0LWJpbmRpbmdzL3BoeS9waHktcWNvbS1xdXNiMi5oIGZvciBhcHBsaWNhYmxl IHZhbHVlcy4KPiArCQlUaGlzIHByb3BlcnR5IGlzIGFwcGxpY2FibGUgdG8gb25seSBRVVNCMiB2 MiBQSFkgKHNkbTg0NSkuCj4gKwkJRGVmYXVsdCB2YWx1ZSBpcyBmdWxsLWJpdCB3aWR0aCBmb3Ig c2RtODQ1LgotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUg InVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9y ZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIu a2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==