From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Mon, 7 May 2018 16:12:29 +0200 Subject: [U-Boot] [PATCH v2 08/11] sandbox: Enable support for MC34708 PMIC in DTS In-Reply-To: References: <20180506202608.5899-1-lukma@denx.de> <20180506202608.5899-9-lukma@denx.de> Message-ID: <20180507161229.05c43779@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Fabio, > Hi Lukasz, > > On Sun, May 6, 2018 at 5:26 PM, Lukasz Majewski wrote: > > > diff --git a/arch/sandbox/dts/sandbox.dts > > b/arch/sandbox/dts/sandbox.dts index 1fb8225fbb..b187b6fac1 100644 > > --- a/arch/sandbox/dts/sandbox.dts > > +++ b/arch/sandbox/dts/sandbox.dts > > @@ -115,6 +115,10 @@ > > sandbox_pmic: sandbox_pmic { > > reg = <0x40>; > > }; > > + > > + mc34708_pmic: mc34708_pmic { > > + reg = <0x41>; > > + }; > > I know you are following the current style of this file, but this > looks incorrect. > > According to Devicetree Specification v0.2 document: > > "The name of a node should be somewhat generic, reflecting the > function of the device and not its precise programming model." > > Also, the reg property needs to have a corresponding unit address. > > It would better to rewrite this as: > > mc34708: pmic at 41 { > reg = <0x41> > }; Yes, you are right. I've blindly followed the current (wrong) code. I'm now waiting for comments from Simon and will fix this in v3. Thanks for review. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: