From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: [PATCH] sload.f2fs: fix the missing of bit mask for file type Date: Mon, 7 May 2018 13:06:50 -0700 Message-ID: <20180507200650.GA83867@jaegeuk-macbookpro.roam.corp.google.com> References: <20180503112506.229441-1-zhengjunling@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1fFmPT-0000cV-60 for linux-f2fs-devel@lists.sourceforge.net; Mon, 07 May 2018 20:06:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1fFmPR-00AkQH-Eb for linux-f2fs-devel@lists.sourceforge.net; Mon, 07 May 2018 20:06:59 +0000 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Junling Zheng Cc: miaoxie@huawei.com, linux-f2fs-devel@lists.sourceforge.net On 05/07, Junling Zheng wrote: > Hi, Jaegeuk > > Could you please merge this fix into external/f2fs-tools repo for AOSP? > Since we found this bug while using sload feature in Android P :) Sure. Will prepare soon. Thanks, > > Thanks, > Junling > > On 2018/5/3 19:25, Junling Zheng wrote: > > Fix the missing of bit mask for the file type bit fields. > > > > Signed-off-by: Junling Zheng > > Signed-off-by: Sheng Yong > > --- > > fsck/sload.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fsck/sload.c b/fsck/sload.c > > index 2842f2c..1b7a2d1 100644 > > --- a/fsck/sload.c > > +++ b/fsck/sload.c > > @@ -157,7 +157,7 @@ static void set_inode_metadata(struct dentry *de) > > > > de->size = stat.st_size; > > de->mode = stat.st_mode & > > - (S_ISUID|S_ISGID|S_ISVTX|S_IRWXU|S_IRWXG|S_IRWXO); > > + (S_IFMT|S_ISUID|S_ISGID|S_ISVTX|S_IRWXU|S_IRWXG|S_IRWXO); > > if (c.fixed_time == -1 && c.from_dir) > > de->mtime = stat.st_mtime; > > else > > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot