From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: axboe@kernel.dk, syzkaller-bugs@googlegroups.com,
linux-block@vger.kernel.org
Subject: Re: [PATCH] loop: add recursion validation to LOOP_CHANGE_FD
Date: Mon, 7 May 2018 23:56:26 -0400 [thread overview]
Message-ID: <20180508035626.GF999@thunk.org> (raw)
In-Reply-To: <201805080028.w480SH3m013943@www262.sakura.ne.jp>
On Tue, May 08, 2018 at 09:28:17AM +0900, Tetsuo Handa wrote:
> The thread I mean is:
>
> general protection fault in lo_ioctl (2)
> https://syzkaller.appspot.com/bug?id=f3cfe26e785d85f9ee259f385515291d21bd80a3
>
> Are you sure that your patch solves this problem as well?
Well, I can't be sure, since there's not enough information in that
particular syzkaller report to definitively pin down the root cause.
And while I can't reproduce the crash using the syzkaller repro with
the patch; I can't reproduce the crash *without* the patch, either.
This is what Syzkaller has to say, but of course, in its own
documentation's words, "It's only a dumb bot". :-)e
That being said, triggering the problem which it is so concerned about
requires root privilieges, so I would not consider it high priority to
track down --- especially given that we don't have a reliable
reproducer for it.
- Ted
Hello,
syzbot has tested the proposed patch and the reproducer did not trigger
crash:
Reported-and-tested-by:
syzbot+bf89c128e05dd6c62523@syzkaller.appspotmail.com
Tested on:
commit: 170785a9cc72 loop: add recursion validation to LOOP_CHANGE..
git tree:
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/loop-fix
kernel config: https://syzkaller.appspot.com/x/.config?x=5a1dc06635c10d27
compiler: gcc (GCC) 8.0.1 20180413 (experimental)
userspace arch: i386
Note: testing is done by a robot and is best-effort only.
next prev parent reply other threads:[~2018-05-08 3:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 2:17 [PATCH] loop: add recursion validation to LOOP_CHANGE_FD Theodore Ts'o
2018-05-07 11:16 ` Tetsuo Handa
2018-05-07 13:10 ` Theodore Y. Ts'o
2018-05-07 13:21 ` Tetsuo Handa
2018-05-07 15:33 ` Theodore Y. Ts'o
2018-05-07 15:37 ` [PATCH -v2] " Theodore Ts'o
2018-06-05 13:04 ` Tetsuo Handa
2018-06-05 14:51 ` Theodore Y. Ts'o
2018-06-05 15:07 ` Jens Axboe
2018-05-07 20:45 ` [PATCH] " Tetsuo Handa
2018-05-07 23:51 ` Theodore Y. Ts'o
2018-05-08 0:28 ` Tetsuo Handa
2018-05-08 3:56 ` Theodore Y. Ts'o [this message]
2018-05-08 4:23 ` Tetsuo Handa
2018-05-09 8:49 ` Dmitry Vyukov
2018-05-09 14:02 ` Theodore Y. Ts'o
2018-05-14 7:41 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508035626.GF999@thunk.org \
--to=tytso@mit.edu \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.