All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] lib/tst_net.sh: Detect quoted parameters correctly
Date: Tue, 8 May 2018 10:05:48 +0200	[thread overview]
Message-ID: <20180508080548.2x337zth56liebqe@dell5510> (raw)
In-Reply-To: <1525749141-29004-1-git-send-email-yangx.jy@cn.fujitsu.com>

Hi,

> If we pass $* to tst_net_read_opts, we cannot detect quoted parameters
> correctly, which process only first number from quoted parameters.
> For example, running sctp_ipsec.sh -s "100 1000 65535":
...
>  if [ -n "$TST_USE_LEGACY_API" ]; then
> -	tst_net_read_opts $*
> +	tst_net_read_opts "$@"
>  	ipver=${TST_IPV6:-4}
>  fi

Acked-by: Petr Vorel <pvorel@suse.cz>

Expect to merge it on Wednesday (if nobody objects), instead of my fix with a note of
missing quotes as a root cause [1].


Kind regards,
Petr

[1] https://lists.linux.it/pipermail/ltp/2018-May/008042.html

  reply	other threads:[~2018-05-08  8:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 19:32 [LTP] [RFC PATCH 0/1] Yet another fixes for network Petr Vorel
2018-05-07 19:32 ` [LTP] [RFC PATCH 1/1] net/ipsec: Fix getopts parsing -s parameter Petr Vorel
2018-05-08  3:01   ` Xiao Yang
2018-05-08  7:50     ` Petr Vorel
2018-05-09 10:54       ` [LTP] [PATCH] lib/tst_test.sh: Detect quoted parameters correctly Xiao Yang
2018-05-09 11:31         ` Petr Vorel
2018-05-11  8:32           ` Xiao Yang
2018-05-11  9:14             ` Petr Vorel
2018-05-11  9:36               ` Xiao Yang
2018-05-09 11:01       ` [LTP] [RFC PATCH 1/1] net/ipsec: Fix getopts parsing -s parameter Xiao Yang
2018-05-09 11:34         ` Petr Vorel
2018-05-08  3:12   ` [LTP] [PATCH] lib/tst_net.sh: Detect quoted parameters correctly Xiao Yang
2018-05-08  8:05     ` Petr Vorel [this message]
2018-05-09 15:27     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508080548.2x337zth56liebqe@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.