All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Crowe <mac@mcrowe.com>
To: openembedded-devel@lists.openembedded.org
Cc: "André Draszik" <andre.draszik@jci.com>, "Mike Crowe" <mac@mcrowe.com>
Subject: [meta-java][PATCHv3] jdepend: Retrieve source from Git rather than tarball
Date: Tue,  8 May 2018 10:36:31 +0100	[thread overview]
Message-ID: <20180508093631.5196-1-mac@mcrowe.com> (raw)
In-Reply-To: <CAJTo0LZ2G_4cMxoAQm2AWgRnkeP5VXRURH9c82qaBpA0bop59A@mail.gmail.com>

When Bitbake downloads jdepend-2.9.1.zip itself and I download
https://github.com/clarkware/jdepend/blob/master/dist/jdepend-2.9.1.zip ,
the calculated hashes don't match the ones included in the recipe.

The hashes were last changed in commit
dd5c43fca8289b8795a9214aee616775e1493109 on 1st March, but GitHub claims
that the file being downloaded was published on 20th January, so I can't
explain why they are wrong. Ross Burton has provided a plausible reason in
http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html
where he also advocates switching to using Git repositories rather than
GitHub-generated tarballs.

It seems that we can't really rely on these tarballs to remain unchanged,
so let's download the Git hash that corresponds to v2.9.1 instead. This
should always remain valid.

Cc: André Draszik <andre.draszik@jci.com>
Cc: Khem Raj <raj.khem@gmail.com>
Cc: Ross Burton <ross.burton@intel.com>
Signed-off-by: Mike Crowe <mac@mcrowe.com>
---
 recipes-core/jdepend/jdepend_2.9.1.bb | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/recipes-core/jdepend/jdepend_2.9.1.bb b/recipes-core/jdepend/jdepend_2.9.1.bb
index 5f09a8b..dfbf493 100644
--- a/recipes-core/jdepend/jdepend_2.9.1.bb
+++ b/recipes-core/jdepend/jdepend_2.9.1.bb
@@ -6,7 +6,9 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=f5777d32a7709d558c2877d4a6616230"
 
 HOMEPAGE = "https://github.com/clarkware/jdepend"
 
-SRC_URI = "https://github.com/clarkware/jdepend/archive/${PV}.zip;downloadfilename=${BP}.zip"
+SRC_URI = "git://github.com/clarkware/jdepend"
+SRCREV = "57980590313a5dbde236a3eb2c8958e9e53e6a10"
+S = "${WORKDIR}/git"
 
 inherit java-library
 
@@ -18,7 +20,4 @@ do_compile() {
   fastjar cf ${JARFILENAME} -C build .
 }
 
-SRC_URI[md5sum] = "9b91efe1d770e023893f89f4dde8434e"
-SRC_URI[sha256sum] = "536b5082d64e4f4dddd514ce30178f36c7a31b34d969275f278f72e522e7f7c9"
-
 BBCLASSEXTEND = "native"
-- 
2.11.0




  reply	other threads:[~2018-05-08  9:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03  9:43 [meta-java][PATCH] jdepend: Update download hashes Mike Crowe
2018-05-03 23:06 ` Khem Raj
2018-05-04 18:37 ` [meta-java][PATCHv2] jdepend: Retrieve source from Git rather than tarball Mike Crowe
2018-05-04 19:34   ` Khem Raj
2018-05-08  9:28   ` Burton, Ross
2018-05-08  9:36     ` Mike Crowe [this message]
2018-06-11 13:10       ` [meta-java][PATCHv3] " Mike Crowe
2018-06-12  9:21       ` Richard Leitner
2018-06-12 19:46       ` Richard Leitner
2018-05-16  9:53     ` [meta-java][PATCHv2] " André Draszik
2018-05-16 10:52       ` Burton, Ross
2018-05-16 10:56         ` Burton, Ross
2018-05-16  9:29 ` [meta-java][PATCH] jdepend: Update download hashes André Draszik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508093631.5196-1-mac@mcrowe.com \
    --to=mac@mcrowe.com \
    --cc=andre.draszik@jci.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.