From: Stefan Hajnoczi <stefanha@gmail.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
Andrew Jeffery <andrew@aj.id.au>,
Jim Mussared <jim.mussared@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] arm: Add Nordic Semiconductor nRF51 SoC
Date: Tue, 8 May 2018 13:05:45 +0100 [thread overview]
Message-ID: <20180508120545.GK19710@stefanha-x1.localdomain> (raw)
In-Reply-To: <20180503090532.3113-2-joel@jms.id.au>
[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]
On Thu, May 03, 2018 at 06:35:31PM +0930, Joel Stanley wrote:
> diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c
> new file mode 100644
> index 000000000000..a2e3d6f013f0
> --- /dev/null
> +++ b/hw/arm/nrf51_soc.c
> @@ -0,0 +1,101 @@
> +/*
> + * Nordic Semiconductor nRF51 SoC
> + *
> + * Copyright 2018 Joel Stanley <joel@jms.id.au>
> + *
> + * This code is licensed under the GPL version 2 or later. See
> + * the COPYING file in the top-level directory.
Please include the link in the comment:
The reference manual is available here:
http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf
> +static void nrf51_soc_realize(DeviceState *dev_soc, Error **errp)
> +{
> + NRF51State *s = NRF51_SOC(dev_soc);
> + DeviceState *nvic;
> + Error *err = NULL;
> +
> + /* IO space */
> + create_unimplemented_device("nrf51_soc.io", IOMEM_BASE, IOMEM_SIZE);
> +
> + /* FICR */
> + create_unimplemented_device("nrf51_soc.ficr", FICR_BASE, FICR_SIZE);
> +
> + MemoryRegion *system_memory = get_system_memory();
> + MemoryRegion *sram = g_new(MemoryRegion, 1);
> + MemoryRegion *flash = g_new(MemoryRegion, 1);
> +
> + memory_region_init_ram_nomigrate(flash, NULL, "nrf51.flash", FLASH_SIZE,
> + &err);
> + if (err) {
> + error_propagate(errp, err);
> + return;
Please free resources (e.g. sram and flash) in error code paths.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2018-05-08 12:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 9:05 [Qemu-devel] [PATCH 0/2] arm: Add nRF51 SoC and micro:bit machine Joel Stanley
2018-05-03 9:05 ` [Qemu-devel] [PATCH 1/2] arm: Add Nordic Semiconductor nRF51 SoC Joel Stanley
2018-05-03 9:17 ` Peter Maydell
2018-05-08 12:01 ` Stefan Hajnoczi
2018-05-08 12:05 ` Stefan Hajnoczi [this message]
2018-05-03 9:05 ` [Qemu-devel] [PATCH 2/2] arm: Add BBC micro:bit machine Joel Stanley
2018-05-03 9:21 ` Peter Maydell
2018-05-03 9:14 ` [Qemu-devel] [PATCH 0/2] arm: Add nRF51 SoC and " no-reply
2018-05-03 9:14 ` no-reply
2018-05-03 9:16 ` no-reply
2018-05-03 9:24 ` Peter Maydell
2018-06-27 14:35 ` Joel Stanley
2018-05-08 12:08 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508120545.GK19710@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=andrew@aj.id.au \
--cc=jim.mussared@gmail.com \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.