From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932406AbeEHNh4 (ORCPT ); Tue, 8 May 2018 09:37:56 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:33811 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932240AbeEHNhy (ORCPT ); Tue, 8 May 2018 09:37:54 -0400 X-Google-Smtp-Source: AB8JxZoeSrLaanxHeE/EnvemO4oo8Lyw6QIuFeXY5tW7kcJU4AvfipmpVGw0ohO1JdiIdlNWjJp9Nw== Date: Tue, 8 May 2018 08:37:50 -0500 From: Seth Forshee To: "Eric W. Biederman" Cc: Miklos Szeredi , lkml , Linux Containers , linux-fsdevel , Alban Crequy , Sargun Dhillon , Dongsu Park , "Serge E. Hallyn" Subject: Re: [PATCH] fuse: Ensure posix acls are translated outside of init_user_ns Message-ID: <20180508133750.GA29084@ubuntu-xps13> References: <87r2mre5b3.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r2mre5b3.fsf@xmission.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 04, 2018 at 11:47:28AM -0500, Eric W. Biederman wrote: > > Ensure the translation happens by failing to read or write > posix acls when the filesystem has not indicated it supports > posix acls. > > This ensures that modern cached posix acl support is available > and used when dealing with posix acls. This is important > because only that path has the code to convernt the uids and > gids in posix acls into the user namespace of a fuse filesystem. > > Signed-off-by: "Eric W. Biederman" > --- > > Miklos after several attempts to handle this better last cycle. I > figure we should go with the stupid version for now. I think I know > how to do better but I don't want that to gate forward progress on > fully unprivileged fuse mounts. Especially as this is the last known > issue to deal with. This seems reasonable as a short-term measure. Acked-by: Seth Forshee