From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: struct tpi_info must be declared as aligned(4)
Date: Tue, 8 May 2018 14:20:48 +0200 [thread overview]
Message-ID: <20180508142048.1873edf4.cohuck@redhat.com> (raw)
In-Reply-To: <1525774672-11913-1-git-send-email-thuth@redhat.com>
On Tue, 8 May 2018 12:17:52 +0200
Thomas Huth <thuth@redhat.com> wrote:
> I've run into a compilation error today with the current version of GCC 8:
>
> In file included from s390-ccw.h:49,
> from main.c:12:
> cio.h:128:1: error: alignment 1 of 'struct tpi_info' is less than 4 [-Werror=packed-not-aligned]
> } __attribute__ ((packed));
> ^
> cc1: all warnings being treated as errors
>
> Since the struct tpi_info contains an element ("struct subchannel_id schid")
> which is marked as aligned(4), we've got to mark the struct tpi_info as
> aligned(4), too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/cio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/cio.h b/pc-bios/s390-ccw/cio.h
> index 55eaeee..1a0795f 100644
> --- a/pc-bios/s390-ccw/cio.h
> +++ b/pc-bios/s390-ccw/cio.h
> @@ -125,7 +125,7 @@ struct tpi_info {
> __u32 reserved3 : 12;
> __u32 int_type : 3;
> __u32 reserved4 : 12;
> -} __attribute__ ((packed));
> +} __attribute__ ((packed, aligned(4)));
>
> /* channel command word (type 1) */
> struct ccw1 {
Thanks, queued to s390-next with a cc:stable.
next prev parent reply other threads:[~2018-05-08 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 10:17 [Qemu-devel] [PATCH] pc-bios/s390-ccw: struct tpi_info must be declared as aligned(4) Thomas Huth
2018-05-08 10:44 ` Cornelia Huck
2018-05-08 10:49 ` Thomas Huth
2018-05-08 11:06 ` Cornelia Huck
2018-05-08 11:09 ` Christian Borntraeger
2018-05-08 11:12 ` Thomas Huth
2018-05-08 12:20 ` Cornelia Huck [this message]
2018-05-16 9:36 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508142048.1873edf4.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.