All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 5/5] qemu-img-cmds.hx: add passive-aggressive note
Date: Tue, 8 May 2018 11:49:27 -0400	[thread overview]
Message-ID: <20180508154927.GE6722@localhost.localdomain> (raw)
In-Reply-To: <20180503225648.13153-6-jsnow@redhat.com>

On Thu, May 03, 2018 at 06:56:48PM -0400, John Snow wrote:
> I'm kidding. It's very easy to forget there are per-command sections
> in the texi, and insane that we don't autogenerate those, too.
> 
> Until then, leave a little post-it note in this .hx file until I
> find a way to delete it.
>

Hopefully helps, but as you said the real fix is autogeneration.

Reviewed-by: Jeff Cody <jcody@redhat.com>

> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  qemu-img-cmds.hx | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
> index 84deb858af..3d2f7b26eb 100644
> --- a/qemu-img-cmds.hx
> +++ b/qemu-img-cmds.hx
> @@ -6,6 +6,9 @@ HXCOMM DEF(command, callback, arg_string) is used to construct
>  HXCOMM command structures and help message.
>  HXCOMM HXCOMM can be used for comments, discarded from both texi and C
>  
> +HXCOMM When amending the TEXI sections, please remember to copy the usage
> +HXCOMM over to the per-command sections in qemu-img.texi.
> +
>  STEXI
>  @table @option
>  ETEXI
> -- 
> 2.14.3
> 
> 

  reply	other threads:[~2018-05-08 15:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 22:56 [Qemu-devel] [PATCH 0/5] qemu-img: make subcommand usage docstrings consistent John Snow
2018-05-03 22:56 ` [Qemu-devel] [PATCH 1/5] qemu-img-commands.hx: argument ordering fixups John Snow
2018-05-08 15:33   ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-03 22:56 ` [Qemu-devel] [PATCH 2/5] qemu-img.texi: fix command ordering John Snow
2018-05-08 15:33   ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-03 22:56 ` [Qemu-devel] [PATCH 3/5] qemu-img: remove references to GEN_DOCS John Snow
2018-05-08 15:45   ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-03 22:56 ` [Qemu-devel] [PATCH 4/5] qemu-img: Make documentation between .texi and .hx consistent John Snow
2018-05-08 15:45   ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-03 22:56 ` [Qemu-devel] [PATCH 5/5] qemu-img-cmds.hx: add passive-aggressive note John Snow
2018-05-08 15:49   ` Jeff Cody [this message]
2018-05-04  1:03 ` [Qemu-devel] [PATCH 0/5] qemu-img: make subcommand usage docstrings consistent John Snow
2018-05-09 18:07   ` [Qemu-devel] [Qemu-block] " Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508154927.GE6722@localhost.localdomain \
    --to=jcody@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.