From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/2] dt-bindings: mtd: document Broadcom's BCM47xx partitions Date: Tue, 8 May 2018 11:25:24 -0500 Message-ID: <20180508162524.GB23960@rob-hp-laptop> References: <20180112093354.17593-1-zajec5@gmail.com> <20180119214450.vhctphu5d4kagwkv@rob-hp-laptop> <39fbb845-784b-3e73-a9c6-0729a783930f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Mark Rutland , Boris Brezillon , devicetree@vger.kernel.org, Richard Weinberger , Jonas Gorski , Marek Vasut , linux-mtd@lists.infradead.org, Cyrille Pitchen , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Brian Norris , David Woodhouse List-Id: devicetree@vger.kernel.org T24gU2F0LCBNYXkgMDUsIDIwMTggYXQgMTE6NDc6MzFQTSArMDIwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IEhpIFJvYiwKPiAKPiBPbiAyOSBNYXJjaCAyMDE4IGF0IDA4OjIzLCBSYWZhxYIg TWnFgmVja2kgPHphamVjNUBnbWFpbC5jb20+IHdyb3RlOgo+ID4gSGkgUm9iICYgc29ycnkgZm9y IHRoZSBsYXRlIHJlcGx5LiBNeSBlYXJsaWVyIGFjY2VwdGVkIHBhdGNoc2V0IGFkZGluZwo+ID4g b2ZfbWF0Y2hfdGFibGUgbWF0Y2hpbmcgd2FzIHJlcG9ydGVkIHRvIGNhdXNlIGEgcmVncmVzc2lv bi4gSXQgaGFkIHRvIGJlCj4gPiBkcm9wcGVkIGFuZCBJIGhhZCB0byBmb2N1cyBvbiBmaXhpbmcg dGhhdCBmaXJzdC4KPiA+Cj4gPgo+ID4gT24gMDEvMTkvMjAxOCAxMDo0NCBQTSwgUm9iIEhlcnJp bmcgd3JvdGU6Cj4gPj4KPiA+PiBPbiBGcmksIEphbiAxMiwgMjAxOCBhdCAxMDozMzo1M0FNICsw MTAwLCBSYWZhxYIgTWnFgmVja2kgd3JvdGU6Cj4gPj4+Cj4gPj4+IEZyb206IFJhZmHFgiBNacWC ZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KPiA+Pj4KPiA+Pj4gQnJvYWRjb20gYmFzZWQgaG9tZSBy b3V0ZXIgZGV2aWNlcyB1c2UgcGFydGl0aW9ucyB3aGljaCBoYXZlIHRvIGJlCj4gPj4+IGRpc2Nv dmVyZWQgaW4gYSBzcGVjaWZpYyBub24tc3RhbmRhcmQgd2F5LiBBcyB0aGVyZSBpcyBubyBwYXJ0 aXRpb24KPiA+Pj4gdGFibGUgdGhpcyBjb21taXQgYWRkcyBhbmQgZGVzY3JpYmVzIGEgbmV3IGN1 c3RvbSBiaW5kaW5nLgo+ID4+Pgo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBSYWZhxYIgTWnFgmVja2kg PHJhZmFsQG1pbGVja2kucGw+Cj4gPj4+IC0tLQo+ID4+PiAgLi4uL2RldmljZXRyZWUvYmluZGlu Z3MvbXRkL3BhcnRpdGlvbi50eHQgICAgICAgICAgfCA0Ngo+ID4+PiArKysrKysrKysrKysrKysr KysrKystCj4gPj4+ICAxIGZpbGUgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKPiA+Pj4KPiA+Pj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9tdGQvcGFydGl0aW9uLnR4dAo+ID4+PiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9tdGQvcGFydGl0aW9uLnR4dAo+ID4+PiBpbmRleCAzNmYzYjc2OWE2MjYuLmIy MDFkNDk3YjYxOCAxMDA2NDQKPiA+Pj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL210ZC9wYXJ0aXRpb24udHh0Cj4gPj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9tdGQvcGFydGl0aW9uLnR4dAo+ID4+PiBAQCAtMTQsOCArMTQsNiBAQCBt ZXRob2QgaXMgdXNlZCBmb3IgYSBnaXZlbiBmbGFzaCBkZXZpY2UuIFRvIGRlc2NyaWJlCj4gPj4+ IHRoZSBtZXRob2QgdGhlcmUgc2hvdWxkIGJlCj4gPj4+ICBhIHN1Ym5vZGUgb2YgdGhlIGZsYXNo IGRldmljZSB0aGF0IGlzIG5hbWVkICdwYXJ0aXRpb25zJy4gSXQgbXVzdCBoYXZlIGEKPiA+Pj4g ICdjb21wYXRpYmxlJyBwcm9wZXJ0eSwgd2hpY2ggaXMgdXNlZCB0byBpZGVudGlmeSB0aGUgbWV0 aG9kIHRvIHVzZS4KPiA+Pj4KPiA+Pj4gLVdlIGN1cnJlbnRseSBvbmx5IGRvY3VtZW50IGEgYmlu ZGluZyBmb3IgZml4ZWQgbGF5b3V0cy4KPiA+Pj4gLQo+ID4+Pgo+ID4+PiAgRml4ZWQgUGFydGl0 aW9ucwo+ID4+PiAgPT09PT09PT09PT09PT09PQo+ID4+PiBAQCAtMTA5LDMgKzEwNyw0NyBAQCBm bGFzaEAyIHsKPiA+Pj4gICAgICAgICAgICAgICAgIH07Cj4gPj4+ICAgICAgICAgfTsKPiA+Pj4g IH07Cj4gPj4+ICsKPiA+Pj4gKwo+ID4+PiArQnJvYWRjb20gQkNNNDd4eCBQYXJ0aXRpb25zCj4g Pj4+ICs9PT09PT09PT09PT09PT09PT09PT09PT09PT0KPiA+Pj4gKwo+ID4+PiArQnJvYWRjb20g aXMgb25lIG9mIGhhcmR3YXJlIG1hbnVmYWN0dXJlcnMgcHJvdmlkaW5nIFNvQ3MgKEJDTTQ3eHgp IHVzZWQKPiA+Pj4gaW4KPiA+Pj4gK2hvbWUgcm91dGVycy4gVGhlaXIgQkNNOTQ3eHggYm9hcmRz IHVzaW5nIENGRSBib290bG9hZGVyIGhhdmUgc2V2ZXJhbAo+ID4+PiBwYXJ0aXRpb25zCj4gPj4+ ICt3aXRob3V0IGFueSBvbi1mbGFzaCBwYXJ0aXRpb24gdGFibGUuIE9uIHNvbWUgZGV2aWNlcyB0 aGVpciBzaXplcyBhbmQvb3IKPiA+Pj4gK21lYW5pbmdzIGNhbiBhbHNvIHZhcnkgc28gZml4ZWQg cGFydGl0aW9uaW5nIGNhbid0IGJlIHVzZWQuCj4gPj4+ICsKPiA+Pj4gK0Rpc2NvdmVyaW5nIHBh cnRpdGlvbnMgb24gdGhlc2UgZGV2aWNlcyBpcyBwb3NzaWJsZSB0aGFua3MgdG8gaGF2aW5nIGEK PiA+Pj4gc3BlY2lhbAo+ID4+PiAraGVhZGVyIGFuZC9vciBtYWdpYyBzaWduYXR1cmUgYXQgdGhl IGJlZ2lubmluZyBvZiBlYWNoIG9mIHRoZW0uIFRoZXkgYXJlCj4gPj4+IGFsc28KPiA+Pj4gK2Js b2NrIGFsaWduZWQgd2hpY2ggaXMgaW1wb3J0YW50IGZvciBkZXRlcm1pbmlnIGEgc2l6ZS4KPiA+ Pj4gKwo+ID4+PiArTW9zdCBvZiBwYXJ0aXRpb25zIHVzZSBBU0NJSSB0ZXh0IGJhc2VkIG1hZ2lj IGZvciBkZXRlcm1pbmluZyBhIHR5cGUuCj4gPj4+IE1vcmUKPiA+Pj4gK2NvbXBsZXggcGFydGl0 aW9ucyAobGlrZSBUUlggd2l0aCBpdHMgSERSMCBtYWdpYykgbWF5IGluY2x1ZGUgZXh0cmEKPiA+ Pj4gaGVhZGVyCj4gPj4+ICtjb250YWluaW5nIHNvbWUgZGV0YWlscywgaW5jbHVkaW5nIGEgbGVu Z3RoLgo+ID4+PiArCj4gPj4+ICtBIGxpc3Qgb2Ygc3VwcG9ydGVkIHBhcnRpdGlvbnMgaW5jbHVk ZXM6Cj4gPj4+ICsxKSBCb290bG9hZGVyIHdpdGggQnJvYWRjb20ncyBDRkUgKENvbW1vbiBGaXJt d2FyZSBFbnZpcm9ubWVudCkKPiA+Pj4gKzIpIE5WUkFNIHdpdGggY29uZmlndXJhdGlvbi9jYWxp YnJhdGlvbiBkYXRhCj4gPj4+ICszKSBEZXZpY2UgbWFudWZhY3R1cmVyJ3MgZGF0YSB3aXRoIHNv bWUgZGVmYXVsdCB2YWx1ZXMgKGUuZy4gU1NJRHMpCj4gPj4+ICs0KSBUUlggZmlybXdhcmUgY29u dGFpbmVyIHdoaWNoIGNhbiBob2xkIHVwIHRvIDQgc3VicGFydGl0aW9ucwo+ID4+PiArNSkgQmFj a3VwIFRSWCBmaXJtd2FyZSB1c2VkIGFmdGVyIGZhaWxlZCB1cGdyYWRlCj4gPj4+ICsKPiA+Pj4g K0FzIG1lbnRpb25lZCBlYXJsaWVyLCByb2xlIG9mIHNvbWUgcGFydGl0aW9ucyBtYXkgZGVwZW5k IG9uIGV4dHJhCj4gPj4+IGNvbmZpZ3VyYXRpb24uCj4gPj4+ICtGb3IgZXhhbXBsZSBib3RoOiBt YWluIGZpcm13YXJlIGFuZCBiYWNrdXAgZmlybXdhcmUgdXNlIHRoZSBzYW1lIFRSWAo+ID4+PiBm b3JtYXQgd2l0aAo+ID4+PiArdGhlIHNhbWUgaGVhZGVyLiBUbyBkaXN0aW5ndWlzaCBjdXJyZW50 bHkgdXNlZCBmaXJtd2FyZSBhIENGRSdzCj4gPj4+IGVudmlyb25tZW50Cj4gPj4+ICt2YXJpYWJs ZSAiYm9vdHBhcnRpdGlvbiIgaXMgdXNlZC4KPiA+Pj4gKwo+ID4+PiArCj4gPj4+ICtEZXZpY2Vz IHVzaW5nIEJyb2FkY29tIHBhcnRpdGlvbnMgZGVzY3JpYmVkIGFib3ZlIHNob3VsZCBzaG91bGQg aGF2ZQo+ID4+PiBmbGFzaCBub2RlCj4gPj4+ICt3aXRoIGEgc3Vibm9kZSBuYW1lZCAicGFydGl0 aW9ucyIgdXNpbmcgZm9sbG93aW5nIHByb3BlcnRpZXM6Cj4gPj4+ICsKPiA+Pj4gK1JlcXVpcmVk IHByb3BlcnRpZXM6Cj4gPj4+ICstIGNvbXBhdGlibGUgOiAocmVxdWlyZWQpIG11c3QgYmUgImJy Y20sYmNtOTQ3eHgtY2ZlLXBhcnRpdGlvbnMiCj4gPj4KPiA+Pgo+ID4+IFNvIHlvdSBjYW4ndCBk aXNjb3ZlciB5b3UgaGF2ZSBDRkUgcGFydGl0aW9ucywgYnV0IHlvdSBjYW4gZGlzY292ZXIKPiA+ PiBldmVyeXRoaW5nIGVsc2UgbGlrZSB3aGVyZSBwYXJ0aXRpb25zIHN0YXJ0Pwo+ID4KPiA+Cj4g PiBJIGNvdWxkIGRpc2NvdmVyIHRoZXJlIGlzIGEgQ0ZFIGJvb3Rsb2FkZXIgYXQgdGhlIGZsYXNo IGJlZ2lubmluZyBhbmQKPiA+IGFzc3VtZSB0aGVyZSBhcmUgQ0ZFLWxpa2UgcGFydGl0aW9ucy4g SXQgZG9lc24ndCBzb3VuZCBzYWZlIGhvd2V2ZXIgYW5kCj4gPiBJIGJlbGlldmUgdGhlIHBvaW50 IG9mIHVzaW5nIERUICsgY29tcGF0aWJsZSBwcm9wZXJ0aWVzIGlzIHRvIGF2b2lkIHN1Y2gKPiA+ IC9ndWVzc2luZy8uIFRoZXJlIGFyZSB0b28gbWFueSBjYXNlcywgZGV2aWNlcywgImZvcm1hdHMi IHRvIGp1c3QgYmxpbmRseQo+ID4gdHJ5IGV2ZXJ5IHBvc3NpYmxlIHBhcnNlci4gVGhhdCdzIHdo eSB3ZSBhZ3JlZWQgdG8gdXNlICJjb21wYXRpYmxlIgo+ID4gc3RyaW5ncy4KPiA+Cj4gPiBUaGlz IHdhcyBhbHNvIGRlc2NyaWJlZCBieSBCb3JpcyBpbiBoaXMgcGF0Y2hzZXQgMisgeWVhcnMgYWdv Ogo+ID4gW1JGQyBQQVRDSCAwLzddIG10ZDogcGFydGl0aW9uczogYWRkIG9mX21hdGNoX3RhYmxl IHN1cHBvcnQKPiA+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL3BpcGVybWFpbC9saW51eC1t dGQvMjAxNS1EZWNlbWJlci8wNjQwNzYuaHRtbAo+ID4KPiA+PiAgKDIpIHdlIGNhbid0IGp1c3Qg c2NhbiBmb3IgYWxsIHN1cHBvcnRlZCBwYXJzZXJzIChsaWtlIHRoZSBibG9jayBzeXN0ZW0KPiA+ PiBkb2VzKSwgc2luY2UKPiA+PiAgICAgIHRoZXJlIGlzIGEgd2lkZSBkaXZlcnNpdHkgb2YgImZv cm1hdHMiIChubyBzdGFuZGFyZGl6YXRpb24pLCBhbmQgaXQKPiA+PiBpcyBub3QKPiA+PiAgICAg IGFsd2F5cyBzYWZlIG9yIGVmZmljaWVudCB0byBhdHRlbXB0IHRvIGRvIHNvLCBwYXJ0aWN1bGFy bHkgc2luY2UgbWFueQo+ID4+IG9mCj4gPj4gICAgICB0aGVtIGFsbG93IHRoZWlyIGRhdGEgc3Ry dWN0dXJlcyB0byBiZSBwbGFjZWQgYW55d2hlcmUgb24gdGhlIGZsYXNoLAo+ID4+IGFuZAo+ID4+ ICAgICAgc28gcmVxdWlyZSBzY2FubmluZyB0aGUgZW50aXJlIGZsYXNoIGRldmljZSB0byBmaW5k IHRoZW0uCj4gPgo+ID4gSSBhbHNvIGJlbGlldmUgdGhpcyBpcyBzb2x1dGlvbiB5b3UgYWNrZWQg YmFjayB0aGVuOgo+ID4gW1JGQyBQQVRDSCAzLzddIGRvYzogZHQ6IG10ZDogcGFydGl0aW9uOiBh ZGQgb24tZmxhc2ggZm9ybWF0IGJpbmRpbmcKPiA+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L3BpcGVybWFpbC9saW51eC1tdGQvMjAxNS1EZWNlbWJlci8wNjQxMDAuaHRtbAo+ID4KPiA+PiBP biBGcmksIERlYyAwNCwgMjAxNSBhdCAwOToxOToxOVBNIC0wODAwLCBCcmlhbiBOb3JyaXMgd3Jv dGU6Cj4gPj4gPiBUaGUgcGxhdGZvcm0gZGVzY3JpcHRpb24gKHN1Y2ggYXMgdGhlIHR5cGUgb2Yg cGFydGl0aW9uIGZvcm1hdHMgdXNlZCBvbgo+ID4+ID4gYSBnaXZlbiBmbGFzaCkgc2hvdWxkIGJl IGRvbmUgaW5kZXBlbmRlbnRseSBvZiB0aGUgZmxhc2ggZHJpdmVyIGluIHVzZS4KPiA+PiA+IEhv d2V2ZXIsIHdlIGNhbid0IHJlYXNvbmFibHkgaGF2ZSAqYWxsKiBwYXJ0aXRpb24gcGFyc2VycyBy dW4gb24gYWxsCj4gPj4gPiBmbGFzaCAodW50aWwgdGhleSBmaW5kIGEgbWF0Y2gpLCBzbyBsZXQn cyBvdmVybG9hZCB0aGUgJ3BhcnRpdGlvbnMnCj4gPj4gPiBzdWJub2RlIHRvIHN1cHBvcnQgc3Bl Y2lmeWluZyB3aGljaCBmb3JtYXQocykgdG8gdHJ5IGluIHRoZSBkZXZpY2UgdHJlZS4KPiA+PiA+ Cj4gPj4gPiAoLi4uKQo+ID4+Cj4gPj4gTG9va3MgZ29vZCB0byBtZS4gSWYgeW91IGhhZCBsb3Rz IG9mIHBhcnRpdGlvbnMsIEknZCBhZ3JlZSB3aXRoIGNvbW1lbnRzCj4gPj4gdGhhdCB0aGV5IHNo b3VsZCBiZSBzZXBhcmF0ZSBmaWxlcywgYnV0IEkgZG91YnQgd2UnbGwgaGF2ZSBtYW55IDEwcyBv Zgo+ID4+IHRoZW0uIFBsdXMgYWxsIHdlIHJlYWxseSBuZWVkIGhlcmUgaXMgYSBsaXN0IG9mIGNv bXBhdGlibGUgc3RyaW5ncy4KPiA+Pgo+ID4+IEFja2VkLWJ5OiBSb2IgSGVycmluZyA8cm9iaCBh dCBrZXJuZWwub3JnPgo+ID4KPiA+IFNvIEkgZ3Vlc3MgdGhlIGFuc3dlciBpczoKPiA+IDEpIEkg cmVhbGx5IGRvbid0IHdhbnQgdG8gYmxpbmRseSBsb29rIGZvciBDRkUtbGlrZSBwYXJ0aXRpb25z LiBUb28gbXVjaAo+ID4gICAgcmlzayBvZiBmYWxzZSBwb3NpdGl2ZXMuCj4gPiAyKSBJIGRvbid0 IHdhbnQgcGFyc2VyIHRvIGJlIGJsaW5kbHkgY2FsbGVkICYgdXNlIGV4dHJhIG1hZ2ljIGNoZWNr cyB0bwo+ID4gICAgbWFrZSBzdXJlIEknbSBkZWFsaW5nIHdpdGggZGV2aWNlIHVzaW5nIENGRSBi b290bG9hZGVyLgo+ID4gMykgT25jZSBJIGtub3cgSSdtIGRlYWxpbmcgd2l0aCBkZXZpY2UgdXNp bmcgQ0ZFIGJvb3Rsb2FkZXIgSSBjYW4gZmluZAo+ID4gICAgcGFydGl0aW9ucyBvbiB0aGUgZmxh c2guCj4gPgo+ID4KPiA+PiBXaHkgZG9lc24ndCB0aGUga2VybmVsIGp1c3QgcHJvYmUgZm9yIHRo ZSBwYXJ0aXRpb24gdGFibGU/Cj4gPgo+ID4KPiA+IElmIGJ5IGEgInBhcnRpdGlvbiB0YWJsZSIg eW91IG1lYW4gYSBzaW5nbGUgYmxvY2sgd2l0aCBkYXRhIHVzaW5nIGEKPiA+IGNsZWFyIHN0cnVj dHVyZTogaXQgZG9lc24ndCBleGlzdC4gVGhhdCdzIHRoZSB3aG9sZSBwb2ludCB3aXRoIGNyYXBw eQo+ID4gQnJvYWRjb20gZGV2aWNlcy4KPiAKPiBXb3VsZCB5b3UgZmluZCBhIG1vbWVudCB0byBy ZXZpZXcgdGhhdCBwYXRjaCBhZ2FpbiwgYWZ0ZXIgZXh0cmEKPiBleHBsYW5hdGlvbiBJIHByb3Zp ZGVkLCBwbGVhc2U/CgpJIGd1ZXNzIHRoaXMgaXMgZmluZS4gQ2FuIHlvdSByZXNlbmQgYXMgSSBk b24ndCBoYXZlIHRoZSBvcmlnaW5hbCBwYXRjaC4gCgpJIHRoaW5rIGl0IHNob3VsZCBiZSBhIHNl cGFyYXRlIGZpbGUgdGhvdWdoIGFzIHBhcnRpdGlvbi50eHQgd291bGQgCmJlY29tZSB2ZXJ5IGxv bmcgaWYgZXZlcnkgdmVuZG9yIHBhcnRpdGlvbmluZyB3YXMgYWRkZWQgdGhlcmUuCgpSb2IKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot0-f195.google.com ([74.125.82.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fG5Qo-0003t3-46 for linux-mtd@lists.infradead.org; Tue, 08 May 2018 16:25:46 +0000 Received: by mail-ot0-f195.google.com with SMTP id t1-v6so36730903ott.13 for ; Tue, 08 May 2018 09:25:27 -0700 (PDT) Date: Tue, 8 May 2018 11:25:24 -0500 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Brian Norris , David Woodhouse , Boris Brezillon , Marek Vasut , Richard Weinberger , Cyrille Pitchen , Mark Rutland , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, Jonas Gorski , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH 1/2] dt-bindings: mtd: document Broadcom's BCM47xx partitions Message-ID: <20180508162524.GB23960@rob-hp-laptop> References: <20180112093354.17593-1-zajec5@gmail.com> <20180119214450.vhctphu5d4kagwkv@rob-hp-laptop> <39fbb845-784b-3e73-a9c6-0729a783930f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, May 05, 2018 at 11:47:31PM +0200, Rafał Miłecki wrote: > Hi Rob, > > On 29 March 2018 at 08:23, Rafał Miłecki wrote: > > Hi Rob & sorry for the late reply. My earlier accepted patchset adding > > of_match_table matching was reported to cause a regression. It had to be > > dropped and I had to focus on fixing that first. > > > > > > On 01/19/2018 10:44 PM, Rob Herring wrote: > >> > >> On Fri, Jan 12, 2018 at 10:33:53AM +0100, Rafał Miłecki wrote: > >>> > >>> From: Rafał Miłecki > >>> > >>> Broadcom based home router devices use partitions which have to be > >>> discovered in a specific non-standard way. As there is no partition > >>> table this commit adds and describes a new custom binding. > >>> > >>> Signed-off-by: Rafał Miłecki > >>> --- > >>> .../devicetree/bindings/mtd/partition.txt | 46 > >>> +++++++++++++++++++++- > >>> 1 file changed, 44 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/mtd/partition.txt > >>> b/Documentation/devicetree/bindings/mtd/partition.txt > >>> index 36f3b769a626..b201d497b618 100644 > >>> --- a/Documentation/devicetree/bindings/mtd/partition.txt > >>> +++ b/Documentation/devicetree/bindings/mtd/partition.txt > >>> @@ -14,8 +14,6 @@ method is used for a given flash device. To describe > >>> the method there should be > >>> a subnode of the flash device that is named 'partitions'. It must have a > >>> 'compatible' property, which is used to identify the method to use. > >>> > >>> -We currently only document a binding for fixed layouts. > >>> - > >>> > >>> Fixed Partitions > >>> ================ > >>> @@ -109,3 +107,47 @@ flash@2 { > >>> }; > >>> }; > >>> }; > >>> + > >>> + > >>> +Broadcom BCM47xx Partitions > >>> +=========================== > >>> + > >>> +Broadcom is one of hardware manufacturers providing SoCs (BCM47xx) used > >>> in > >>> +home routers. Their BCM947xx boards using CFE bootloader have several > >>> partitions > >>> +without any on-flash partition table. On some devices their sizes and/or > >>> +meanings can also vary so fixed partitioning can't be used. > >>> + > >>> +Discovering partitions on these devices is possible thanks to having a > >>> special > >>> +header and/or magic signature at the beginning of each of them. They are > >>> also > >>> +block aligned which is important for determinig a size. > >>> + > >>> +Most of partitions use ASCII text based magic for determining a type. > >>> More > >>> +complex partitions (like TRX with its HDR0 magic) may include extra > >>> header > >>> +containing some details, including a length. > >>> + > >>> +A list of supported partitions includes: > >>> +1) Bootloader with Broadcom's CFE (Common Firmware Environment) > >>> +2) NVRAM with configuration/calibration data > >>> +3) Device manufacturer's data with some default values (e.g. SSIDs) > >>> +4) TRX firmware container which can hold up to 4 subpartitions > >>> +5) Backup TRX firmware used after failed upgrade > >>> + > >>> +As mentioned earlier, role of some partitions may depend on extra > >>> configuration. > >>> +For example both: main firmware and backup firmware use the same TRX > >>> format with > >>> +the same header. To distinguish currently used firmware a CFE's > >>> environment > >>> +variable "bootpartition" is used. > >>> + > >>> + > >>> +Devices using Broadcom partitions described above should should have > >>> flash node > >>> +with a subnode named "partitions" using following properties: > >>> + > >>> +Required properties: > >>> +- compatible : (required) must be "brcm,bcm947xx-cfe-partitions" > >> > >> > >> So you can't discover you have CFE partitions, but you can discover > >> everything else like where partitions start? > > > > > > I could discover there is a CFE bootloader at the flash beginning and > > assume there are CFE-like partitions. It doesn't sound safe however and > > I believe the point of using DT + compatible properties is to avoid such > > /guessing/. There are too many cases, devices, "formats" to just blindly > > try every possible parser. That's why we agreed to use "compatible" > > strings. > > > > This was also described by Boris in his patchset 2+ years ago: > > [RFC PATCH 0/7] mtd: partitions: add of_match_table support > > http://lists.infradead.org/pipermail/linux-mtd/2015-December/064076.html > > > >> (2) we can't just scan for all supported parsers (like the block system > >> does), since > >> there is a wide diversity of "formats" (no standardization), and it > >> is not > >> always safe or efficient to attempt to do so, particularly since many > >> of > >> them allow their data structures to be placed anywhere on the flash, > >> and > >> so require scanning the entire flash device to find them. > > > > I also believe this is solution you acked back then: > > [RFC PATCH 3/7] doc: dt: mtd: partition: add on-flash format binding > > http://lists.infradead.org/pipermail/linux-mtd/2015-December/064100.html > > > >> On Fri, Dec 04, 2015 at 09:19:19PM -0800, Brian Norris wrote: > >> > The platform description (such as the type of partition formats used on > >> > a given flash) should be done independently of the flash driver in use. > >> > However, we can't reasonably have *all* partition parsers run on all > >> > flash (until they find a match), so let's overload the 'partitions' > >> > subnode to support specifying which format(s) to try in the device tree. > >> > > >> > (...) > >> > >> Looks good to me. If you had lots of partitions, I'd agree with comments > >> that they should be separate files, but I doubt we'll have many 10s of > >> them. Plus all we really need here is a list of compatible strings. > >> > >> Acked-by: Rob Herring > > > > So I guess the answer is: > > 1) I really don't want to blindly look for CFE-like partitions. Too much > > risk of false positives. > > 2) I don't want parser to be blindly called & use extra magic checks to > > make sure I'm dealing with device using CFE bootloader. > > 3) Once I know I'm dealing with device using CFE bootloader I can find > > partitions on the flash. > > > > > >> Why doesn't the kernel just probe for the partition table? > > > > > > If by a "partition table" you mean a single block with data using a > > clear structure: it doesn't exist. That's the whole point with crappy > > Broadcom devices. > > Would you find a moment to review that patch again, after extra > explanation I provided, please? I guess this is fine. Can you resend as I don't have the original patch. I think it should be a separate file though as partition.txt would become very long if every vendor partitioning was added there. Rob