All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs-progs: print-tree: Avoid segfault for heavily corrupted item pointers
Date: Tue, 8 May 2018 19:20:26 +0200	[thread overview]
Message-ID: <20180508172026.GL6649@twin.jikos.cz> (raw)
In-Reply-To: <c799c7cd-d1bb-e650-4348-e325f13ea421@gmx.com>

On Mon, May 07, 2018 at 04:56:21PM +0800, Qu Wenruo wrote:
> 
> 
> On 2018年05月07日 15:46, Qu Wenruo wrote:
> > Normally corrupted leaf should be caught by csum check, but sometimes
> > corrupted item pointers (out of leaf range) can still pass csum check.
> > In fact, our fsck/005 test case image has such corrupted item pointer
> > and btrfs check can surprisingly fix it.
> > 
> > Anyway, make print-tree to skip such item and remaining slots to avoid
> > segfault.
> > 
> > Please note that, in btrfs-progs we can't put such check into
> > check_tree_block() nor do kernel level comprehensive check as under
> > certain case, btrfs-progs can handle or even repair it.
> > A restrict check_tree_block() or backporting kernel btrfs_check_leaf()
> > could break such test cases and reduce the utility of btrfs-progs.
> > 
> > Issue: #128
> > Reported-by: Hubert Kario <kario@wit.edu.pl>
> 
> Mail changed to <hubert@kario.pl> (Github version already updated.)

Updated and applied, thanks.

      reply	other threads:[~2018-05-08 17:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07  7:46 [PATCH 1/2] btrfs-progs: print-tree: Avoid segfault for heavily corrupted item pointers Qu Wenruo
2018-05-07  7:46 ` [PATCH 2/2] btrfs-progs: misc-tests: Add test case for dump-tree on heavily corrupted leaf Qu Wenruo
2018-05-07  8:56 ` [PATCH 1/2] btrfs-progs: print-tree: Avoid segfault for heavily corrupted item pointers Qu Wenruo
2018-05-08 17:20   ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508172026.GL6649@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.