From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:37899 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755266AbeEHVL5 (ORCPT ); Tue, 8 May 2018 17:11:57 -0400 Date: Tue, 8 May 2018 23:11:54 +0200 From: Boris Brezillon To: Boris Brezillon , Richard Weinberger , Miquel Raynal , linux-mtd@lists.infradead.org Cc: Marek Vasut , Brian Norris , David Woodhouse , stable@vger.kernel.org, Cyrille Pitchen Subject: Re: [PATCH v2] mtd: rawnand: Make sure we wait tWB before polling the STATUS reg Message-ID: <20180508231154.09f4d86a@bbrezillon> In-Reply-To: <20180507113522.03a52da9@bbrezillon> References: <20180504192431.16661-1-boris.brezillon@bootlin.com> <20180507113522.03a52da9@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Mon, 7 May 2018 11:35:22 +0200 Boris Brezillon wrote: > On Fri, 4 May 2018 21:24:31 +0200 > Boris Brezillon wrote: > > > NAND chips require a bit of time to take the NAND operation into > > account and set the BUSY bit in the STATUS reg. Make sure we don't poll > > the STATUS reg too early in nand_soft_waitrdy(). > > > > Fixes: 8878b126df76 ("mtd: nand: add ->exec_op() implementation") > > Cc: > > Signed-off-by: Boris Brezillon > > --- > > Changes in v2: > > - Move the ndelay() to nand_soft_waitrdy() instead of having it in the > > FSMC driver > > --- > > drivers/mtd/nand/raw/nand_base.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > > index 72f3a89da513..da94fcb4dd9b 100644 > > --- a/drivers/mtd/nand/raw/nand_base.c > > +++ b/drivers/mtd/nand/raw/nand_base.c > > @@ -706,12 +706,17 @@ static void nand_wait_status_ready(struct mtd_info *mtd, unsigned long timeo) > > */ > > int nand_soft_waitrdy(struct nand_chip *chip, unsigned long timeout_ms) > > { > > + const struct nand_sdr_timings *timings; > > u8 status = 0; > > int ret; > > > > if (!chip->exec_op) > > return -ENOTSUPP; > > > > + /* Wait tWB before polling the STATUS reg. */ > > + timings = nand_get_sdr_timings(&chip->data_interface); > > + ndelay(PSEC_TO_NSEC(sdr->tWB_max)); > > ^ timings->tWB_max > > And for those who wonder, yes, I compiled the code, but it seems I > forgot to amend the commit after fixing the bug locally :-). Queued to mtd/master after fixing the problem. > > > + > > ret = nand_status_op(chip, NULL); > > if (ret) > > return ret; > > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/