From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH net-next v3 0/2] socket statistics for ss Date: Wed, 9 May 2018 08:22:09 -0700 Message-ID: <20180509082209.38fa4f43@xeon-e3> References: <20180507184333.32688-1-sthemmin@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dccp@vger.kernel.org, Stephen Hemminger To: davem@davemloft.net, gerrit@erg.abdn.ac.uk, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:43190 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935391AbeEIPWM (ORCPT ); Wed, 9 May 2018 11:22:12 -0400 Received: by mail-pf0-f194.google.com with SMTP id j20so11484803pff.10 for ; Wed, 09 May 2018 08:22:12 -0700 (PDT) In-Reply-To: <20180507184333.32688-1-sthemmin@microsoft.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 7 May 2018 11:43:31 -0700 Stephen Hemminger wrote: > The eventual goal is to remove all accesses to slab statistics > by iproute2 ss command. This are preliminary steps to add two > statistics which are not working now, because of slab merging > and changes that were done years ago to allow for common inet_hash > tables. > > Stephen Hemminger (2): > inet: add bound ports statistic > socket: keep track of the number of sockets allocated > > v3 > - fix build :-( > - add allocated sockets statistic > > include/net/inet_hashtables.h | 3 +++ > include/net/inet_timewait_sock.h | 2 ++ > net/dccp/proto.c | 1 + > net/ipv4/inet_hashtables.c | 22 +++++++++++++++++++--- > net/ipv4/inet_timewait_sock.c | 8 +++++--- > net/ipv4/proc.c | 5 +++-- > net/ipv4/tcp.c | 1 + > net/socket.c | 21 +++++++++++++++++++-- > 8 files changed, 53 insertions(+), 10 deletions(-) > I am not sure if these patches are worth applying. The 'ss -s' command has had missing values since 2.4 kernel. And the first complaints came in only this year. Another alternative would be just to remove these fields from ss -s output and move on. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Date: Wed, 09 May 2018 15:22:09 +0000 Subject: Re: [PATCH net-next v3 0/2] socket statistics for ss Message-Id: <20180509082209.38fa4f43@xeon-e3> List-Id: References: <20180507184333.32688-1-sthemmin@microsoft.com> In-Reply-To: <20180507184333.32688-1-sthemmin@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dccp@vger.kernel.org On Mon, 7 May 2018 11:43:31 -0700 Stephen Hemminger wrote: > The eventual goal is to remove all accesses to slab statistics > by iproute2 ss command. This are preliminary steps to add two > statistics which are not working now, because of slab merging > and changes that were done years ago to allow for common inet_hash > tables. > > Stephen Hemminger (2): > inet: add bound ports statistic > socket: keep track of the number of sockets allocated > > v3 > - fix build :-( > - add allocated sockets statistic > > include/net/inet_hashtables.h | 3 +++ > include/net/inet_timewait_sock.h | 2 ++ > net/dccp/proto.c | 1 + > net/ipv4/inet_hashtables.c | 22 +++++++++++++++++++--- > net/ipv4/inet_timewait_sock.c | 8 +++++--- > net/ipv4/proc.c | 5 +++-- > net/ipv4/tcp.c | 1 + > net/socket.c | 21 +++++++++++++++++++-- > 8 files changed, 53 insertions(+), 10 deletions(-) > I am not sure if these patches are worth applying. The 'ss -s' command has had missing values since 2.4 kernel. And the first complaints came in only this year. Another alternative would be just to remove these fields from ss -s output and move on.