All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libcap: only install shared version
Date: Wed, 9 May 2018 09:47:43 +0200	[thread overview]
Message-ID: <20180509094743.6eb34b9b@windsurf.home> (raw)
In-Reply-To: <20180508161136.13531-1-fontaine.fabrice@gmail.com>

Hello,

On Tue,  8 May 2018 18:11:36 +0200, Fabrice Fontaine wrote:

> diff --git a/package/libcap/libcap.mk b/package/libcap/libcap.mk
> index 48c2cb3456..247fd8a58f 100644
> --- a/package/libcap/libcap.mk
> +++ b/package/libcap/libcap.mk
> @@ -20,8 +20,12 @@ LIBCAP_MAKE_TARGET = libcap.a libcap.pc
>  LIBCAP_MAKE_INSTALL_TARGET = install-static
>  else
>  LIBCAP_MAKE_TARGET = all
> +ifeq ($(BR2_SHARED_LIBS),y)
> +LIBCAP_MAKE_INSTALL_TARGET = install-shared
> +else
>  LIBCAP_MAKE_INSTALL_TARGET = install
>  endif
> +endif

I think we could use a clearer approach:

ifeq ($(BR2_STATIC_LIBS),y)
LIBCAP_MAKE_TARGET = libcap.a libcap.pc
LIBCAP_MAKE_INSTALL_TARGET = install-static
else if ($(BR2_SHARED_LIBS),y)
LIBCAP_MAKE_TARGET = all
LIBCAP_MAKE_INSTALL_TARGET = install-shared
else
LIBCAP_MAKE_TARGET = all
LIBCAP_MAKE_INSTALL_TARGET = install
endif

is a lot clearer to me.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-05-09  7:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 16:11 [Buildroot] [PATCH 1/1] libcap: only install shared version Fabrice Fontaine
2018-05-09  7:47 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180509094743.6eb34b9b@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.