All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Pau Monne <roger.pau@citrix.com>
To: <linux-kernel@vger.kernel.org>
Cc: Roger Pau Monne <roger.pau@citrix.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>
Subject: [PATCH v2 2/3] xen/store: do not store local values in xen_start_info
Date: Wed, 9 May 2018 11:21:28 +0100	[thread overview]
Message-ID: <20180509102129.14832-3-roger.pau@citrix.com> (raw)
In-Reply-To: <20180509102129.14832-1-roger.pau@citrix.com>

There's no need to store the xenstore page or event channel in
xen_start_info if they are locally initialized.

This also fixes PVH local xenstore initialization due to the lack of
xen_start_info in that case.

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org
---
 drivers/xen/xenbus/xenbus_probe.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
index ec9eb4fba59c..f2088838f690 100644
--- a/drivers/xen/xenbus/xenbus_probe.c
+++ b/drivers/xen/xenbus/xenbus_probe.c
@@ -710,7 +710,7 @@ static int __init xenstored_local_init(void)
 	if (!page)
 		goto out_err;
 
-	xen_store_gfn = xen_start_info->store_mfn = virt_to_gfn((void *)page);
+	xen_store_gfn = virt_to_gfn((void *)page);
 
 	/* Next allocate a local port which xenstored can bind to */
 	alloc_unbound.dom        = DOMID_SELF;
@@ -722,8 +722,7 @@ static int __init xenstored_local_init(void)
 		goto out_err;
 
 	BUG_ON(err);
-	xen_store_evtchn = xen_start_info->store_evtchn =
-		alloc_unbound.port;
+	xen_store_evtchn = alloc_unbound.port;
 
 	return 0;
 
-- 
2.17.0

  parent reply	other threads:[~2018-05-09 10:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 10:21 [PATCH v2 0/3] xen/pvh: Dom0 support Roger Pau Monne
2018-05-09 10:21 ` [PATCH v2 1/3] xen/pvh: enable and set default MTRR type Roger Pau Monne
2018-05-09 10:21 ` Roger Pau Monne
2018-05-09 10:56   ` [Xen-devel] " Andrew Cooper
2018-05-09 11:30     ` Roger Pau Monné
2018-05-09 15:11       ` Roger Pau Monné
2018-05-10 11:52         ` Wei Liu
2018-05-10 11:52         ` Wei Liu
2018-05-11  7:33         ` Juergen Gross
2018-05-11  7:33         ` [Xen-devel] " Juergen Gross
2018-05-09 15:11       ` Roger Pau Monné
2018-05-09 11:30     ` Roger Pau Monné
2018-05-09 10:56   ` Andrew Cooper
2018-05-09 10:21 ` [PATCH v2 2/3] xen/store: do not store local values in xen_start_info Roger Pau Monne
2018-05-09 10:21 ` Roger Pau Monne [this message]
2018-05-11  7:34   ` Juergen Gross
2018-05-11  7:34   ` Juergen Gross
2018-05-17  6:43   ` Juergen Gross
2018-05-17  6:43   ` Juergen Gross
2018-05-09 10:21 ` [PATCH v2 3/3] xen: share start flags between PV and PVH Roger Pau Monne
2018-05-09 10:21 ` Roger Pau Monne
2018-05-09 16:34   ` kbuild test robot
2018-05-09 16:34   ` kbuild test robot
2018-05-09 21:47   ` Stefano Stabellini
2018-05-09 21:47   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180509102129.14832-3-roger.pau@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.