From: Antonio Ospite <ao2@ao2.it>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
Antonio Ospite <ao2@ao2.it>
Subject: [PATCH] wrap-for-bin.sh: facilitate running Git executables under valgrind
Date: Wed, 9 May 2018 15:28:58 +0200 [thread overview]
Message-ID: <20180509132858.21936-1-ao2@ao2.it> (raw)
Testing locally built git executables under valgrind is not immediate.
Something like the following does not work:
$ valgrind ./bin-wrappers/git
because the wrapper script forks and execs the command and valgrind does
not track children processes by default.
Something like the following may work:
$ valgrind --trace-children=yes ./bin-wrappers/git
However it's counterintuitive and not ideal anyways because valgrind is
supposed to be called on the actual executable, not on wrapper scripts.
So, following the idea from commit 6a94088cc ("test: facilitate
debugging Git executables in tests with gdb", 2015-10-30) provide
a mechanism in the wrapper script to call valgrind directly on the
actual executable.
This mechanism could even be used by the test infrastructure in the
future, but it is already useful by its own on the command line:
$ GIT_TEST_VALGRIND=1 \
GIT_VALGRIND_OPTIONS="--leak-check=full" \
./bin-wrappers/git
Signed-off-by: Antonio Ospite <ao2@ao2.it>
---
wrap-for-bin.sh | 4 ++++
1 file changed, 4 insertions(+)
mode change 100644 => 100755 wrap-for-bin.sh
diff --git a/wrap-for-bin.sh b/wrap-for-bin.sh
old mode 100644
new mode 100755
index 584240881..502d567bd
--- a/wrap-for-bin.sh
+++ b/wrap-for-bin.sh
@@ -24,6 +24,10 @@ if test -n "$GIT_TEST_GDB"
then
unset GIT_TEST_GDB
exec gdb --args "${GIT_EXEC_PATH}/@@PROG@@" "$@"
+elif test -n "$GIT_TEST_VALGRIND"
+then
+ unset GIT_TEST_VALGRIND
+ exec valgrind $GIT_VALGRIND_OPTIONS "${GIT_EXEC_PATH}/@@PROG@@" "$@"
else
exec "${GIT_EXEC_PATH}/@@PROG@@" "$@"
fi
--
2.17.0
next reply other threads:[~2018-05-09 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 13:28 Antonio Ospite [this message]
2018-05-09 14:49 ` [PATCH] wrap-for-bin.sh: facilitate running Git executables under valgrind Jeff King
2018-05-09 15:25 ` Elijah Newren
2018-05-09 15:56 ` Antonio Ospite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509132858.21936-1-ao2@ao2.it \
--to=ao2@ao2.it \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.