From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 5/6] fm10k: warn if the stat size is unknown
Date: Wed, 9 May 2018 11:10:10 -0700 [thread overview]
Message-ID: <20180509181011.30907-6-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20180509181011.30907-1-jeffrey.t.kirsher@intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
index 09fa1a30ee3e..7657daa27298 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
@@ -248,6 +248,8 @@ static void __fm10k_add_ethtool_stats(u64 **data, void *pointer,
*((*data)++) = *(u8 *)p;
break;
default:
+ WARN_ONCE(1, "unexpected stat size for %s",
+ stats[i].stat_string);
*((*data)++) = 0;
}
}
--
2.17.0
next prev parent reply other threads:[~2018-05-09 18:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 18:10 [net-next v2 0/6][pull request] 100GbE Intel Wired LAN Driver Updates 2018-05-09 Jeff Kirsher
2018-05-09 18:10 ` [net-next v2 1/6] fm10k: setup VLANs for l2 accelerated macvlan interfaces Jeff Kirsher
2018-05-09 18:10 ` [net-next v2 2/6] fm10k: reduce duplicate fm10k_stat macro code Jeff Kirsher
2018-05-09 18:10 ` [net-next v2 3/6] fm10k: use variadic arguments to fm10k_add_stat_strings Jeff Kirsher
2018-05-09 18:10 ` [net-next v2 4/6] fm10k: use macro to avoid passing the array and size separately Jeff Kirsher
2018-05-09 18:10 ` Jeff Kirsher [this message]
2018-05-09 18:10 ` [net-next v2 6/6] fm10k: don't protect fm10k_queue_mac_request by fm10k_host_mbx_ready Jeff Kirsher
2018-05-10 21:31 ` [net-next v2 0/6][pull request] 100GbE Intel Wired LAN Driver Updates 2018-05-09 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509181011.30907-6-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.