All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: a.zummo@towertech.it, alexandre.belloni@bootlin.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Giulio Benetti <giulio.benetti@micronovasrl.com>
Subject: [PATCH v2 4/4] rtc: ds1307: add freq_test sysfs attribute to check tick on m41txx
Date: Wed,  9 May 2018 20:28:12 +0200	[thread overview]
Message-ID: <20180509182812.17646-4-giulio.benetti@micronovasrl.com> (raw)
In-Reply-To: <20180509182812.17646-1-giulio.benetti@micronovasrl.com>

On m41txx you can enable open-drain OUT pin to check if offset is ok.
Enabling OUT pin with freq_test attribute, OUT pin will tick 512 times
faster than 1s tick base.

Enable or Disable FT bit on CONTROL register if freq_test is 1 or 0.

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
V1 => V2: change frequency test from dt property to dev sysfs attribute
 drivers/rtc/rtc-ds1307.c | 86 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 86 insertions(+)

diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 33895668b363..da71000101da 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -1042,6 +1042,67 @@ static int m41txx_rtc_set_offset(struct device *dev, long offset)
 	return regmap_write(ds1307->regmap, M41TXX_REG_CONTROL,	ctrl_reg);
 }
 
+static ssize_t freq_test_store(struct device *dev,
+			       struct device_attribute *attr,
+			       const char *buf, size_t count)
+{
+	struct ds1307 *ds1307 = dev_get_drvdata(dev);
+	unsigned long freq_test = 0;
+	unsigned int ctrl_reg;
+	int retval;
+
+	retval = kstrtoul(buf, 10, &freq_test);
+	if ((retval < 0) || (retval > 1)) {
+		dev_err(dev, "Failed to store RTC Frequency Test attribute\n");
+		return -EINVAL;
+	}
+
+	regmap_read(ds1307->regmap, M41TXX_REG_CONTROL, &ctrl_reg);
+
+	if (freq_test)
+		ctrl_reg |= M41TXX_BIT_FT;
+	else
+		ctrl_reg &= ~M41TXX_BIT_FT;
+
+	retval = regmap_write(ds1307->regmap, M41TXX_REG_CONTROL, ctrl_reg);
+
+	return retval ? retval : count;
+}
+
+static ssize_t freq_test_show(struct device *dev,
+				    struct device_attribute *attr, char *buf)
+{
+	struct ds1307 *ds1307 = dev_get_drvdata(dev);
+	int freq_test = 0;
+	unsigned int ctrl_reg;
+
+	regmap_read(ds1307->regmap, M41TXX_REG_CONTROL, &ctrl_reg);
+
+	if (ctrl_reg & M41TXX_BIT_FT)
+		freq_test = true;
+	else
+		freq_test = false;
+
+	if ((freq_test < 0) || (freq_test > 1)) {
+		dev_err(dev, "Failed to read RTC Frequency Test\n");
+		sprintf(buf, "0\n");
+		return freq_test;
+	}
+
+	return sprintf(buf, "%d\n", freq_test);
+}
+
+static DEVICE_ATTR_RW(freq_test);
+
+static struct attribute *rtc_calib_attrs[] = {
+	&dev_attr_freq_test.attr,
+	NULL,
+};
+
+static const struct attribute_group rtc_calib_attr_group = {
+	.attrs		= rtc_calib_attrs,
+};
+
 /*----------------------------------------------------------------------*/
 
 static int ds1307_nvram_read(void *priv, unsigned int offset, void *val,
@@ -1455,6 +1516,13 @@ static const struct regmap_config regmap_config = {
 	.val_bits = 8,
 };
 
+static void rtc_calib_remove_sysfs_group(void *_dev)
+{
+	struct device *dev = _dev;
+
+	sysfs_remove_group(&dev->kobj, &rtc_calib_attr_group);
+}
+
 static int ds1307_probe(struct i2c_client *client,
 			const struct i2c_device_id *id)
 {
@@ -1783,6 +1851,24 @@ static int ds1307_probe(struct i2c_client *client,
 	if (err)
 		return err;
 
+	/* Export sysfs entries */
+	err = sysfs_create_group(&(&client->dev)->kobj, &rtc_calib_attr_group);
+	if (err) {
+		dev_err(&client->dev, "Failed to create sysfs group: %d\n",
+			err);
+		return err;
+	}
+
+	err = devm_add_action_or_reset(&client->dev,
+				       rtc_calib_remove_sysfs_group,
+				       &client->dev);
+	if (err) {
+		dev_err(&client->dev,
+			"Failed to add sysfs cleanup action: %d\n",
+			err);
+		return err;
+	}
+
 	if (chip->nvram_size) {
 		struct nvmem_config nvmem_cfg = {
 			.name = "ds1307_nvram",
-- 
2.17.0

  parent reply	other threads:[~2018-05-09 18:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 18:28 [PATCH v2 1/4] rtc: ds1307: fix data pointer to m41t0 Giulio Benetti
2018-05-09 18:28 ` [PATCH v2 2/4] rtc: ds1307: support m41t11 variant Giulio Benetti
2018-05-09 18:28 ` [PATCH v2 3/4] rtc: ds1307: add offset sysfs for mt41txx chips Giulio Benetti
2018-05-09 18:28 ` Giulio Benetti [this message]
2018-05-09 18:46   ` [PATCH v2 4/4] rtc: ds1307: add freq_test sysfs attribute to check tick on m41txx Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180509182812.17646-4-giulio.benetti@micronovasrl.com \
    --to=giulio.benetti@micronovasrl.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.