From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [RFC] drm/i915/dp: optimize eDP 1.4+ link config fast and narrow Date: Wed, 9 May 2018 11:58:14 -0700 Message-ID: <20180509185814.GA980@intel.com> References: <20180509071321.28563-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1DF2D6E75D for ; Wed, 9 May 2018 18:55:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180509071321.28563-1-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXkgMDksIDIwMTggYXQgMTA6MTM6MjFBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gV2UndmUgb3B0ZWQgdG8gdXNlIHRoZSBtYXhpbXVtIGxpbmsgcmF0ZSBhbmQgbGFuZSBj b3VudCBmb3IgZURQIHBhbmVscywKPiBiZWNhdXNlIHR5cGljYWxseSB0aGUgbWF4aW11bSBzdXBw b3J0ZWQgY29uZmlndXJhdGlvbiByZXBvcnRlZCBieSB0aGUKPiBwYW5lbCBoYXMgbWF0Y2hlZCB0 aGUgbmF0aXZlIHJlc29sdXRpb24gcmVxdWlyZW1lbnRzIG9mIHRoZSBwYW5lbCwgYW5kCj4gb3B0 aW1pemluZyB0aGUgbGluayBoYXMgbGVhZCB0byBwcm9ibGVtcy4KPiAKPiBXaXRoIGVEUCAxLjQg cmF0ZSBzZWxlY3QgbWV0aG9kIGFuZCBEU0MgZmVhdHVyZXMsIHRoaXMgaXMgZGVjcmVhc2luZ2x5 Cj4gdGhlIGNhc2UuIFRoZXJlJ3MgYSBuZWVkIHRvIG9wdGltaXplIHRoZSBsaW5rIHBhcmFtZXRl cnMuIE1vcmVvdmVyLAo+IGFscmVhZHkgZURQIDEuMyBzdGF0ZXMgZmFzdCBsaW5rIHdpdGggZmV3 ZXIgbGFuZXMgaXMgcHJlZmVycmVkIG92ZXIgdGhlCj4gd2lkZSBhbmQgc2xvdy4gKFdpZGUgYW5k IHNsb3cgc2hvdWxkIHN0aWxsIGJlIG1vcmUgcmVsaWFibGUgZm9yIGxvbmdlcgo+IGNhYmxlIGxl bmd0aHMuKQo+IAo+IEFkZGl0aW9uYWxseSwgdGhlcmUgaGF2ZSBiZWVuIHJlcG9ydHMgb2YgcGFu ZWxzIGZhaWxpbmcgb24gYXJiaXRyYXJ5Cj4gbGluayBjb25maWd1cmF0aW9ucywgYWx0aG91Z2gg YXJndWFibHkgYWxsIGNvbmZpZ3VyYXRpb25zIHRoZXkgY2xhaW0gdG8KPiBzdXBwb3J0IHNob3Vs ZCB3b3JrLgo+IAo+IE9wdGltaXplIGVEUCAxLjQrIGxpbmsgY29uZmlnIGZhc3QgYW5kIG5hcnJv dy4KPiAKPiBTaWRlIG5vdGU6IFRoZSBpbXBsZW1lbnRhdGlvbiBoYXMgYSBuZWFyIGR1cGxpY2F0 ZSBvZiB0aGUgbGluayBjb25maWcKPiBmdW5jdGlvbiwgd2l0aCBqdXN0IHRoZSB0d28gaW5uZXIg Zm9yIGxvb3BzIHR1cm5lZCBpbnNpZGUgb3V0LiBQZXJoYXBzCj4gdGhlcmUnZCBiZSBhIHdheSB0 byBtYWtlIHRoaXMsIHNheSwgbW9yZSB0YWJsZSBkcml2ZW4gdG8gcmVkdWNlIHRoZQo+IGR1cGxp Y2F0aW9uLCBidXQgc2VlbXMgbGlrZSB0aGF0IHdvdWxkIGxlYWQgdG8gZHVwbGljYXRpb24gaW4g dGhlIHRhYmxlCj4gZ2VuZXJhdGlvbi4gV2UnbGwgYWxzbyBoYXZlIHRvIHNlZSBob3cgdGhlIGxp bmsgY29uZmlnIG9wdGltaXphdGlvbiBmb3IKPiBEU0MgdHVybnMgb3V0LgoKWWVzIGZvciBEU0Mg Zm9yIGVEUCB3ZSBjdXJyZW50bHkgdHJ5IGZhc3QgYW5kIHdpZGUgYW5kIGlmIHRoYXQgZG9lc250 CmZpdCB0aGUgcmVxdWVzdGVkIG1vZGUgdGhlbiB3ZSBlbmFibGUgRFNDLgpOb3cgd2l0aCB0aGUg ZmFzdCBhbmQgbmFycm93IGFwcHJvYWNoLCBhZ2FpbiBmb3IgcG93ZXIgc2F2aW5ncyB3ZSBjYW4g dHJ5CnRoZSBmYXN0ZXN0IGxpbmsgcmF0ZSB3aXRoIG5hcnJvd2VzdCBsYW5lIGNvdW50IGFuZCBz ZWUgaWYgRFNDIGNhbiBiZSBlbmFibGVkCnRoZXJlIGJlZm9yZSBpbmNyZWFzaW5nIHRoZSBsYW5l IGNvdW50LiBCdXQgYW55d2F5cyB0aGF0IGNhbGxzIGZvciBhIHNlcGFyYXRlCm9wdGltaXphdGlv biBkaXNjdXNzaW9uLgoKT3RoZXJ3aXNlIHllcyB0aGlzIG1ldGhvZCBsb29rcyBjb3JyZWN0IGFz IHBlciBlRFAgMS40IHNwZWMuCgo+IAo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgo+IENjOiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVA aW50ZWwuY29tPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4g QnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NTI2Nwo+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+ Cj4gCj4gLS0tCj4gCj4gVW50ZXN0ZWQuIEl0J3MgcG9zc2libGUgdGhpcyBoZWxwcyB0aGUgcmVm ZXJlbmNlZCBidWcuIFRoZSBkb3duc2lkZSBpcwo+IHRoYXQgdGhpcyBwYXRjaCBoYXMgYSBidW5j aCBvZiBkZXBlbmRlbmNpZXMgdGhhdCBhcmUgdG9vIG11Y2ggdG8KPiBiYWNrcG9ydCB0byBzdGFi bGUga2VybmVscy4gSWYgdGhlIHBhdGNoIHdvcmtzLCB3ZSBtYXkgbmVlZCB0byBjb25zaWRlcgo+ IGhhY2tpbmcgdG9nZXRoZXIgYW4gdWdsaWVyIGJhY2twb3J0Lgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgNzMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKy0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDYyIGluc2VydGlvbnMoKyksIDExIGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IGRkZTkyZTRhZjVkMy4u MWVjNjI5NjVlY2UzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAgLTE3NjgsNiAr MTc2OCw0MiBAQCBpbnRlbF9kcF9jb21wdXRlX2xpbmtfY29uZmlnX3dpZGUoc3RydWN0IGludGVs X2RwICppbnRlbF9kcCwKPiAgCXJldHVybiBmYWxzZTsKPiAgfQo+ICAKPiArLyogT3B0aW1pemUg bGluayBjb25maWcgaW4gb3JkZXI6IG1heCBicHAsIG1pbiBsYW5lcywgbWluIGNsb2NrICovCj4g K3N0YXRpYyBib29sCj4gK2ludGVsX2RwX2NvbXB1dGVfbGlua19jb25maWdfZmFzdChzdHJ1Y3Qg aW50ZWxfZHAgKmludGVsX2RwLAo+ICsJCQkJICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlw ZV9jb25maWcsCj4gKwkJCQkgIGNvbnN0IHN0cnVjdCBsaW5rX2NvbmZpZ19saW1pdHMgKmxpbWl0 cykKClNob3VsZCB3ZSBtYWtlIHRoZSBuYW1lIG9mIHRoaXMgZnVuY3Rpb24gaW50ZWxfZHBfY29t cHV0ZV9saW5rX2NvbmZpZ19mYXN0X25hcnJvdygpIHRvIG1ha2UgaXQKbW9yZSBpbnR1aXRpdmUg dG8gdGhlIG9wdGltaXphdGlvbiBhcHByb2FjaAoKQW5kIHdoaWxlIGF0IGl0IGNoYW5nZSB0aGUg b3RoZXIgb25lIGFsc28gdG8gX3dpZGVfc2xvdygpPwpKdXN0IGEgc3VnZ2VzdGlvbiBidXQgb3Ro ZXJ3aXNlIGV2ZXJ5dGhpbmcgZWxzZSBMR1RNLgoKUmVnYXJkcwpNYW5hc2kKCj4gK3sKPiArCXN0 cnVjdCBkcm1fZGlzcGxheV9tb2RlICphZGp1c3RlZF9tb2RlID0gJnBpcGVfY29uZmlnLT5iYXNl LmFkanVzdGVkX21vZGU7Cj4gKwlpbnQgYnBwLCBjbG9jaywgbGFuZV9jb3VudDsKPiArCWludCBt b2RlX3JhdGUsIGxpbmtfY2xvY2ssIGxpbmtfYXZhaWw7Cj4gKwo+ICsJZm9yIChicHAgPSBsaW1p dHMtPm1heF9icHA7IGJwcCA+PSBsaW1pdHMtPm1pbl9icHA7IGJwcCAtPSAyICogMykgewo+ICsJ CW1vZGVfcmF0ZSA9IGludGVsX2RwX2xpbmtfcmVxdWlyZWQoYWRqdXN0ZWRfbW9kZS0+Y3J0Y19j bG9jaywKPiArCQkJCQkJICAgYnBwKTsKPiArCj4gKwkJZm9yIChsYW5lX2NvdW50ID0gbGltaXRz LT5taW5fbGFuZV9jb3VudDsKPiArCQkgICAgIGxhbmVfY291bnQgPD0gbGltaXRzLT5tYXhfbGFu ZV9jb3VudDsKPiArCQkgICAgIGxhbmVfY291bnQgPDw9IDEpIHsKPiArCQkJZm9yIChjbG9jayA9 IGxpbWl0cy0+bWluX2Nsb2NrOyBjbG9jayA8PSBsaW1pdHMtPm1heF9jbG9jazsgY2xvY2srKykg ewo+ICsJCQkJbGlua19jbG9jayA9IGludGVsX2RwLT5jb21tb25fcmF0ZXNbY2xvY2tdOwo+ICsJ CQkJbGlua19hdmFpbCA9IGludGVsX2RwX21heF9kYXRhX3JhdGUobGlua19jbG9jaywKPiArCQkJ CQkJCQkgICAgbGFuZV9jb3VudCk7Cj4gKwo+ICsJCQkJaWYgKG1vZGVfcmF0ZSA8PSBsaW5rX2F2 YWlsKSB7Cj4gKwkJCQkJcGlwZV9jb25maWctPmxhbmVfY291bnQgPSBsYW5lX2NvdW50Owo+ICsJ CQkJCXBpcGVfY29uZmlnLT5waXBlX2JwcCA9IGJwcDsKPiArCQkJCQlwaXBlX2NvbmZpZy0+cG9y dF9jbG9jayA9IGxpbmtfY2xvY2s7Cj4gKwo+ICsJCQkJCXJldHVybiB0cnVlOwo+ICsJCQkJfQo+ ICsJCQl9Cj4gKwkJfQo+ICsJfQo+ICsKPiArCXJldHVybiBmYWxzZTsKPiArfQo+ICsKPiAgc3Rh dGljIGJvb2wKPiAgaW50ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZW5j b2RlciAqZW5jb2RlciwKPiAgCQkJICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9j b25maWcpCj4gQEAgLTE3OTIsMTMgKzE4MjgsMTUgQEAgaW50ZWxfZHBfY29tcHV0ZV9saW5rX2Nv bmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCWxpbWl0cy5taW5fYnBwID0g NiAqIDM7Cj4gIAlsaW1pdHMubWF4X2JwcCA9IGludGVsX2RwX2NvbXB1dGVfYnBwKGludGVsX2Rw LCBwaXBlX2NvbmZpZyk7Cj4gIAo+IC0JaWYgKGludGVsX2RwX2lzX2VkcChpbnRlbF9kcCkpIHsK PiArCWlmIChpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApICYmIGludGVsX2RwLT5lZHBfZHBjZFsw XSA8IERQX0VEUF8xNCkgewo+ICAJCS8qCj4gIAkJICogVXNlIHRoZSBtYXhpbXVtIGNsb2NrIGFu ZCBudW1iZXIgb2YgbGFuZXMgdGhlIGVEUCBwYW5lbAo+IC0JCSAqIGFkdmVydGl6ZXMgYmVpbmcg Y2FwYWJsZSBvZi4gVGhlIHBhbmVscyBhcmUgZ2VuZXJhbGx5Cj4gLQkJICogZGVzaWduZWQgdG8g c3VwcG9ydCBvbmx5IGEgc2luZ2xlIGNsb2NrIGFuZCBsYW5lCj4gLQkJICogY29uZmlndXJhdGlv biwgYW5kIHR5cGljYWxseSB0aGVzZSB2YWx1ZXMgY29ycmVzcG9uZCB0byB0aGUKPiAtCQkgKiBu YXRpdmUgcmVzb2x1dGlvbiBvZiB0aGUgcGFuZWwuCj4gKwkJICogYWR2ZXJ0aXplcyBiZWluZyBj YXBhYmxlIG9mLiBUaGUgZURQIDEuMyBhbmQgZWFybGllciBwYW5lbHMKPiArCQkgKiBhcmUgZ2Vu ZXJhbGx5IGRlc2lnbmVkIHRvIHN1cHBvcnQgb25seSBhIHNpbmdsZSBjbG9jayBhbmQKPiArCQkg KiBsYW5lIGNvbmZpZ3VyYXRpb24sIGFuZCB0eXBpY2FsbHkgdGhlc2UgdmFsdWVzIGNvcnJlc3Bv bmQgdG8KPiArCQkgKiB0aGUgbmF0aXZlIHJlc29sdXRpb24gb2YgdGhlIHBhbmVsLiBXaXRoIGVE UCAxLjQgcmF0ZSBzZWxlY3QKPiArCQkgKiBhbmQgRFNDLCB0aGlzIGlzIGRlY3JlYXNpbmdseSB0 aGUgY2FzZSwgYW5kIHdlIG5lZWQgdG8gYmUKPiArCQkgKiBhYmxlIHRvIHNlbGVjdCBsZXNzIHRo YW4gbWF4aW11bSBsaW5rIGNvbmZpZy4KPiAgCQkgKi8KPiAgCQlsaW1pdHMubWluX2xhbmVfY291 bnQgPSBsaW1pdHMubWF4X2xhbmVfY291bnQ7Cj4gIAkJbGltaXRzLm1pbl9jbG9jayA9IGxpbWl0 cy5tYXhfY2xvY2s7Cj4gQEAgLTE4MTIsMTIgKzE4NTAsMjUgQEAgaW50ZWxfZHBfY29tcHV0ZV9s aW5rX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCQkgICAgICBpbnRl bF9kcC0+Y29tbW9uX3JhdGVzW2xpbWl0cy5tYXhfY2xvY2tdLAo+ICAJCSAgICAgIGxpbWl0cy5t YXhfYnBwLCBhZGp1c3RlZF9tb2RlLT5jcnRjX2Nsb2NrKTsKPiAgCj4gLQkvKgo+IC0JICogT3B0 aW1pemUgZm9yIHNsb3cgYW5kIHdpZGUuIFRoaXMgaXMgdGhlIHBsYWNlIHRvIGFkZCBhbHRlcm5h dGl2ZQo+IC0JICogb3B0aW1pemF0aW9uIHBvbGljeS4KPiAtCSAqLwo+IC0JaWYgKCFpbnRlbF9k cF9jb21wdXRlX2xpbmtfY29uZmlnX3dpZGUoaW50ZWxfZHAsIHBpcGVfY29uZmlnLCAmbGltaXRz KSkKPiAtCQlyZXR1cm4gZmFsc2U7Cj4gKwlpZiAoaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSkg ewo+ICsJCS8qCj4gKwkJICogT3B0aW1pemUgZm9yIGZhc3QgYW5kIG5hcnJvdy4gZURQIDEuMyBz ZWN0aW9uIDMuMyBhbmQgZURQIDEuNAo+ICsJCSAqIHNlY3Rpb24gQS4xOiAiSXQgaXMgcmVjb21t ZW5kZWQgdGhhdCB0aGUgbWluaW11bSBudW1iZXIgb2YKPiArCQkgKiBsYW5lcyBiZSB1c2VkLCB1 c2luZyB0aGUgbWluaW11bSBsaW5rIHJhdGUgYWxsb3dlZCBmb3IgdGhhdAo+ICsJCSAqIGxhbmUg Y29uZmlndXJhdGlvbi4iCj4gKwkJICoKPiArCQkgKiBOb3RlIHRoYXQgd2UgdXNlIHRoZSBtYXgg Y2xvY2sgYW5kIGxhbmUgY291bnQgZm9yIGVEUCAxLjMgYW5kCj4gKwkJICogZWFybGllciwgYW5k IGZhc3QgdnMuIHdpZGUgaXMgaXJyZWxldmFudC4KPiArCQkgKi8KPiArCQlpZiAoIWludGVsX2Rw X2NvbXB1dGVfbGlua19jb25maWdfZmFzdChpbnRlbF9kcCwgcGlwZV9jb25maWcsCj4gKwkJCQkJ CSAgICAgICAmbGltaXRzKSkKPiArCQkJcmV0dXJuIGZhbHNlOwo+ICsJfSBlbHNlIHsKPiArCQkv KiBPcHRpbWl6ZSBmb3Igc2xvdyBhbmQgd2lkZS4gKi8KPiArCQlpZiAoIWludGVsX2RwX2NvbXB1 dGVfbGlua19jb25maWdfd2lkZShpbnRlbF9kcCwgcGlwZV9jb25maWcsCj4gKwkJCQkJCSAgICAg ICAmbGltaXRzKSkKPiArCQkJcmV0dXJuIGZhbHNlOwo+ICsJfQo+ICAKPiAgCURSTV9ERUJVR19L TVMoIkRQIGxhbmUgY291bnQgJWQgY2xvY2sgJWQgYnBwICVkXG4iLAo+ICAJCSAgICAgIHBpcGVf Y29uZmlnLT5sYW5lX2NvdW50LCBwaXBlX2NvbmZpZy0+cG9ydF9jbG9jaywKPiAtLSAKPiAyLjEx LjAKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==