All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tariqt@mellanox.com
Cc: netdev@vger.kernel.org, eranbe@mellanox.com, moshe@mellanox.com
Subject: Re: [PATCH net] net/mlx4_en: Verify coalescing parameters are in range
Date: Thu, 10 May 2018 16:09:57 -0400 (EDT)	[thread overview]
Message-ID: <20180510.160957.1777491913531231884.davem@davemloft.net> (raw)
In-Reply-To: <1525880113-2757-1-git-send-email-tariqt@mellanox.com>

From: Tariq Toukan <tariqt@mellanox.com>
Date: Wed,  9 May 2018 18:35:13 +0300

> From: Moshe Shemesh <moshe@mellanox.com>
> 
> Add check of coalescing parameters received through ethtool are within
> range of values supported by the HW.
> Driver gets the coalescing rx/tx-usecs and rx/tx-frames as set by the
> users through ethtool. The ethtool support up to 32 bit value for each.
> However, mlx4 modify cq limits the coalescing time parameter and
> coalescing frames parameters to 16 bits.
> Return out of range error if user tries to set these parameters to
> higher values.
> Change type of sample-interval and adaptive_rx_coal parameters in mlx4
> driver to u32 as the ethtool holds them as u32 and these parameters are
> not limited due to mlx4 HW.
> 
> Fixes: c27a02cd94d6 ('mlx4_en: Add driver for Mellanox ConnectX 10GbE NIC')
> Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>

Applied and queued up for -stable.

      reply	other threads:[~2018-05-10 20:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 15:35 [PATCH net] net/mlx4_en: Verify coalescing parameters are in range Tariq Toukan
2018-05-10 20:09 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180510.160957.1777491913531231884.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eranbe@mellanox.com \
    --cc=moshe@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=tariqt@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.