From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Greg KH <gregkh@linuxfoundation.org>,
David Laight <David.Laight@ACULAB.COM>,
damian <damian.tometzki@icloud.com>
Subject: Re: [PATCH 3/3] objtool: Support GCC 8 switch tables
Date: Thu, 10 May 2018 10:41:25 +0200 [thread overview]
Message-ID: <20180510084125.GY12217@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <60ba92277204856ced0723f7d7ca52c691baace3.1525923412.git.jpoimboe@redhat.com>
On Wed, May 09, 2018 at 10:39:16PM -0500, Josh Poimboeuf wrote:
> Add some additional checks to the switch jump table logic. This fixes
> the following warnings with GCC 8:
>
> drivers/block/virtio_blk.o: warning: objtool: virtio_queue_rq()+0x0: stack state mismatch: cfa1=7+8 cfa2=7+72
> net/ipv6/icmp.o: warning: objtool: icmpv6_rcv()+0x0: stack state mismatch: cfa1=7+8 cfa2=7+64
> drivers/usb/core/quirks.o: warning: objtool: quirks_param_set()+0x0: stack state mismatch: cfa1=7+8 cfa2=7+48
> drivers/mtd/nand/raw/nand_hynix.o: warning: objtool: hynix_nand_decode_id()+0x0: stack state mismatch: cfa1=7+8 cfa2=7+24
> drivers/mtd/nand/raw/nand_samsung.o: warning: objtool: samsung_nand_decode_id()+0x0: stack state mismatch: cfa1=7+8 cfa2=7+32
> drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.o: warning: objtool: gk104_top_oneinit()+0x0: stack state mismatch: cfa1=7+8 cfa2=7+64
Could you maybe detail how the GCC8 switch tables are different? And
thus what needed fixing?
next prev parent reply other threads:[~2018-05-10 8:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 3:39 [PATCH 0/3] objtool: GCC 8 support Josh Poimboeuf
2018-05-10 3:39 ` [PATCH 1/3] objtool: Fix "noreturn" detection for recursive sibling calls Josh Poimboeuf
2018-05-14 12:37 ` [tip:core/urgent] " tip-bot for Josh Poimboeuf
2018-05-10 3:39 ` [PATCH 2/3] objtool: Support GCC 8 cold subfunctions Josh Poimboeuf
2018-05-14 12:37 ` [tip:core/urgent] objtool: Support GCC 8's " tip-bot for Josh Poimboeuf
2018-05-10 3:39 ` [PATCH 3/3] objtool: Support GCC 8 switch tables Josh Poimboeuf
2018-05-10 8:41 ` Peter Zijlstra [this message]
2018-05-10 12:44 ` [PATCH v1.1 " Josh Poimboeuf
2018-05-10 14:07 ` Peter Zijlstra
2018-05-10 22:45 ` [PATCH v1.2 " Josh Poimboeuf
2018-05-10 22:48 ` [PATCH v1.3 " Josh Poimboeuf
2018-05-14 12:38 ` [tip:core/urgent] " tip-bot for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510084125.GY12217@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=David.Laight@ACULAB.COM \
--cc=arnd@arndb.de \
--cc=damian.tometzki@icloud.com \
--cc=gregkh@linuxfoundation.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.