Re: printk feature for syzbot?

[Petr Mladek <pmladek@suse.com>]

On Thu 2018-05-10 13:22:06, Sergey Senozhatsky wrote:
> On (04/26/18 12:06), Petr Mladek wrote:
> > 
> > > Petr, Steven, Fengguang, what do you think? Do you have any objections?
> > > Ideas?
> > 
> > I wonder if we could create some mechanism that would help to extend
> > struct printk_log easier in the future.
> 
> Hm, interesting idea.
> 
> > I know only about crash tool implementation. It uses information provided
> > by log_buf_vmcoreinfo_setup(). The size of the structure is already
> > public. Therefore crash should be able to find all existing information
> > even if we increase the size of the structure.
> > 
> > log_buf_vmcoreinfo_setup() even allows to inform about newly added
> > structure items. We could probably extend it to inform also about
> > the offset of the new optional elements.
> 
> I vaguely remember that the last time Thomas Gleixner modified
> printk_log you managed to find a case that broke crash tool.
> ... Or may be I'm mistaken.

I guess that you are talking about the patchset adding possibility
to use different time-stamps[1]. It changed the semantic of the
timestamp. All the tools needed an update to show the timestamp
correctly.

The patchset was rejected by Linus because it would broke some
userspace tool, e.g. systemd, that depend on the format and semantic
provided by /dev/kmsg[2].

By other words, we must not change /dev/kmsg format. But it should
be acceptable to change/extend the internal format and eventually
extend the format used on consoles.

Anyway, we need to be careful and test makedumpfile and crash tools
and eventually provide patches for them.

Reference:
[0] https://lkml.kernel.org/r/20160419085613.GJ6862@pathway.suse.cz
[1] https://lkml.kernel.org/r/CA+55aFzLH9crdMtUFkD-PtNGuxu_fsG5GH2ACni69ug9iM=09g@mail.gmail.com

Best Regards,
Petr