From: Pavel Machek <pavel@ucw.cz>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Dan Murphy <dmurphy@ti.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
jacek.anaszewski@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 2/2] leds: lm3601x: Introduce the lm3601x LED driver
Date: Thu, 10 May 2018 20:39:22 +0200 [thread overview]
Message-ID: <20180510183922.GA12846@amd> (raw)
In-Reply-To: <7832225b-115c-2316-025e-29929cd4f208@ti.com>
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
Hi!
> >> Plus, removing the driver is not a command to disable the LED anyway.
> >
> > True but you don't want to leave any LEDs in the on state without a driver to support it.
> > This could burn out the LED or the board if left on on max brightness
>
> I disagree, we should not try to decide what the user wants here. We
> should only do what we are instructed to do, which for remove() is to
> cleanup what probe has done so the driver can be removed w/o leaking
> memory or device state.
We normally powerdown on rmmod. We should do that here, too.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2018-05-10 18:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 12:27 [PATCH v4 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver Dan Murphy
2018-05-10 12:27 ` Dan Murphy
2018-05-10 12:27 ` [PATCH v4 2/2] leds: lm3601x: Introduce the lm3601x LED driver Dan Murphy
2018-05-10 12:27 ` Dan Murphy
2018-05-10 13:44 ` Andrew F. Davis
2018-05-10 13:44 ` Andrew F. Davis
2018-05-10 14:04 ` Dan Murphy
2018-05-10 14:04 ` Dan Murphy
2018-05-10 14:31 ` Andrew F. Davis
2018-05-10 14:31 ` Andrew F. Davis
2018-05-10 15:16 ` Dan Murphy
2018-05-10 15:16 ` Dan Murphy
2018-05-10 18:39 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510183922.GA12846@amd \
--to=pavel@ucw.cz \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.