From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192AbeEKNpX (ORCPT ); Fri, 11 May 2018 09:45:23 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:40912 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752974AbeEKNpV (ORCPT ); Fri, 11 May 2018 09:45:21 -0400 Date: Fri, 11 May 2018 15:45:16 +0200 From: Simon Horman To: Niklas =?utf-8?Q?S=C3=B6derlund?= Cc: Jacopo Mondi , laurent.pinchart@ideasonboard.com, geert@glider.be, magnus.damm@gmail.com, robh+dt@kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a77995: Add VIN4 Message-ID: <20180511134516.omsv25i2wi4cxypc@verge.net.au> References: <1526032802-14376-1-git-send-email-jacopo+renesas@jmondi.org> <1526032802-14376-3-git-send-email-jacopo+renesas@jmondi.org> <20180511112523.GK18974@bigcity.dyn.berto.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180511112523.GK18974@bigcity.dyn.berto.se> Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 11, 2018 at 01:25:23PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-11 12:00:01 +0200, Jacopo Mondi wrote: > > Describe VIN4 interface for R-Car D3 R8A77995 SoC. > > > > Signed-off-by: Jacopo Mondi > > Acked-by: Niklas Söderlund > > > --- > > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > > index 82aed7e..bdf7017 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > > @@ -783,6 +783,17 @@ > > }; > > }; > > }; > > + > > + vin4: video@e6ef4000 { > > + compatible = "renesas,vin-r8a77995"; > > + reg = <0 0xe6ef4000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 807>; > > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > > + resets = <&cpg 807>; > > + renesas,id = <4>; > > + status = "disabled"; > > + }; > > }; Thanks, I have moved the new node to preserve sorting of nodes by bus address and applied the result. It is as follows: From: Jacopo Mondi Subject: [PATCH] arm64: dts: renesas: r8a77995: Add VIN4 Describe VIN4 interface for R-Car D3 R8A77995 SoC. Signed-off-by: Jacopo Mondi Acked-by: Niklas Söderlund [simon: sorted node by bus address] Signed-off-by: Simon Horman --- arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index ba98865b0c9b..2506f46293e8 100644 --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi @@ -610,6 +610,17 @@ status = "disabled"; }; + vin4: video@e6ef4000 { + compatible = "renesas,vin-r8a77995"; + reg = <0 0xe6ef4000 0 0x1000>; + interrupts = ; + clocks = <&cpg CPG_MOD 807>; + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; + resets = <&cpg 807>; + renesas,id = <4>; + status = "disabled"; + }; + ohci0: usb@ee080000 { compatible = "generic-ohci"; reg = <0 0xee080000 0 0x100>; -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Fri, 11 May 2018 15:45:16 +0200 Subject: [PATCH 2/3] arm64: dts: renesas: r8a77995: Add VIN4 In-Reply-To: <20180511112523.GK18974@bigcity.dyn.berto.se> References: <1526032802-14376-1-git-send-email-jacopo+renesas@jmondi.org> <1526032802-14376-3-git-send-email-jacopo+renesas@jmondi.org> <20180511112523.GK18974@bigcity.dyn.berto.se> Message-ID: <20180511134516.omsv25i2wi4cxypc@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, May 11, 2018 at 01:25:23PM +0200, Niklas S?derlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-11 12:00:01 +0200, Jacopo Mondi wrote: > > Describe VIN4 interface for R-Car D3 R8A77995 SoC. > > > > Signed-off-by: Jacopo Mondi > > Acked-by: Niklas S?derlund > > > --- > > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > > index 82aed7e..bdf7017 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > > @@ -783,6 +783,17 @@ > > }; > > }; > > }; > > + > > + vin4: video at e6ef4000 { > > + compatible = "renesas,vin-r8a77995"; > > + reg = <0 0xe6ef4000 0 0x1000>; > > + interrupts = ; > > + clocks = <&cpg CPG_MOD 807>; > > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > > + resets = <&cpg 807>; > > + renesas,id = <4>; > > + status = "disabled"; > > + }; > > }; Thanks, I have moved the new node to preserve sorting of nodes by bus address and applied the result. It is as follows: From: Jacopo Mondi Subject: [PATCH] arm64: dts: renesas: r8a77995: Add VIN4 Describe VIN4 interface for R-Car D3 R8A77995 SoC. Signed-off-by: Jacopo Mondi Acked-by: Niklas S?derlund [simon: sorted node by bus address] Signed-off-by: Simon Horman --- arch/arm64/boot/dts/renesas/r8a77995.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index ba98865b0c9b..2506f46293e8 100644 --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi @@ -610,6 +610,17 @@ status = "disabled"; }; + vin4: video at e6ef4000 { + compatible = "renesas,vin-r8a77995"; + reg = <0 0xe6ef4000 0 0x1000>; + interrupts = ; + clocks = <&cpg CPG_MOD 807>; + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; + resets = <&cpg 807>; + renesas,id = <4>; + status = "disabled"; + }; + ohci0: usb at ee080000 { compatible = "generic-ohci"; reg = <0 0xee080000 0 0x100>; -- 2.11.0