From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHI2v-0007QR-T1 for qemu-devel@nongnu.org; Fri, 11 May 2018 20:05:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHI2s-0007aR-KW for qemu-devel@nongnu.org; Fri, 11 May 2018 20:05:57 -0400 Received: from mail-it0-x242.google.com ([2607:f8b0:4001:c0b::242]:34099) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHI2s-0007aJ-EJ for qemu-devel@nongnu.org; Fri, 11 May 2018 20:05:54 -0400 Received: by mail-it0-x242.google.com with SMTP id c5-v6so3279826itj.1 for ; Fri, 11 May 2018 17:05:54 -0700 (PDT) From: Calvin Lee Date: Fri, 11 May 2018 18:05:43 -0600 Message-Id: <20180512000545.966-1-cyrus296@gmail.com> Subject: [Qemu-devel] [PATCH RFC v2 0/2] Fix UART serial implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com, pbonzini@redhat.com, dgilbert@redhat.com, Calvin Lee Hello, While developing a serial implementation for my OS, I found several bugs in QEMU's serial device. I confirmed (by testing on my x64 laptop) that there are several inconsistancies between QEMU and hardware in this regard. For both patches, I used "http://www.sci.muni.cz/docs/pc/serport.txt" for reference. First, QEMU has several errors for setting the UART divisor that are fixed in my first patch. Second, (and more importantly) QEMU does not transmit serial bytes at the correct rate, and this is fixed in my second patch. I have neither contributed to QEMU nor sent patches to a mailing list before, so I marked this patch-series as RFC. I would appreciate any comments you have. Also, I am not very confident in VM migration between versions, so I would appreciate if someone could help me make sure this is correct in my patches. v2: fix build Calvin Lee (2): PC Chipset: Improve serial divisor calculation PC Chipset: Send serial bytes at correct rate hw/char/serial.c | 74 +++++++++++++++++++++++++++++++--------- include/hw/char/serial.h | 2 ++ 2 files changed, 60 insertions(+), 16 deletions(-) -- 2.17.0