From: Eryu Guan <guaneryu@gmail.com>
To: Zorro Lang <zlang@redhat.com>
Cc: Dave Chinner <david@fromorbit.com>,
fstests@vger.kernel.org, darrick.wong@oracle.org,
sandeen@redhat.com
Subject: Re: [PATCH] xfs: limit xfs_growfs size if test with --large-fs
Date: Sat, 12 May 2018 13:53:28 +0800 [thread overview]
Message-ID: <20180512055328.GP8373@desktop> (raw)
In-Reply-To: <20180511034150.GF1963@hp-dl360g9-06.rhts.eng.pek2.redhat.com>
On Fri, May 11, 2018 at 11:41:50AM +0800, Zorro Lang wrote:
> On Fri, May 11, 2018 at 08:18:59AM +1000, Dave Chinner wrote:
> > On Fri, Apr 27, 2018 at 04:22:54PM +0800, Zorro Lang wrote:
> > > When test on large SCRATCH_DEV, grow a small XFS to huge size is a
> > > horrible thing (e.g grow 128m to 500T). So add a helper named
> > > _scratch_xfs_growfs_limited() to do below things:
> > >
> > > 1) If --large-fs is used, limit growfs size.
> > > 2) If a limit size parameter is specified, make sure growfs won't
> > > beyond this size.
> > >
> > > Signed-off-by: Zorro Lang <zlang@redhat.com>
> >
> > I think I originally just didn't run growfs tests like this on large
> > filesystems. i.e. require_no_largefs....
>
> Hmm... Sorry, am I facing different review-points from 3 different XFS maintainers? ...
>
> Dave: require_no_largefs is better.
> Darrick: nearly ack this patch.
> Eric:
> 2018-04-27 04:03 < sandeen> [15:01] <zoro> [00:55:47] I think maybe use _require_no_large_scratch_dev for xfs/002 will be better. Grow a 128M XFS to large size is 'horrible'
> 2018-04-27 04:03 < sandeen> just limit growfs to something smaller.
>
> What should I do next?
If testing on large device won't add more test coverage but only test
runtime, I'd like to just skip the tests.
Would you please send a new version of the patch that adds
_require_no_large_scratch_dev to the affected tests?
And thanks all for the comments!
Eryu
>
> Thanks,
> Zorro
>
> >
> > Cheers,
> >
> > Dave.
> >
> > --
> > Dave Chinner
> > david@fromorbit.com
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-12 5:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 8:22 [PATCH] xfs: limit xfs_growfs size if test with --large-fs Zorro Lang
2018-05-09 16:02 ` Eryu Guan
2018-05-09 16:22 ` Darrick J. Wong
2018-05-10 22:18 ` Dave Chinner
2018-05-11 3:41 ` Zorro Lang
2018-05-11 23:29 ` Dave Chinner
2018-05-12 0:15 ` Darrick J. Wong
2018-05-12 5:53 ` Eryu Guan [this message]
2018-05-12 13:19 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180512055328.GP8373@desktop \
--to=guaneryu@gmail.com \
--cc=darrick.wong@oracle.org \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.