From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] toolchain/buildroot: Fix symbol for uClibc
Date: Sun, 13 May 2018 21:19:43 +0200 [thread overview]
Message-ID: <20180513211943.6a0e19b8@windsurf.home> (raw)
In-Reply-To: <20180509163323.30172-1-petr.vorel@gmail.com>
Ricardo,
On Wed, 9 May 2018 18:33:22 +0200, Petr Vorel wrote:
> Symbol BR2_TOOLCHAIN_UCLIBC doesn't exist, it was meant to be
> BR2_TOOLCHAIN_BUILDROOT_UCLIBC.
>
> Fixes: 493b1177b9 toolchain/buildroot: default to uClibc
>
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> toolchain/toolchain-buildroot/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in
> index 2f6624d217..75e8191f46 100644
> --- a/toolchain/toolchain-buildroot/Config.in
> +++ b/toolchain/toolchain-buildroot/Config.in
> @@ -22,7 +22,7 @@ config BR2_TOOLCHAIN_BUILDROOT_VENDOR
>
> choice
> prompt "C library"
> - default BR2_TOOLCHAIN_UCLIBC
> + default BR2_TOOLCHAIN_BUILDROOT_UCLIBC
Just like I added a checker in check-package to verify automatically
the issue raised by PATCH 2/2 of Petr's series [1], I wanted to add a
checker to detect the problem raised by this patch.
My idea was to have something that:
(1) Collects options defined by "config BR2_<something>"
(2) Collects references to option, in "select", "depends on",
"default" clauses, etc.
(3) Ensures that all references to options have a matching option
definition.
However, this requires a global pass on all Config.in files to do (1)
and (2) before doing (3), and I'm not sure how this fits in the current
check-package logic, which seems very per-file oriented.
What do you think about this ? Should this be done as part of
check-package, or a separate checker ?
Best regards,
Thomas
[1] http://patchwork.ozlabs.org/patch/910991/
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-05-13 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 16:33 [Buildroot] [PATCH v2 1/2] toolchain/buildroot: Fix symbol for uClibc Petr Vorel
2018-05-09 16:33 ` [Buildroot] [PATCH v2 2/2] package/libmediaart: Fix config prefix Petr Vorel
2018-05-13 19:19 ` Thomas Petazzoni [this message]
2018-05-14 4:09 ` [Buildroot] [PATCH v2 1/2] toolchain/buildroot: Fix symbol for uClibc Ricardo Martincoski
2018-05-13 20:10 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180513211943.6a0e19b8@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.