From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZpEjs3tI/q+5CH7cJiLfdn/ZQlIP21TpqViYMWHL1gZSuJhwYN3CwtNUFzwteXoNTJ49Khu ARC-Seal: i=1; a=rsa-sha256; t=1526280687; cv=none; d=google.com; s=arc-20160816; b=r43maKvMt42O9Dd+LH0dvIJPjmRkb1PSUz3UyDmP7ECy0qjkZOOkqcLSKJxx/b4Xia zWrTLJOnBRgMWcKxWcUIAZ5cAt+66Sv2/m3Kac71ny/KbfFK/87PcRjmDqs+v1IOMfJA 2yCqy8kJP+QT+V1HaM9KR3FSWFW/sd1hv6f9cwOhBdWAy7ZD1lwS07owiriGwhpYqAdZ fNkdzqCjjjBgs0BcmYBBtzV6aCc8kEwOC07jtmwYCIJpT5VhaNnIy7YV0dFB3Yj85vW7 nebT+9BRX39yFkYrlfQvCn57pJ+pgmjF8v372Hh2nMCW49AhkTDagjlTBa/TuHDvYgzu 9OUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=rrTJVqH0AssdxjMCMCxskc0Q/dsooBAlwXAszzCrUGI=; b=zwoit/z46QKxx9Pq/JyNderX4+urT90TiVnvOC1koPKQUwB2Cxq1jDDTnMo4vf6bBH KCQsGaCKuU3zjitCyTrQD4w0BCXslJ049bsWm4G7CK7fSS4Ubq7td1sUtGUq3eTubO/D 9ijRdFoKXi5F+9uJM3vIXQMdO4nOqloP00eGYsRurBX7ZhXN1g63diWKz+65bQWFAu6t E1A2f3G2ziBd+LbCAedQ8+VTe7ZFdSItiQM7RR618QlvPlWBA6rFiRffr9hYRFUBEc/F 08y1fVaS7PwHir/a108AOlDFqLv/NW3iXdYfVqSOy42GiEfbhavUJIP+c9RPQaY6JAJj xpIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fCq112mN; spf=pass (google.com: domain of srs0=ywzk=ib=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=ywzk=IB=linuxfoundation.org=gregkh@kernel.org Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fCq112mN; spf=pass (google.com: domain of srs0=ywzk=ib=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=ywzk=IB=linuxfoundation.org=gregkh@kernel.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Teng Qin , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Chenbo Feng , Lorenzo Colitti Subject: [PATCH 4.4 02/56] bpf: map_get_next_key to return first key on NULL Date: Mon, 14 May 2018 08:48:07 +0200 Message-Id: <20180514064755.103747262@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180514064754.853201981@linuxfoundation.org> References: <20180514064754.853201981@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1600421298698641649?= X-GMAIL-MSGID: =?utf-8?q?1600421298698641649?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Teng Qin commit 8fe45924387be6b5c1be59a7eb330790c61d5d10 upstream. When iterating through a map, we need to find a key that does not exist in the map so map_get_next_key will give us the first key of the map. This often requires a lot of guessing in production systems. This patch makes map_get_next_key return the first key when the key pointer in the parameter is NULL. Signed-off-by: Teng Qin Signed-off-by: Alexei Starovoitov Acked-by: Daniel Borkmann Signed-off-by: David S. Miller Signed-off-by: Chenbo Feng Cc: Lorenzo Colitti Signed-off-by: Greg Kroah-Hartman --- kernel/bpf/arraymap.c | 2 +- kernel/bpf/hashtab.c | 9 +++++---- kernel/bpf/syscall.c | 18 +++++++++++------- 3 files changed, 17 insertions(+), 12 deletions(-) --- a/kernel/bpf/arraymap.c +++ b/kernel/bpf/arraymap.c @@ -102,7 +102,7 @@ static void *array_map_lookup_elem(struc static int array_map_get_next_key(struct bpf_map *map, void *key, void *next_key) { struct bpf_array *array = container_of(map, struct bpf_array, map); - u32 index = *(u32 *)key; + u32 index = key ? *(u32 *)key : U32_MAX; u32 *next = (u32 *)next_key; if (index >= array->map.max_entries) { --- a/kernel/bpf/hashtab.c +++ b/kernel/bpf/hashtab.c @@ -169,12 +169,15 @@ static int htab_map_get_next_key(struct struct hlist_head *head; struct htab_elem *l, *next_l; u32 hash, key_size; - int i; + int i = 0; WARN_ON_ONCE(!rcu_read_lock_held()); key_size = map->key_size; + if (!key) + goto find_first_elem; + hash = htab_map_hash(key, key_size); head = select_bucket(htab, hash); @@ -182,10 +185,8 @@ static int htab_map_get_next_key(struct /* lookup the key */ l = lookup_elem_raw(head, hash, key, key_size); - if (!l) { - i = 0; + if (!l) goto find_first_elem; - } /* key was found, get next key in the same bucket */ next_l = hlist_entry_safe(rcu_dereference_raw(hlist_next_rcu(&l->hash_node)), --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c @@ -390,14 +390,18 @@ static int map_get_next_key(union bpf_at if (IS_ERR(map)) return PTR_ERR(map); - err = -ENOMEM; - key = kmalloc(map->key_size, GFP_USER); - if (!key) - goto err_put; + if (ukey) { + err = -ENOMEM; + key = kmalloc(map->key_size, GFP_USER); + if (!key) + goto err_put; - err = -EFAULT; - if (copy_from_user(key, ukey, map->key_size) != 0) - goto free_key; + err = -EFAULT; + if (copy_from_user(key, ukey, map->key_size) != 0) + goto free_key; + } else { + key = NULL; + } err = -ENOMEM; next_key = kmalloc(map->key_size, GFP_USER);