All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 04/11] nvme: always failover on path or transport errors
Date: Mon, 14 May 2018 09:56:39 +0200	[thread overview]
Message-ID: <20180514075646.28823-5-hch@lst.de> (raw)
In-Reply-To: <20180514075646.28823-1-hch@lst.de>

NVMe 1.3 TP 4028 introduced a new status code type 3h for
"Path Related Status".  We should always retry on another path for this
class of errors, without even trying to decode them.

Signed-off-by: Christoph Hellwig <hch at lst.de>
---
 drivers/nvme/host/multipath.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index d7b664ae5923..b5a00853fbe2 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -59,6 +59,8 @@ bool nvme_req_needs_failover(struct request *req, blk_status_t error)
 {
 	if (!(req->cmd_flags & REQ_NVME_MPATH))
 		return false;
+	if (nvme_req(req)->status & 0x300)
+		return true;
 	return blk_path_error(error);
 }
 
-- 
2.17.0

  parent reply	other threads:[~2018-05-14  7:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  7:56 dusted off ANA code Christoph Hellwig
2018-05-14  7:56 ` [PATCH 01/11] nvme.h: untangle AEN notice definitions Christoph Hellwig
2018-05-14  7:56 ` [PATCH 02/11] nvme.h: add ANA definitions Christoph Hellwig
2018-05-14  7:56 ` [PATCH 03/11] nvme: add support for the log specific field Christoph Hellwig
2018-05-14  7:56 ` Christoph Hellwig [this message]
2018-05-14  7:56 ` [PATCH 05/11] nvme: add ANA support Christoph Hellwig
2018-05-14  7:56 ` [PATCH 06/11] nvmet: refactor AER handling Christoph Hellwig
2018-05-14  7:56 ` [PATCH 07/11] nvmet: add a new nvmet_zero_sgl helper Christoph Hellwig
2018-05-14  7:56 ` [PATCH 08/11] nvmet: split log page implementation Christoph Hellwig
2018-05-14  7:56 ` [PATCH 09/11] nvmet: track and limit the number of namespaces per subsystem Christoph Hellwig
2018-05-14  7:56 ` [PATCH 10/11] nvmet: add minimal ANA support Christoph Hellwig
2018-05-14  7:56 ` [PATCH 11/11] nvmet: support configuring additional ANA groups Christoph Hellwig
2018-05-14  8:09 ` dusted off ANA code Hannes Reinecke
2018-05-14  8:11 ` Hannes Reinecke
2018-05-14  8:57   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514075646.28823-5-hch@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.