From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752438AbeENJhe (ORCPT ); Mon, 14 May 2018 05:37:34 -0400 Received: from mail.skyhub.de ([5.9.137.197]:50672 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752039AbeENJhc (ORCPT ); Mon, 14 May 2018 05:37:32 -0400 Date: Mon, 14 May 2018 11:37:03 +0200 From: Borislav Petkov To: Randy Dunlap Cc: LKML , Linux Edac Mailing List , Andrew Morton , Tony Luck , Mauro Carvalho Chehab Subject: Re: [PATCH v2] edac: fix skx_edac build error when ACPI_NFIT=m Message-ID: <20180514093703.GB23049@pd.tnic> References: <3af91354-8e19-d2af-1bba-ced8dce053f1@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3af91354-8e19-d2af-1bba-ced8dce053f1@infradead.org> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 13, 2018 at 10:35:44AM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Prevent build error when CONFIG_ACPI_NFIT=m and CONFIG_EDAC_SKX=y > by limiting EDAC_SKX based on how ACPI_NFIT is set. > > Fixes this build error: > drivers/edac/skx_edac.o: In function `get_nvdimm_info': > ../drivers/edac/skx_edac.c:399: undefined reference to `nfit_get_smbios_id' > > Fixes: 58ca9ac1463d ("EDAC, skx_edac: Detect non-volatile DIMMs") > > Reported-by: kbuild test robot > Signed-off-by: Randy Dunlap > Cc: Tony Luck > Cc: Borislav Petkov > Cc: Mauro Carvalho Chehab > Cc: stable@vger.kernel.org > --- > drivers/edac/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > v2: add comment in Kconfig file > > --- lnx-417-rc4.orig/drivers/edac/Kconfig > +++ lnx-417-rc4/drivers/edac/Kconfig > @@ -232,6 +232,7 @@ config EDAC_SBRIDGE > config EDAC_SKX > tristate "Intel Skylake server Integrated MC" > depends on PCI && X86_64 && X86_MCE_INTEL && PCI_MMCONFIG > + depends on ACPI_NFIT || !ACPI_NFIT # if ACPI_NFIT=m, EDAC_SKX can't be y > select DMI > help > Support for error detection and correction the Intel -- Applied, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] edac: fix skx_edac build error when ACPI_NFIT=m From: Borislav Petkov Message-Id: <20180514093703.GB23049@pd.tnic> Date: Mon, 14 May 2018 11:37:03 +0200 To: Randy Dunlap Cc: LKML , Linux Edac Mailing List , Andrew Morton , Tony Luck , Mauro Carvalho Chehab List-ID: T24gU3VuLCBNYXkgMTMsIDIwMTggYXQgMTA6MzU6NDRBTSAtMDcwMCwgUmFuZHkgRHVubGFwIHdy b3RlOgo+IEZyb206IFJhbmR5IER1bmxhcCA8cmR1bmxhcEBpbmZyYWRlYWQub3JnPgo+IAo+IFBy ZXZlbnQgYnVpbGQgZXJyb3Igd2hlbiBDT05GSUdfQUNQSV9ORklUPW0gYW5kIENPTkZJR19FREFD X1NLWD15Cj4gYnkgbGltaXRpbmcgRURBQ19TS1ggYmFzZWQgb24gaG93IEFDUElfTkZJVCBpcyBz ZXQuCj4gCj4gRml4ZXMgdGhpcyBidWlsZCBlcnJvcjoKPiBkcml2ZXJzL2VkYWMvc2t4X2VkYWMu bzogSW4gZnVuY3Rpb24gYGdldF9udmRpbW1faW5mbyc6Cj4gLi4vZHJpdmVycy9lZGFjL3NreF9l ZGFjLmM6Mzk5OiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBuZml0X2dldF9zbWJpb3NfaWQnCj4g Cj4gRml4ZXM6IDU4Y2E5YWMxNDYzZCAoIkVEQUMsIHNreF9lZGFjOiBEZXRlY3Qgbm9uLXZvbGF0 aWxlIERJTU1zIikKPiAKPiBSZXBvcnRlZC1ieToga2J1aWxkIHRlc3Qgcm9ib3QgPGxrcEBpbnRl bC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUmFuZHkgRHVubGFwIDxyZHVubGFwQGluZnJhZGVhZC5v cmc+Cj4gQ2M6IFRvbnkgTHVjayA8dG9ueS5sdWNrQGludGVsLmNvbT4KPiBDYzogQm9yaXNsYXYg UGV0a292IDxicEBhbGllbjguZGU+Cj4gQ2M6IE1hdXJvIENhcnZhbGhvIENoZWhhYiA8bWNoZWhh YkBrZXJuZWwub3JnPgo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gLS0tCj4gIGRyaXZl cnMvZWRhYy9LY29uZmlnIHwgICAgMSArCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KQo+IAo+IHYyOiBhZGQgY29tbWVudCBpbiBLY29uZmlnIGZpbGUKPiAKPiAtLS0gbG54LTQxNy1y YzQub3JpZy9kcml2ZXJzL2VkYWMvS2NvbmZpZwo+ICsrKyBsbngtNDE3LXJjNC9kcml2ZXJzL2Vk YWMvS2NvbmZpZwo+IEBAIC0yMzIsNiArMjMyLDcgQEAgY29uZmlnIEVEQUNfU0JSSURHRQo+ICBj b25maWcgRURBQ19TS1gKPiAgCXRyaXN0YXRlICJJbnRlbCBTa3lsYWtlIHNlcnZlciBJbnRlZ3Jh dGVkIE1DIgo+ICAJZGVwZW5kcyBvbiBQQ0kgJiYgWDg2XzY0ICYmIFg4Nl9NQ0VfSU5URUwgJiYg UENJX01NQ09ORklHCj4gKwlkZXBlbmRzIG9uIEFDUElfTkZJVCB8fCAhQUNQSV9ORklUICMgaWYg QUNQSV9ORklUPW0sIEVEQUNfU0tYIGNhbid0IGJlIHkKPiAgCXNlbGVjdCBETUkKPiAgCWhlbHAK PiAgCSAgU3VwcG9ydCBmb3IgZXJyb3IgZGV0ZWN0aW9uIGFuZCBjb3JyZWN0aW9uIHRoZSBJbnRl bAotLS0KCkFwcGxpZWQsIHRoYW5rcy4K