* [PATCH blktests] nvme: Add command timeout injection test
@ 2018-05-14 20:02 ` Keith Busch
0 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2018-05-14 20:02 UTC (permalink / raw)
To: Omar Sandoval, Johannes Thumshirn, linux-block, linux-nvme; +Cc: Keith Busch
This test will run a background IO process and inject an admin command
with a very short timeout that is all but guaranteed to expire without
a completion: the async event request.
Signed-off-by: Keith Busch <keith.busch@intel.com>
---
tests/nvme/005 | 42 ++++++++++++++++++++++++++++++++++++++++++
tests/nvme/005.out | 3 +++
2 files changed, 45 insertions(+)
create mode 100755 tests/nvme/005
create mode 100644 tests/nvme/005.out
diff --git a/tests/nvme/005 b/tests/nvme/005
new file mode 100755
index 0000000..3fe9cbe
--- /dev/null
+++ b/tests/nvme/005
@@ -0,0 +1,42 @@
+#!/bin/bash
+#
+# Regression test for timeout handling.
+#
+# Copyright (C) 2018 Keith Busch
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+DESCRIPTION="test nvme admin command timeout handling with in-flight io"
+
+QUICK=1
+
+requires() {
+ _have_program nvme
+}
+
+test_device() {
+ echo "Running ${TEST_NAME}"
+
+ # start fio job
+ _run_fio_rand_io --filename="${TEST_DEV}" --time_based --runtime=20 &
+
+ sleep 5
+
+ # send nvme admin command 'async event request', which will surely time out
+ nvme admin-passthru ${TEST_DEV} -o 0xc --timeout=1
+
+ wait
+
+ echo "Test complete"
+}
diff --git a/tests/nvme/005.out b/tests/nvme/005.out
new file mode 100644
index 0000000..f4ff837
--- /dev/null
+++ b/tests/nvme/005.out
@@ -0,0 +1,3 @@
+Running nvme/005
+passthru: Interrupted system call
+Test complete
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH blktests] nvme: Add command timeout injection test
@ 2018-05-14 20:02 ` Keith Busch
0 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2018-05-14 20:02 UTC (permalink / raw)
This test will run a background IO process and inject an admin command
with a very short timeout that is all but guaranteed to expire without
a completion: the async event request.
Signed-off-by: Keith Busch <keith.busch at intel.com>
---
tests/nvme/005 | 42 ++++++++++++++++++++++++++++++++++++++++++
tests/nvme/005.out | 3 +++
2 files changed, 45 insertions(+)
create mode 100755 tests/nvme/005
create mode 100644 tests/nvme/005.out
diff --git a/tests/nvme/005 b/tests/nvme/005
new file mode 100755
index 0000000..3fe9cbe
--- /dev/null
+++ b/tests/nvme/005
@@ -0,0 +1,42 @@
+#!/bin/bash
+#
+# Regression test for timeout handling.
+#
+# Copyright (C) 2018 Keith Busch
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+DESCRIPTION="test nvme admin command timeout handling with in-flight io"
+
+QUICK=1
+
+requires() {
+ _have_program nvme
+}
+
+test_device() {
+ echo "Running ${TEST_NAME}"
+
+ # start fio job
+ _run_fio_rand_io --filename="${TEST_DEV}" --time_based --runtime=20 &
+
+ sleep 5
+
+ # send nvme admin command 'async event request', which will surely time out
+ nvme admin-passthru ${TEST_DEV} -o 0xc --timeout=1
+
+ wait
+
+ echo "Test complete"
+}
diff --git a/tests/nvme/005.out b/tests/nvme/005.out
new file mode 100644
index 0000000..f4ff837
--- /dev/null
+++ b/tests/nvme/005.out
@@ -0,0 +1,3 @@
+Running nvme/005
+passthru: Interrupted system call
+Test complete
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH blktests] nvme: Add command timeout injection test
2018-05-14 20:02 ` Keith Busch
@ 2018-05-14 20:10 ` Omar Sandoval
-1 siblings, 0 replies; 4+ messages in thread
From: Omar Sandoval @ 2018-05-14 20:10 UTC (permalink / raw)
To: Keith Busch; +Cc: Johannes Thumshirn, linux-block, linux-nvme
On Mon, May 14, 2018 at 02:02:37PM -0600, Keith Busch wrote:
> This test will run a background IO process and inject an admin command
> with a very short timeout that is all but guaranteed to expire without
> a completion: the async event request.
Thanks, a few comments below.
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> ---
> tests/nvme/005 | 42 ++++++++++++++++++++++++++++++++++++++++++
> tests/nvme/005.out | 3 +++
> 2 files changed, 45 insertions(+)
> create mode 100755 tests/nvme/005
> create mode 100644 tests/nvme/005.out
>
> diff --git a/tests/nvme/005 b/tests/nvme/005
> new file mode 100755
> index 0000000..3fe9cbe
> --- /dev/null
> +++ b/tests/nvme/005
> @@ -0,0 +1,42 @@
> +#!/bin/bash
> +#
> +# Regression test for timeout handling.
Is there a specific patch that this is testing? If so, could you add:
Regression test for patch "so and so".
> +# Copyright (C) 2018 Keith Busch
> +#
> +# This program is free software: you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation, either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +
> +DESCRIPTION="test nvme admin command timeout handling with in-flight io"
> +
> +QUICK=1
> +
> +requires() {
> + _have_program nvme
Also needs && _have_fio.
> +}
> +
> +test_device() {
> + echo "Running ${TEST_NAME}"
> +
> + # start fio job
> + _run_fio_rand_io --filename="${TEST_DEV}" --time_based --runtime=20 &
> +
> + sleep 5
> +
> + # send nvme admin command 'async event request', which will surely time out
> + nvme admin-passthru ${TEST_DEV} -o 0xc --timeout=1
Missing quotes around ${TEST_DEV}.
> + wait
> +
> + echo "Test complete"
> +}
> diff --git a/tests/nvme/005.out b/tests/nvme/005.out
> new file mode 100644
> index 0000000..f4ff837
> --- /dev/null
> +++ b/tests/nvme/005.out
> @@ -0,0 +1,3 @@
> +Running nvme/005
> +passthru: Interrupted system call
> +Test complete
> --
> 2.14.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH blktests] nvme: Add command timeout injection test
@ 2018-05-14 20:10 ` Omar Sandoval
0 siblings, 0 replies; 4+ messages in thread
From: Omar Sandoval @ 2018-05-14 20:10 UTC (permalink / raw)
On Mon, May 14, 2018@02:02:37PM -0600, Keith Busch wrote:
> This test will run a background IO process and inject an admin command
> with a very short timeout that is all but guaranteed to expire without
> a completion: the async event request.
Thanks, a few comments below.
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> tests/nvme/005 | 42 ++++++++++++++++++++++++++++++++++++++++++
> tests/nvme/005.out | 3 +++
> 2 files changed, 45 insertions(+)
> create mode 100755 tests/nvme/005
> create mode 100644 tests/nvme/005.out
>
> diff --git a/tests/nvme/005 b/tests/nvme/005
> new file mode 100755
> index 0000000..3fe9cbe
> --- /dev/null
> +++ b/tests/nvme/005
> @@ -0,0 +1,42 @@
> +#!/bin/bash
> +#
> +# Regression test for timeout handling.
Is there a specific patch that this is testing? If so, could you add:
Regression test for patch "so and so".
> +# Copyright (C) 2018 Keith Busch
> +#
> +# This program is free software: you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation, either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +
> +DESCRIPTION="test nvme admin command timeout handling with in-flight io"
> +
> +QUICK=1
> +
> +requires() {
> + _have_program nvme
Also needs && _have_fio.
> +}
> +
> +test_device() {
> + echo "Running ${TEST_NAME}"
> +
> + # start fio job
> + _run_fio_rand_io --filename="${TEST_DEV}" --time_based --runtime=20 &
> +
> + sleep 5
> +
> + # send nvme admin command 'async event request', which will surely time out
> + nvme admin-passthru ${TEST_DEV} -o 0xc --timeout=1
Missing quotes around ${TEST_DEV}.
> + wait
> +
> + echo "Test complete"
> +}
> diff --git a/tests/nvme/005.out b/tests/nvme/005.out
> new file mode 100644
> index 0000000..f4ff837
> --- /dev/null
> +++ b/tests/nvme/005.out
> @@ -0,0 +1,3 @@
> +Running nvme/005
> +passthru: Interrupted system call
> +Test complete
> --
> 2.14.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-14 20:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 20:02 [PATCH blktests] nvme: Add command timeout injection test Keith Busch
2018-05-14 20:02 ` Keith Busch
2018-05-14 20:10 ` Omar Sandoval
2018-05-14 20:10 ` Omar Sandoval
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.