From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Andy Shevchenko
<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH v1] iommu: Remove extra NULL check when call strtobool()
Date: Tue, 15 May 2018 16:29:36 +0200 [thread overview]
Message-ID: <20180515142936.nagtyybvu3tfgrsv@8bytes.org> (raw)
In-Reply-To: <20180514162225.81914-1-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On Mon, May 14, 2018 at 07:22:25PM +0300, Andy Shevchenko wrote:
> strtobool() does check for NULL parameter already. No need to repeat.
>
> While here, switch to kstrtobool() and unshadow actual error code
> (which is still -EINVAL).
>
> No functional change intended.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Applied, thanks.
prev parent reply other threads:[~2018-05-15 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 16:22 [PATCH v1] iommu: Remove extra NULL check when call strtobool() Andy Shevchenko
[not found] ` <20180514162225.81914-1-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-05-15 14:29 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515142936.nagtyybvu3tfgrsv@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.