From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: neil@brown.name, gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH] staging: mt7621-gpio: avoid use of globals and use a drvdata allocated structure
Date: Tue, 15 May 2018 17:56:42 +0300 [thread overview]
Message-ID: <20180515145642.w2i5a2zymgjwx65m@mwanda> (raw)
In-Reply-To: <20180515144502.b4d3nf7snpje3kdj@mwanda>
On Tue, May 15, 2018 at 05:45:03PM +0300, Dan Carpenter wrote:
> Normally I would say just change > to >= but
> we're not using the first element of the gc_map[] array so perhaps we
> intended to subtract one?
Oh. We do use the first element. My bad. I got confused between
"id" and "*id". My bad.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-05-15 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 12:14 [PATCH] staging: mt7621-gpio: avoid use of globals and use a drvdata allocated structure Sergio Paracuellos
2018-05-15 14:45 ` Dan Carpenter
2018-05-15 14:56 ` Dan Carpenter [this message]
2018-05-15 17:02 ` Sergio Paracuellos
2018-05-15 23:59 ` NeilBrown
2018-05-16 5:02 ` Sergio Paracuellos
2018-05-16 6:00 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515145642.w2i5a2zymgjwx65m@mwanda \
--to=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=neil@brown.name \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.